ament_cppcheck is failing with a KeyError on rmw_connext_cpp about ament_lint

[wjwwood]

@dirk-thomas and I were just talking about that. I pointed out to him that it's failing on the farm:

http://ci.ros2.org/job/ros2_batch_ci_linux/6/testReport/rmw_connext_cpp/cppcheck/missing_result/

He said he's going to look into it.

[dirk-thomas]

As a follow up the linter indicates a memory leak in rmw_connext_cpp:http://ci.ros2.org/job/ros2_batch_ci_linux/7/testReport/rmw_connext_cpp/cppcheck/error__memleak__src_functions_cpp_954_/

@wjwwood Are you already in the process of refactoring the allocation / deallocation in rmw?

[wjwwood]

Yes. I'm almost done with connext dynamic. I'll open some pull request when I finish it. Then I'll do connext and open splice too. I'll make sure to follow up on that warning explicitly.

[tfoote]

There's a debugging print in that commit: 58515dc#diff-e801a73ffe02dfdbed0c68181d791d5eR121

[dirk-thomas]

Thanks for catching that: removed in c4098a8