amar1729 / homebrew-formulae Goto Github PK

View Code? Open in Web Editor NEW

21.0 4.0 6.0 78 KB

My own homebrew tap

Ruby 100.00%

homebrew homebrew-tap

homebrew-formulae's People

Contributors

Stargazers

Watchers

Forkers

psliwka thread1 colinlq starrwulfe stweil maswag

homebrew-formulae's Issues

3.0.7 doesn't work under Big Sur

Hello! Just wanted to let you know, that 3.0.7 version doesn't work with big sur. Or am i doing something wrong?

I'm trying to use it with a chrome extension called "Browserpass", when i open it - it says: "Error: Error: Specified native messaging host not found."

libguestfs 1.40.2 did not build - ocamlfind: Config file not found

Tail end of build shows:

ocamlfind ocamlopt -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-g -O2 -fno-strict-overflow -Wno-strict-overflow' -package str,unix -I . -c guestfs_config.ml -o guestfs_config.cmx
ocamlfind ocamlopt -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-g -O2 -fno-strict-overflow -Wno-strict-overflow' -package str,unix -I . -c stringMap.ml -o stringMap.cmx
ocamlfind ocamlopt -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-g -O2 -fno-strict-overflow -Wno-strict-overflow' -package str,unix -I . -c stringSet.ml -o stringSet.cmx
ocamlfind: Config file not found - neither /usr/local/etc/findlib.conf nor the directory /usr/local/etc/findlib.conf.d
make[2]: *** [guestfs_config.cmx] Error 2
make[2]: *** Waiting for unfinished jobs....
ocamlfind: Config file not found - neither /usr/local/etc/findlib.conf nor the directory /usr/local/etc/findlib.conf.d
make[2]: *** [stringMap.cmx] Error 2
ocamlfind: Config file not found - neither /usr/local/etc/findlib.conf nor the directory /usr/local/etc/findlib.conf.d
make[2]: *** [stringSet.cmx] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Formula
Tap: amar1729/formulae
Path: /usr/local/Homebrew/Library/Taps/amar1729/homebrew-formulae/libguestfs.rb

Configuration
HOMEBREW_VERSION: 2.2.10
ORIGIN: https://github.com/Homebrew/brew
HEAD: 48a1637b24a0c329905a981f4cff547c7fa47943
Last commit: 3 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: f62624705a55fc7233b9629081926146b2d6f416
Core tap last commit: 49 minutes ago
HOMEBREW_PREFIX: /usr/local
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
Clang: 11.0 build 1100
Git: 2.21.1 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.2-x86_64
CLT: 11.3.1.0.1.1576735732
Xcode: N/A

Other info available on request, if it would help. Will keep trying to track this down here as well.

Thank you!

Possible Issue: Browserpass 3.1.0

All, I just merged #26 , but the homebrew CI meant to build bottles on merges failed. As a result, the browserpass 3.1.0 formula does NOT have bottles, and so installing will require building the project (shouldn't take too long). I'm making this issue so Homebrew will identify it if a brew install fails any time soon; if you have any problems, please comment here!

Edit: As noted by others below, you may have to explicitly build from source, e.g.:

brew update
brew upgrade --build-from-source browserpass

# or, if you uninstalled it first
brew update
brew uninstall browserpass
brew install --build-from-source browserpass

Installation failed

➜ .browserpass brew tap amar1729/formulae

➜  .browserpass brew install amar1729/formulae/browserpass
==> Installing browserpass from amar1729/formulae
==> Downloading https://github.com/browserpass/browserpass-native/releases/download/3.0.5/browserpass-darwin64-3.0.5.tar.gz
Already downloaded: /Users/ibuymov/Library/Caches/Homebrew/downloads/6aa9ca4354af24f15557c3d603c0e6619ee0e8fb793e455320f303a5d4f3de6b--browserpass-darwin64-3.0.5.tar.gz
==> make configure
Last 15 lines from /Users/ibuymov/Library/Logs/Homebrew/browserpass/01.make:
2019-04-13 18:18:02 +0300

make
configure

/usr/local/Homebrew/Library/Homebrew/shims/mac/super/sed -i 's|"path": ".*"|"path": "'"/usr/local/Cellar/browserpass/3.0.5/bin/browserpass-darwin64"'"|' browser-files/chromium-host.json
sed: 1: "browser-files/chromium- ...": undefined label 'rowser-files/chromium-host.json'
make: *** [configure] Error 1

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/amar1729/homebrew-formulae/issues

# cat /Users/ibuymov/Library/Logs/Homebrew/browserpass/01.make
2019-04-13 19:52:25 +0300

make
configure

/usr/local/Homebrew/Library/Homebrew/shims/mac/super/sed -i 's|"path": ".*"|"path": "'"/usr/local/Cellar/browserpass/3.0.5/bin/browserpass-darwin64"'"|' browser-files/chromium-host.json
sed: 1: "browser-files/chromium- ...": undefined label 'rowser-files/chromium-host.json'
make: *** [configure] Error 1

HOMEBREW_VERSION: 2.1.0
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1337da0f891aebb85accb094d63e401da1b53cba
Last commit: 9 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 1b4a71255a5762d85a2927883f53d393becc53a5
Core tap last commit: 89 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CACHE: /Users/ibuymov/Library/Caches/Homebrew
CPU: quad-core 64-bit kabylake
Homebrew Ruby: 2.3.7 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 10.0 build 1001
Git: 2.21.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 11
macOS: 10.14.4-x86_64
CLT: 10.2.0.0.1.1552586384
Xcode: N/A
CLT headers: 10.2.0.0.1.1552586384

HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j4
CMAKE_PREFIX_PATH: /usr/local/opt/gettext:/usr/local/opt/libffi:/usr/local/opt/openssl:/usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libxml2:/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_PATH: /usr/local/opt/libtasn1/lib/pkgconfig:/usr/local/opt/nettle/lib/pkgconfig:/usr/local/opt/libffi/lib/pkgconfig:/usr/local/opt/p11-kit/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/libevent/lib/pkgconfig:/usr/local/opt/unbound/lib/pkgconfig:/usr/local/opt/gnutls/lib/pkgconfig:/usr/local/opt/libgpg-error/lib/pkgconfig:/usr/local/opt/libassuan/lib/pkgconfig:/usr/local/opt/libusb/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/10.14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk
ACLOCAL_PATH: /usr/local/opt/gettext/share/aclocal:/usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/local/opt/coreutils/bin:/usr/local/opt/gnu-sed/bin:/usr/local/opt/adns/bin:/usr/local/opt/gettext/bin:/usr/local/opt/libtasn1/bin:/usr/local/opt/nettle/bin:/usr/local/opt/p11-kit/bin:/usr/local/opt/openssl/bin:/usr/local/opt/libevent/bin:/usr/local/opt/gnutls/bin:/usr/local/opt/libgpg-error/bin:/usr/local/opt/libassuan/bin:/usr/local/opt/libgcrypt/bin:/usr/local/opt/libksba/bin:/usr/local/opt/npth/bin:/usr/local/opt/pinentry/bin:/usr/local/opt/gnupg/bin:/usr/local/opt/pinentry-mac/bin:/usr/bin:/bin:/usr/sbin:/sbin

Cannot tap

Was trying to install browserpass for my Mac via brew install amar1729/formulae/browserpass, which both taps and installs the formula.

Unfortunately, it appears that homebrew fails with a syntax issue in a different formula as it's part of the tap, even though I don't (to my knowledge) use that formula at all. libguestfs seems to have a now-unsupported syntax. I remember getting warnings about this on a different M1 Mac I was setting up and now it seems to have switched to being an outright failure.

I'm assuming I'll be able to grab the formula that I want and add it to my own tap, but wanted to highlight this.

==> Tapping amar1729/formulae
Cloning into '/opt/homebrew/Library/Taps/amar1729/homebrew-formulae'...
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (13/13), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 331 (delta 4), reused 12 (delta 4), pack-reused 318
Receiving objects: 100% (331/331), 62.60 KiB | 1001.00 KiB/s, done.
Resolving deltas: 100% (181/181), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/amar1729/homebrew-formulae/[email protected]
[email protected]: Calling depends_on :osxfuse is disabled! There is no replacement.
Please report this issue to the amar1729/formulae tap (not Homebrew/brew or Homebrew/core):
  /opt/homebrew/Library/Taps/amar1729/homebrew-formulae/[email protected]:91

Error: Cannot tap amar1729/formulae: invalid syntax in tap!

browserpass-native outdated

GPG Verification for browserpass

original issue from the browserpass-native repo

The homebrew-downloaded binary browserpass-3.0.6.mojave.bottle.tar.gz does not match the signature in browserpass-darwin64-3.0.6.tar.gz.asc. This is because the bottle is a homebrew-created binary which uses the upstream browserpass-darwin64-3.0.6.tar.gz.

Due to the security-focused nature of browserpass, the question of gpg verification of the source has been raised.

There is actually an old issue for the brew tool that proposed gpg key verification in formulae. Unfortunately the prevailing opinion from maintainers was that sha256 verification was "enough" for verification of upstream tarballs rather than the overhead of dealing with keys and proper signature verification.

I am not sure if there's currently a way to gpg verify the source tarball inside a homebrew formula, but I can look into it.

tl;dr: End-User verification

In the meantime, there is an option the end-user has for verification of upstream binaries themselves:

# ONLY download the build sources defined in the browserpass formula
# this will download browserpass-darwin64.tar.gz and a testfile (used in the brew test block)
$ brew fetch --build-from-source browserpass

==> Downloading https://github.com/browserpass/browserpass-native/releases/download/3.0.6/browserpass-darwin64-3.0.6.tar.gz
Already downloaded: /Users/amar/Library/Caches/Homebrew/downloads/7235f172d5fde8cdfb6bc9d73c9d51edecf76ff6413a6d239fac5bd918bda3f3--browserpass-darwin64-3.0.6.tar.gz
SHA256: 422bc6dd1270a877af6ac7801a75b4c4b57171d675c071470f31bc24196701e3

# then you can verify this source yourself (note that the path for the .asc and the tarball will change in future releases):
$ gpg --verify browserpass-darwin64-3.0.6.tar.gz.asc ~/Library/Caches/Homebrew/downloads/7235f172d5fde8cdfb6bc9d73c9d51edecf76ff6413a6d239fac5bd918bda3f3--browserpass-darwin64-3.0.6.tar.gz

After this, you can view the homebrew formula file with

$ brew cat browserpass

so you can verify I'm not applying any strange patches to the source tarball, simply installing it.

You then can run:

$ brew install browserpass

Note

While brew install supports a --build-from-source flag, this flag doesn't actually build browserpass from source since the upstream provides a prebuilt binary. I can change the formula to actually build browserpass-native from source if there's significant want for it.

PREFIX='/usr/local/opt/browserpass' make hosts-brave-user -f /usr/local/opt/browserpass/lib/browserpass/Makefile
make: /usr/local/opt/browserpass/lib/browserpass/Makefile: No such file or directory
make: *** No rule to make target `/usr/local/opt/browserpass/lib/browserpass/Makefile'.  Stop.

Clearly the issue is that 3.0.7 only goes to Catalina, not sure if it's a simple fix or not. Ruby is not my strength.