amacd31 / geofabric_tools Goto Github PK

Thanks for making this code available, it looks very useful. In the SQL query I think you also have to match the ExternalSegmentNoLink attribute, for the subcatchments that are outside the network links. Based on the example, in the attached image the selected polygon should be included (I think), and can be found matching ExternalSegmentNoLink=2784950, which matches the adjoining subcatchment that has been included.

I also had trouble with larger catchment areas returning NULL, but if it turn on the --exclude_sinks switch it does return a polygon. So it must be caused by the ST_BuildArea or ST_ExteriorRing functions failing. For example, try and get the catchment contributing to Cotter Dam at 148.94,-35.32.

Thanks again,

Larger catchment areas sometime result in a null geojson. If using --exclude_sinks it does successfully return a polygon. So it must be caused by the ST_BuildArea or ST_ExteriorRing functions failing. For example, the catchment contributing to Cotter Dam at 148.94,-35.32 results in a null geojson.

(this was initially raised in #1, but I think warrants its own issue)