am-kantox / dry-mutations

Mutations gem interface implemented with `dry-rb`’s validation schemas.

Aleksei � Matiushkin

Sniffing Around

• 🐘 https://mastodon.social/@mudasobwa
• 📒 https://stackoverflow.com/users/2035262/aleksei-matiushkin?tab=topactivity
• ✍ https://rocket-science.ru
• 📫 mailto:[email protected]
• 🗓️ October, 0 (aka September, 30)
• ⚡ I’m still more functional than object-oriented

The Summing Up

Selected SO Answers

• How to get list of registered custom elements
• Finding the cause of a memory leak in Ruby
• Remove nil from list
• Is there an equivalent to MODULE for named functions in Elixir/ Erlang?
• Concise way to run code 0 to N times in Elixir

dry-mutations's Issues

Input of array type with class specified fails

required do
  array :payment_orders, class: StandalonePaymentOrder
end

and get

Mutations::ValidationException:
       payment_orders.0: “must be a hash”

Dates are not coerced

Mutations accept as date a String that can be parsed into a Date. This same behavior is required in dry-mutations.

Dojo recommendations

• run(params, more_params) not working for chain
• unhelpful nested exceptions
• optional -> methods
• nested add_error
• chain { chain {} } doesn't work

Add support for `discard_empty`

One of the options available in mutation gem for string is to define it as discard_empty: true. But this option is not available with dry-mutations...

prepend ⇒ revel

Silently add revel DSL to original ::Mutations::Command and/or prevent prepending ::Dry::Mutation::Command to any class.

Make a generic prepend for DSL only and reject including/prepending Command to anything save for Command since it hardly relies on the base structure.

gemspec problem makes boilerplate files globally executable

The bin directory only contains common boilerplate files. The gemspec file those common boilerplate files in the bin directory globally executable. Delete the line in the gemspec that makes everything in the bin directory globally executable.

schema(Dry::Validation.Form) does not expose inputs

When using schema with a Dry::Validation.Form schema, then inputs is empty.

Error running specs when `true` is replaced with `"true"`

In line
https://github.com/am-kantox/dry-mutations/blob/master/spec/dry/mutations/ulises_spec.rb#L77 I replaced true with "true" and got this error:

Failures:

  1) Dry::Mutations::Extensions::Command Ulises’ most tremendous mutation just works
     Failure/Error: memo[key] = new(key, msg.predicate, msg, message: msg.text, index: idx)

     NoMethodError:
       undefined method `predicate' for #<Dry::Validation::Message::Or:0x00000103553c10>
     # ./lib/dry/mutations/errors/error_atom.rb:24:in `block in patch_message_set'

Boolean are not coerced

In mutations, when a field is defined as boolean then 'true' and 'false' are gracefully coerced to true and false: https://github.com/cypriss/mutations/blob/master/lib/mutations/boolean_filter.rb#L27

But this is not the case in dry-mutations...