alrefai / jammming Goto Github PK

I like that your app removes the added song from the search results! If you're going to do this though, I'd recommend making sure the song goes back to the search results when you remove it from the playlist. Right now, when I remove the song it doesn't get returned

I love that you added some extra features to this! The removal of the playlist tracks from the search results, as well as the ability to search on enter, makes your app a lot more user friendly. There's a couple of minor bugs in the first new feature, like that the song is only returned to the search results when you delete the song from the playlist and perform another search. Also, when you perform another search, you can add duplicate songs to the playlist because you never actually check to make sure that the song doesn't exist in the playlist before adding it

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Really nice job on this project! Your app works great and your codebase is one of the more creative ones I've seen for this project. I love that you added extra features, like the ability to search on enter and the removal of the playlist tracks from the search results. The second feature has a couple of minor bugs, but it's still great that you included it. My biggest critique is that I didn't love how you separated components versus containers, but that could just be a personal preference. Overall, this was really creative and well done! Great job

There have been updates to the react monorepo:

• • The dependency react was updated from 16.6.1 to 16.6.2.

• The dependency react-dom was updated from 16.6.1 to 16.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

I see what you did by dividing up your app into containers and components, but for a small project like this I'd honestly recommend just combining them as usual into normal components. It's a little trickier to keep track of props and methods when you have so many files for just a few components, I think it would be easier to make mistakes like this

I'd encourage you to try and deploy your app! It's such a good experience to see something you made go live online. You can try using Surge, as suggested, or try my personal favorite Heroku: https://blog.heroku.com/deploying-react-with-zero-configuration