allsetpl / przelewy24bundle Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 3.0 19 KB

This is superb easy to use Przelewy24 Bundle with bulit-in Symfony Events.

Home Page: https://allset.pl

License: MIT License

PHP 99.96% Twig 0.04%

przelewy24bundle's People

Contributors

Stargazers

Watchers

Forkers

arturwwl twarnicki pavlaq

przelewy24bundle's Issues

Wrong p24_sign calculation in VerifyAdapter.php

Current use of VerifyAdapter generate error (from Przelewy24 API):

error=err00&errorMessage=Błąd wywołania (3) - błąd CRC

In file Adapter/VerifyAdapter.php field p24_sign should be calculated with value of p24_order_id instead of p24_merchant_id. In this file also Przelewy24 URL is hardcoded (to sandbox), it should depends on sandbox flag set or not in config.

invalid string comparation

przelewy24-bundle/Exception/Exception.php

public static function getExceptionsFromString($string, $type)
    {
        $array = \explode('&', $string);
        if ($array[0] == 'error=0' || $string = "") {
            return;
        }

        throw new \Exception($type . ': ' . $string);
    }

String in exception always will be empty. Should be

public static function getExceptionsFromString($string, $type)
    {
        $array = \explode('&', $string);
        if ($array[0] == 'error=0' || $string == "") {
            return;
        }

        throw new \Exception($type . ': ' . $string);
    }

Recommend Projects