alleyinteractive / wp-irving Goto Github PK

Since WP 5.4, a deprecation notice is being shown on taxonomy list tables when the tag_list_actions hook is in use. See: https://core.trac.wordpress.org/ticket/49808

In the mean time, we need to loop through all taxonomies and hook individually to {$taxonomy}_row_actions instead.

Allow devs to filter the namespace and the endpoint version.

Right now, there's no logic running on every admin page hit that validates the JWT token stored in the user's cookie is valid. We should check/validate this more frequently to ensure auth works as expected.

Have a homepage Irving API button on the dashboard for quick access to the endpoint. Just like a single post has a WP-Irving API button on the WP bar.

Singular taxonomy pages don't have the Irving API button at the moment.

The components endpoint has a lot of admin related code that can and should be moved into its' own class.

When setting up the WP_Query object in Components_Endpoint::build_query(), the is_home flag is not being set correctly because internally, when WP_Query::parse_query() sets those flags, it explicitly includes a condition that the current request is not a REST request.

Since we are always setting up the WP_Query object in the context of a REST request, this will always be false. Annoyingly, the is_home flag is also then used in the logic to set up several other flags, which are now unreliable as well.

Our two options are to either manually set the is_home flag using the same basic logic as WordPress on the parse_query action and then rerun parse_query_vars() to fix inconsistencies, or we need to fork all of the logic that relies on the is_home flag and fix them all manually.

Hello!

I'm seeing the following error when trying to run npm run dev:

Mon, 30 Mar 2020 15:46:02 GMT irving:redis [error] Couldn't get the host and port from the REDIS_MASTER environment variable. Please pass a valid REDIS_MASTER environment variable in the form of a host:port string
this error is preventing me from spinning up Irving locally. Any ideas what may be causing this?

Thanks!
Hughie

The bug fix in #131 uses WP core's list off query vars to allow-list.

Should that list be reduced at all?