The distical's discuss from allebb

allebb / distical Goto Github PK

View Code? Open in Web Editor NEW

A PHP library for calculating distance between two or more latitude/longitude coordinates.

License: MIT License

PHP 100.00%

distical's Issues

Exception “The distance must be greater than zero!” when providing same coords twice

Hello and thanks for the library.

I get an error when I try to calculate the distance between 2 points that have same coordinates.

I think it should check with !$distance >= 0 instead of !$distance > 0 here:

distical/src/Entities/Distance.php

Lines 57 to 59 in 892f9a1

    
           if (!$distance > 0) { 
        
               throw new \InvalidArgumentException('The distance must be greater than zero!'); 
        
           }

A distance of 0 is valid in my humble opinion.

One (untested) example:

$centralIpswich = new LatLong(51.73441738801072, 0.4632282257080078); // Central Ipswich co-ordinates!
$centralAylesbury = new LatLong(51.73441738801072, 0.4632282257080078); // Central Ipswich co-ordinates!

// Create a new instance of the class passing in two coordinates (LatLong objects)
$pointToPointCalculator = new Calculator($centralIpswich, $centralAylesbury);

// Calculate the distance and return in both kilometre and miles...
$km = $pointToPointCalculator->get()->asKilometres();

Recommend Projects