alkacon / alkacon-oamp

OAMP - the Alkacon OpenCms additional module packages.

OpenCms Add-On Modules Package(OAMP)#

###Provided by Alkacon Software###

##About OAMP##

---

The Alkacon OpenCms Add-On Module Package (also called OAMP) is a set of free, open source extension modules for OpenCms. Alkacon OAMP adds front-end related features to OpenCms that may be useful in case special functionalities are required.

The Alkacon OAMP modules are installed on a standard OpenCms system.

##Contributing to the OAMP modules development##

---

In case you consider contributing to the OAMP modules development by sending us pull requests, please download and read the OpenCms Contributor License Agreement (CLA).

The intention of the CLA is to clarify the legal status of your contribution(s). Basically, it says that you grant Alkacon Software GmbH full rights to use your contribution in the OpenCms distribution, without giving any warranties that it actually works.

Click here to download the OpenCms CLA (PDF, 70 kb).

In order to include your contribution in the OpenCms core distribution, we need a signed copy of the CLA from you. Please sign the CLA and fax it to:

Alkacon Software GmbH
Fax: [phone]

We regret that such legal stuff is required, however we believe it is better for all OpenCms users if legal issues are sorted out right from the beginning.

Should you have any questions regarding the CLA, please contact us.

##Contact##

---

Alkacon Software GmbH
An der Wachsfabrik 13
DE-50996 Cologne, Germany

http://www.alkacon.com
http://www.opencms.org

Please use our contact form to contact us directly.

alkacon-oamp's Issues

build-single.xml: Error building dependencies

The current build-single.xml script goes through the list of jar files in the ${module.input.lib} dir and builds an erroneous ${module.libs.path}:

${module.libs.path}:${module.input.lib}/@{archive}

• module.libs.path contains the concatenated path
• module.input.lib is the absolute path to the module input lib directory
• @{archive} is the absolute path to the jar file

Thus, every jar is build with the dir fragment duplicated. It does not work!

Alkacon formgenerator 2.0.1 - Type Select Box & param values

I have created a basic form with some Text input fields and some Selectbox fields.
My Selectbox field 'model' have as Default value a list of options with a default one:
var1*:Val 1|var2:Val 2

When I display my page with the form, and send to it no parameters, the field is displayed with the default value var1. Good.
But when I display my page with the parameter "model=var2" in ther URL, the field is also displayed with the default value var1!! It should be var2!

I found a solution in CmsForm, on function I_CmsField createInputField(
String xPath,
CmsXmlContent content,
CmsJspActionElement jsp,
Locale locale,
CmsMessages messages,
Map fieldTexts,
Map> subFieldPaths,
Map fileUploads,
String subFieldNameSuffix,
boolean initial,
boolean subField)
It's near line 2850. I do a first check with the selectedFormRequest, and use a flag to memore the selected option.

Newletter module bug report

I've a working newsletter module integration (OpenCMS 7.5.0 and Newsletter
1.0.2). When i create a mail to send to a group i use links and images in it.
When the mail is received in i.e. outlook i can press 'download images' to get
the imaged viewed in my inbox.

unfortunately the images are NOT loaded.

I checked the source of the email, and the URL is wrong to load the images
(OpenCMS did not translate):
/pathtoimage/image.gif
in
http://<WWW.WEBSITE.COM>/pathtoimage/image.gif

Besides the image problem, the links are also not translated. To finish this
bugreport, the color's and fonts in the text are also not correct in the Inbox
'view'.

Screenshots etc. can be delivered..

Thanks in advance

Web Form Report shows duplicate and empty columns

The first issue I have with the Web Form Report content type - packaged within
the Form Generator Module – is that it displays all columns even when they
contain no data.

Another issue also appears when you have multiple dependant fields that use the
same label names. This results in the creation of separate columns for each
field when it should really only be one.

This scenario might happen if for example you have a select box containing
countries, where you could then create separate dependant fields to contain the
cities for each country. This means you have one field labelled "Country" and
multiple dependant fields labelled "Cities" that will appear depending which
country has been chosen.

To get round this problem I have redeveloped the sections of code which is
responsible for collecting the columns in the CmsFormReport class. This section
lies between lines 518 and 535 in the CmsReportClass.java file.

The attached Patch file shows the changes I have made. In summary the new code
no longer uses the getAllFields method which retrieves all the fields
regardless of the data it may or may not contain. Instead I am using the same
collection method used by the column builder used to create the excel
spreadsheets and the backend database administrative form. This change alone
results in the collection of columns that only contain data.

The second improvement this change brings is that because it only retrieves the
columns that have been found in the database it prevents duplicate columns from
appearing.

The only downside to this approach is that the column tree structure has been
flattened. Sub fields and non sub fields are all listed alphabetically which
means a bit of work is then required to prevent sub fields from showing when
their parents have been filtered out.

After the patch file has been applied lines 533 and 548 will check to see if
the current field has sub fields and checks whether is has also been filtered
out. If this is true then a new list is created which adds all the subfields
that should also be removed from the columns list.

Once that has been done we confirm that the current field should be shown and
is not filtered out - either at its current or parent’s level.

Thanks

http://bugzilla.opencms.org/attachment.cgi?id=331&action=view
Patch to prevent empty and duplicate columns from appearing in webformreport

File not found in zipfile: system/modules/com.alkacon.opencms.v8.commons/lib/com.alkacon.opencms.v8.commons.jar

File not found in zipfile: system/modules/com.alkacon.opencms.v8.commons/lib/com.alkacon.opencms.v8.commons.jar

Broken build (branch_9_5_x): package org.opencms.ade.contenteditor.client.widgets does not exist

Log:

[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateSelectWidget.java:36: error: package org.opencms.ade.contenteditor.client.widgets does not exist
import org.opencms.ade.contenteditor.client.widgets.CmsSelectWidget;
                                                   ^
[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateSelectWidget.java:54: error: cannot find symbol
public class CmsSerialDateSelectWidget extends CmsSelectWidget {
                                               ^
  symbol: class CmsSelectWidget
2 errors

Formgenerator 2.0 on OpenCms 8.0.2 - filenames

I found an issue in Alkacon Formgenerator 2.0 on OpenCms 8.0.2.
I have a form with file fields, with can be submit from Internet Explorer 6.
IE6 set the value as a full path (C:..) with Windows separator "".
If OpenCms is installed on a server on Linux, le line 1911 in sendMail()
function :
String filename =
attachment.getName().substring(attachment.getName().lastIndexOf(File.sep
arator) + 1);
try to extract the filename with "/"...
So with IE6, the mail received contains attachment with the full path of user's
file!

In my project, I have overload Alkacon classes with a custom jsp, and put this
code:
int index_start_name = 0;
if(attachment.getName().lastIndexOf(File.separator)!=-1){
index_start_name =
attachment.getName().lastIndexOf(File.separator) + 1; }else
if(attachment.getName().lastIndexOf("/")!=-1){
index_start_name =
attachment.getName().lastIndexOf("/") + 1; }else
if(attachment.getName().lastIndexOf("")!=-1){
index_start_name =
attachment.getName().lastIndexOf("") + 1; } String filename =
attachment.getName().substring(index_start_name);

Calendar Module and OpenCms 8.5

In a standard OpenCms 8.5 I have installed the Calendar Module.

When I add a new Calendar view to a page, the "loading" icon keeps showing and the calendar does not show.

In 8.0.4 I didn't have this issue.

Kind regards,

Roel Frison

The Alkacon OAMP Comments Module feature configuration

Webform Module 2.0 and 2.0.1: Database error when using same field label two times

When the same label exists twice in one webform with DataTarget=Database, MySql throws a duplicate key exception:

ERROR [sFormDataAccess: 661] Could not store field "Last Name" with value "xyz" into database for submitted form:
Last Name abc
Last Name xyz
com.mysql.jdbc.exceptions.MySQLIntegrityConstraintViolationException: Duplicate entry '828-Last Name' for key 'PRIMARY'
...

Sending per Email works fine.

Tested with Webform Module 2.0. and 2.0.1

Broken build (branch_9_5_x): package com.alkacon.acacia.client.widgets does not exist

Apparently, the code has been refactored out.

Log:

[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateWidgetFactory.java:30: error: package com.alkacon.acacia.client.widgets does not exist
import com.alkacon.acacia.client.widgets.FormWidgetWrapper;
                                        ^
[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateWidgetFactory.java:31: error: package com.alkacon.acacia.client.widgets does not exist
import com.alkacon.acacia.client.widgets.I_EditWidget;
                                        ^
[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateWidgetFactory.java:32: error: package com.alkacon.acacia.client.widgets does not exist

Comment 2.0 - Configuration widget not working

I've installed this module in Opencms 9.0.1 and the configuration widget not working. The widget height is too low and the little black arrow is out of the component.

Bug in YUICompressor breaks media query declarations

A bug in YUICompressor v2.4.2 causes certain media query declarations to break due to incorrect removal of spaces.

For example, compressing this:

@media (min-width: 1px) and (max-width: 799px) {
}

Results in this:

@media(min-width:1px) and(max-width:799px){}

The removal of the required space after and in effect removes from the stylesheet all rules declared within that media query section. (The rules are not literally removed, but browsers will ignore them.)

The bug was fixed shortly after the release of v2.4.2 in September 2010.

Suggest updating to the latest release version of YUICompressor (currently v2.4.8), available at https://github.com/yui/yuicompressor/releases

Note: The 2.4.2 version may or may not also include a bug where the required leading space before the !important modifier is incorrectly removed.

Broken build (branch_9_5_x): cannot find CmsGroup.setProjectCoWorker(boolean)

Error log:

[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.newsletter/src/com/alkacon/opencms/newsletter/admin/CmsEditMailinglistDialog.java:90: error: cannot find symbol
        m_group.setProjectCoWorker(false);
               ^
  symbol:   method setProjectCoWorker(boolean)
  location: variable m_group of type CmsGroup
[...]/alkacon-oamp-9.5.x/com.alkacon.opencms.newsletter/src/com/alkacon/opencms/newsletter/admin/CmsEditMailinglistDialog.java:91: error: cannot find symbol
        m_group.setProjectManager(false);
               ^
  symbol:   method setProjectManager(boolean)
  location: variable m_group of type CmsGroup

Broken com.alkacon.opencms.v8.calendar (branch_9_5_x)

Perhaps missing or buggy gwt build scripts?

Log excerpt:

:compileCom_alkacon_opencms_v8_calendar_gwtJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6
[...]/alkacon-oamp-9.5.x-tmp/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateWidgetFactory.java:41: error: CmsSerialDateWidgetFactory is not abstract and does not override abstract method createInlineWidget(String,Element) in I_CmsWidgetFactory
public class CmsSerialDateWidgetFactory extends A_NativeWidgetFactory {
       ^
[...]/alkacon-oamp-9.5.x-tmp/com.alkacon.opencms.v8.calendar/src/com/alkacon/opencms/v8/calendar/client/widget/CmsSerialDateWidgetFactory.java:54: error: createInlineWidget(String,Element) in CmsSerialDateWidgetFactory cannot implement createInlineWidget(String,Element) in I_CmsWidgetFactory
    public I_EditWidget createInlineWidget(String configuration, Element element) {
                        ^
  return type I_EditWidget is not compatible with I_CmsEditWidget

[...]

28 errors
:compileCom_alkacon_opencms_v8_calendar_gwtJava FAILED

FAILURE: Build failed with an exception.

Captch Webform Module 2.0.2 not working with Java 8

After updating to Java 8 captcha images of webforms are completely black.

Alkacon_OAMP_Calendar_2.0.0: last detail entry shown repeatedly

Hi,
I am using OpenCMS 9.0 with a/m widget. I encountered already alkacon/opencms-core#194 issue and updated to fullcalendar 1.6.4, which fixes this one. All was fine and I added multiple date entries. While offline they are shown properly, but when I switched to online, I see my latest date entry only, repeated in all other date entry instances. My html entries in .content/v8-cal-entry look fine. It seems that they are not properly selected/assembled in online mode. I am using MySql 5.6. Can anybody help please?

Error while importing module OAMP

When I am trying to import the module through import module from server, I am getting below error.

Error uploading the module alkacon-oamp-branch_9_0_x.zip.
Manifest file missing in module C:\apache-tomcat-7.0.62\webapps\opencms\WEB-INF\packages\modules\alkacon-oamp-branch_9_0_x.zip.

Please help if anyone have idea?

Outdated dependency in build.xml

I must obviously be missing something here. The build.xml refers to ant-opencms-1.1.jar, but the current opencms-core is being packaged with "ant-opencms-1.2.jar" (https://github.com/alkacon/opencms-core/blob/master/lib/compile/ant-opencms-1.2.jar) since at least 9 months ago!:

mMoossen 9 months ago removed core dependencies in ant-opencms-1.2.jar.

Current build.xml doesn't compile and fails with:

[...]/src/opencms-alkacon/alkacon-oamp/build.xml:63: Problem: failed to create task or type selectionprompt
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any / declarations have taken place.

Is anyone using this build-script?

uncorrelated constant RESOURCE_TYPE_CSS

Hi,
When downloading the "Alkacon OAMP WebOpt Module 2.0.0" from http://www.alkacon.com/en/modules/downloads/oamp-webopt-2.0.0.html and importing it to my OpenCms - it registers the CSS structured content (like the CSS optimization type) with id 283

While the internal jar contains the class CmsOptimizationCss.java with the constant:
protected static final int RESOURCE_TYPE_CSS = 763;

I ended up downloading from github, generating the jar and zipping the resources folder and importing that.

Thanks

build-single.xml: outdated dependencies for opencms tasks

ant-opencms-1.1.jar is outdated. Current ant-opencms-1.2.jar pulls dependencies from commons-digester-1.8.jar, commons-collections-3.2.1.jar, commons-logging-1.1.1.jar, commons-beanutils-1.8.0.jar. The taskdef:

<taskdef resource="org/opencms/util/ant/taskdefs.properties" loaderref="opencms">...</taskdef>

should be fixed accordingly.

Webform Module 2.0 : Wrong upload folder for forms with multiple filesupload fields

In a webfrom with DataTarget=Database and multiple fileupload fields, only the first file will be uploaded to the folder according to the FormId stated in DataTarget-Block. The following files end up directly in /shared/webform/
This is the behavior for the very first form submit.

For all following submits (when the FormId folder exists), all form files are uploaded directly to /shared/webform/

Tested with Webform Module 2.0

Alkacon OAMP SyndicationFeed Module Version 2.0.0

don't work with opencms 9.5.2.
return an error when I try to configure mapping in to xsd schema.

---

Reason: XML validation error :

cvc-complex-type.2.4.a: Invalid content was found starting with element 'visibilities'. One of '{handler, resourcebundle, preview, defaults, mappings, layouts, validationrules, searchsettings, relations, modelfolder, feedrules}' is expected.

.

Path traversal bug in <Path /> parsing for Web Optimization

Recently we blew up our authoring environment because of a fun (what I perceive to be) bug.

Here's the steps to reproduce:
Create a new css/js alkacon-optiomized-css/js recource.
Make sure it has one Path element, and make sure it's empty (that's the default ).
Publish it, switch to the Online project.
Now, render the minified resource.

This defaults to recursively traversing the path from the site root if it's a folder (which it is, because the site root is always a folder).
Why? Because resolves to "", which then resolves to "/sites/[project default]/.

This takes forever and occupies about (at least) 180Mb of heap space for a long time (at least the duration of the call, plus caches etc) [in a system with hundreds of thousands of resources].
Multiple calls results in the same memory occupation (since the previous call is still running, caches aren't used). So, for a 32-bit JVM, after 8 hits the heap is exhausted and the system fails completely (OutOfMemoryExceptions and GCOverhead errors).

Solution
Stop this at the gate. as soon as includeDefault is called on the OptimizationBean, check "path" for an empty string. If it's empty, disallow/ignore it. An empty node is most possible a bug or at least unintentional.

Webform branch_9_5_x: %(row) macro to display checkboxes and radiobuttons in one row isn't working any more.

Looks like CmsMacroResolver cuts "%(row)" so showInRow = true; never will be reached:

CmsMacroResolver resolver = CmsMacroResolver.newInstance().setCmsObject(cms).setJspPageContext(jsp.getJspContext());
fieldValue = resolver.resolveMacros(fieldValue);
// get items from String
boolean showInRow = false;
if (fieldValue.startsWith(MACRO_SHOW_ITEMS_IN_ROW)) {
   showInRow = true;
   fieldValue = fieldValue.substring(MACRO_SHOW_ITEMS_IN_ROW.length());
}

(CmsForm.java#L3245)

build-single.xml: Wrong defaults for "app.name"

<property name="app.name" location="opencms" />

stores in ${app.name} the absolute path to ${opencms} (see http://ant.apache.org/manual/Tasks/property.html) but it is incorrectly used in tomcat.copy task:

<copy todir="${tomcat.home}/webapps/${app.name}/WEB-INF/lib">

It doesn't make sense, and it fails in fact.

Broken build (branch_9_0_x and branch_9_5_x)

If I build against opencms_version from ms_9_4_7 or branch_9_5_x (neither opencms-core tag build_9_0_1 nor branch branch_9_0_x do build), I get the error CmsConfigurableCollector is not abstract ...:

Against 9.4.7:

[...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java:1019: error: incompatible types: Object cannot be converted to Entry<String,String[]>
            for (Map.Entry<String, String[]> entry : CmsRequestUtil.createParameterMap(req.getParameterMap()).entrySet()) {
                                                                                                                      ^
Note: [...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Against 9.5.x:

[...]/alkacon-oamp/com.alkacon.opencms.commons/src/com/alkacon/opencms/commons/CmsConfigurableCollector.java:70: error: CmsConfigurableCollector is not abstract and does not override abstract method getResults(CmsObject,String,String,int) in I_CmsResourceCollector
public class CmsConfigurableCollector extends A_CmsResourceCollector {
       ^
1 error
10 warnings