algoworldnft / algoworld-contracts Goto Github PK
View Code? Open in Web Editor NEW๐ค A collection of Algorand Smart Signatures and Contracts for swaps and trading ๐ด
License: MIT License
๐ค A collection of Algorand Smart Signatures and Contracts for swaps and trading ๐ด
License: MIT License
This is not a critical check, but should the contract enforce also that:
Gtxn[INCENTIVE_FEE].sender() == Gtxn[REQUESTED_ASA_XFER].sender()
Otherwise any account could potentially pay for the incentive fee (which is not dangerous for swapper users).
Stateless ASC1 smart contracts are now called Smart Signatures. Might want to update readme.
push
aciton) to master branch, package version is updated following semver
conventions before package is published to pypi. Additionally final step in the pipeline should make a new github pre-release automatically as well as setting the tag equal to package version that was just published.An issue will be closed after enhancement is implemented reviewed and merged to main
branch.
The flow doesn't have to be fully automated, if there is a better, popular pattern for pypi releases for packages on github (that rely on github actions), please describe it in detail before implementation.
The goal is to decouple the funding logic from the logic that performs the main save operation (of ipfs note in pay transaction field issued by escrow).
Original suggestion by @cusma - #47 (comment)
After decoupling, a change on algoworld swapper needs to follow to implement a little dialog popup that will appear on wallet's who are making first ever login to algoworld swapper. The popup should take care of initial funding transaction (can be later used to present Terms and Conditions checkbox as well)
The goal is to follow up and address comments mentioned in the following PR -> AlgoWorldNFT/algoworld-swapper#18
Swapper contract can fit up to 5 ASAs with PR 18 merged, but can be trimmed down even further and total ASAs per swap can increase to a higher value (~6-10 ASAs).
I think the sandbox should be run in dev
mode to speed up the PR testing process:
Issue
Since the ASA-to-ASA swap requires the offered ASA to be deposited in the Swapper Contract, there is a limitation for those users willing to concurrently swap a card for different possible requested cards.
Example
Let's say a user offers card A
accepting either cards B
, C
or D
as possible requested ASA. Since user has just 1 card A
is not possible to open multiple requests for card B
, C
or D
at the same time, since the user can only deposit A
in one Swapper Contract at time.
Proposal
Adding an Or
condition on requested ASA, so that the Swapper Contract could approve concurrent swaps with B
, C
or D
at the same time, in the same Swapper Contract.
The goal is to replace the redundant pytest-cov
package with coverage
.
Additionally, the pipeline should be updated to inlcude codecov reporting stage.
The default incentive amount should be 10000
. I suggest to import and use 'INCENTIVE_FEE' directly from here: https://github.com/AlgoWorldNFT/algoworld-swapper/blob/888b0024445b1c6b02b9406947ada5e236d21bc1/src/algoworldswapper.py#L19
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
abatilo/actions-poetry
, styfle/cancel-workflow-action
).github/workflows/ci.yaml
styfle/cancel-workflow-action 0.11.0
actions/checkout v3
actions/setup-python v4
abatilo/actions-poetry v2.3.0
codecov/codecov-action v3
.github/workflows/codeql-analysis.yml
actions/checkout v3
github/codeql-action v2
github/codeql-action v2
github/codeql-action v2
.github/workflows/release.yaml
actions/checkout v3
actions/setup-python v4
abatilo/actions-poetry v2.3.0
CasperWA/push-protected v2
pyproject.toml
pyproject.toml
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.