This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (abatilo/actions-poetry, styfle/cancel-workflow-action)
• chore(deps): update abatilo/actions-poetry action to v3
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-python action to v5
• chore(deps): update codecov/codecov-action action to v4
• chore(deps): update github/codeql-action action to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I think the sandbox should be run in dev mode to speed up the PR testing process:

https://github.com/AlgoWorldNFT/algoworld-swapper/blob/0323a1a8e12a21b05260282bae1517e8cb9baa6b/.github/workflows/awe-swapper-build-test.yaml#L36

Goal

1. Propose a mechanism to automatically increase algoworld-contracts version on merge to the repository.
2. Discuss mechanism in github issue, upon agreement proceed to next step.
3. Implement the solution, refine github ci yaml so that on each merge (push aciton) to master branch, package version is updated following semver conventions before package is published to pypi. Additionally final step in the pipeline should make a new github pre-release automatically as well as setting the tag equal to package version that was just published.
4. Open PR against main branch, complete pr review.

An issue will be closed after enhancement is implemented reviewed and merged to main branch.

Further notes

The flow doesn't have to be fully automated, if there is a better, popular pattern for pypi releases for packages on github (that rely on github actions), please describe it in detail before implementation.

The goal is to follow up and address comments mentioned in the following PR -> AlgoWorldNFT/algoworld-swapper#18

Swapper contract can fit up to 5 ASAs with PR 18 merged, but can be trimmed down even further and total ASAs per swap can increase to a higher value (~6-10 ASAs).

Stateless ASC1 smart contracts are now called Smart Signatures. Might want to update readme.

The goal is to replace the redundant pytest-cov package with coverage.

Additionally, the pipeline should be updated to inlcude codecov reporting stage.

https://github.com/AlgoWorldNFT/algoworld-swapper/blob/888b0024445b1c6b02b9406947ada5e236d21bc1/tests/utils/utils.py#L418

The default incentive amount should be 10000. I suggest to import and use 'INCENTIVE_FEE' directly from here: https://github.com/AlgoWorldNFT/algoworld-swapper/blob/888b0024445b1c6b02b9406947ada5e236d21bc1/src/algoworldswapper.py#L19

Issue
Since the ASA-to-ASA swap requires the offered ASA to be deposited in the Swapper Contract, there is a limitation for those users willing to concurrently swap a card for different possible requested cards.

Example
Let's say a user offers card A accepting either cards B, C or D as possible requested ASA. Since user has just 1 card A is not possible to open multiple requests for card B, C or D at the same time, since the user can only deposit A in one Swapper Contract at time.

Proposal
Adding an Or condition on requested ASA, so that the Swapper Contract could approve concurrent swaps with B, C or D at the same time, in the same Swapper Contract.

https://github.com/AlgoWorldNFT/algoworld-swapper/blob/705d1d2c7fb554e1723711b0ed09b664ad74ffa0/src/algoworldswapper.py#L124

This is not a critical check, but should the contract enforce also that:

Gtxn[INCENTIVE_FEE].sender() == Gtxn[REQUESTED_ASA_XFER].sender()

Otherwise any account could potentially pay for the incentive fee (which is not dangerous for swapper users).

The goal is to decouple the funding logic from the logic that performs the main save operation (of ipfs note in pay transaction field issued by escrow).

Original suggestion by @cusma - #47 (comment)

After decoupling, a change on algoworld swapper needs to follow to implement a little dialog popup that will appear on wallet's who are making first ever login to algoworld swapper. The popup should take care of initial funding transaction (can be later used to present Terms and Conditions checkbox as well)