alfredoramos / phpbb-ext-markdown Goto Github PK

Bug reported via email.

It gives the following error:

Catchable fatal error: Argument 1 passed to phpbb\help\controller\controller::__construct() must be an instance of phpbb\controller\helper, none given in /srv/http/forum/phpbb/help/controller/controller.php on line 49

I no longer see the benefit of it, and it increases the assets (CSS/JS) included in template.

Even If the global option in the ACP disables the use of Markdown, the posting option to disable Markdown is shown, however they do nothing since Markdown is already disabled.

It's just a template bug.

Currently affects:

• Post settings (Allow Markdown in posts)
• Private message settings (Allow Markdown in private messages)

Signature settings (Allow Markdown in user signatures) are not affected by this bug.

Original report:

• https://www.phpbb.com/customise/db/extension/markdown/support/topic/206381?p=733246#p733246

To avoid regressions like #3

The pull request #22 introduced a regression which removes styling for paragraphs in content (post, signature, private messages).

It will be harder to maintain the CSS code without adding a custom CSS class, even using SCSS to generate those stylesheets.

It needs the following template event that is only available since phpBB 3.2.6-RC1:

ucp_profile_signature_posting_editor_options_prepend

Block and inline spoilers were added in s9e/TextFormatter v2.1.0

phpBB 3.3.0 comes with version 2.3.1

References:

• https://github.com/s9e/TextFormatter/releases/tag/2.1.0
• https://s9etextformatter.readthedocs.io/Internals/Changes/

One more minor issue: when the markdown extension is enabled, editing forum description (via ACP panel, forums tab) results in the description being wrapped in <p> tags, which adds a 1.5 bottom margin to the description text on the forum index page (as per the default styles).

Reference:

• https://www.phpbb.com/customise/db/extension/markdown/support/topic/211571?p=765666#p765666

phpBB has a built-in feature that adds indentation when pressing the tab key inside [code] BBCode.

Something similar would be useful for code blocks.

As discovered in https://www.phpbb.com/customise/db/extension/markdown/support/topic/206381,
createParagraphs rule is needed when rendering markdown.

But currently is is applied to any post, even with [x] Disable markdown switch, and even when markdown is not enabled in ACP Board features.

It should had been included in #43

When I make post with option "[x] Disable Markdown", and then try to edit it - I see that option value is cleared.

If I then press "Submit" (without any change) - I see markdown get parsed.

I tried #34, but this bug still there.

The pull request #39 introduced a new bug that makes the posting option "Disable Markdown" to be checked by default in new topics.

Hi, purging extension takes literally hours on my large forum, is it really required? I can see thousands of SQL updates per second.

use markdown input the photo,like this
![img description](img address)

but in postshow dose not have tittle or alt details.only have image description

how can I modify it to achieve the img tittle or alt

thanks

Hi,

First of all, thank you for this great extension!

I started to use it on my Forum and noticed that sometimes the new post are not formatted. I need to purge the cache to make it work again.

It seems Markdown is enabled:

Do you have any idea?

We want to enable Markdown extension on our board, to make some experiments, but we are not sure that we will keep it after.

Unfortunately with this extension enabled every new (or edited) post get additional <p> wrapping.

This has no visual impact while the extension enabled.
But if we disable it - it's css removed, and posts text gets too large.

Worse of all - every post affected, even with disabled markdown option (#36)

Not sure if this causes any actually-existing bug, but I noticed this while grepping for something unrelated in my phpBB install:

$event['mode' !== 'post'], and therefore the entire condition, is presumably always going to be falsy, because it evaluates to $event[true], which presumably doesn't exist.

Should be $event['mode'] !== 'post' instead.

Issue reported in the phpBB development topic.

Currently the permissions are set for the Registered users group, which also applies for administrators.

Separate permissions should be defined for Moderators and Administrators to avoid this issue on boards with custom groups.

phpBB Markdown Version: dev (6715a8298c28f00de9600234dc660fcee0059d9a)

Tables as documented don't seem to work.

| Left | Center | Right |
|:-----|:------:|------:|
|   x  |    x   |   x   |

results in:

LeftCenterRightxxx

Tried with BBCode enabled and disabled.

Like BBCode has a row above input box for styling, replace that with Markdown styling in some way.

PHP version: 7.2.19
phpBB version: 3.2.7
Markdown version: 1.0.0

As soon as I enabled the Markdown plugin and update or create any post, that post gets enlarged font, as seen on the image below.

Left updated post with extension enabled, right old post.

Even if you are not going to support such setup in your extension - someone might want to write separate extension for PipeTables.

Then I wonder if line 208 would prevent those hypothetical extension to function (also line 270, etc):

Just a request, if possible for markdown support in phpBB (great extension by the way.)

Can we have support for checkboxes?

- [x] done
- [ ] todo