alfredoramos / phpbb-ext-imgur

Imgur extension for phpBB

About

Imgur extension for phpBB.

With this extension you can click on the Imgur posting button and select the image(s) you want to upload.

If the upload is successful it will add the image in the topic, private message or signature content. You can choose in the Administration Control Panel to show the uploaded image as plan text or with BBCode as URL, image (default) or thumbnail.

Features

• Change Imgur API data through ACP
• Optionally, set an album where all the images will be uploaded to.
• Compatibility with Advanced BBCode Box extension
• CSRF protection
• Administrator log on configuration changes
• Insert BBCode/text at cursor position
• Album download link in the ACP for backup
• Upload progress bar
• Compatibility with QuickReply Reloaded extension
• Compatibility with mChat extension
• Drop-down menu in posting box button
• Imgur tab in posting box options
• Drag and drop upload in Imgur tab
• Save some user preferences using localStorage and sessionStorage
• ACP settings to enable/disable output types

Requirements

• PHP 7.1.3 or greater
• phpBB 3.3 or greater
• Composer (for development only)
• Imgur API data (client_id and client_secret)

Support

• Download page
• FAQ
• Support area
• GitHub issues
• Crowdin translations

Donate

If you like or found my work useful and want to show some appreciation, you can consider supporting its development by giving a donation.

Installation

• Download the latest release
• Decompress the *.zip or *.tar.gz file
• Copy the files and directories inside {PHPBB_ROOT}/ext/alfredoramos/imgur/
• Run composer install --prefer-dist --no-dev inside {PHPBB_ROOT}/ext/alfredoramos/imgur/
• Go to your Administration Control Panel > Customize > Manage extensions
• Click on Enable and confirm

Preview

(Click to view in full size)

Imgur API

• Create an Imgur account, if you don't have one already
• Register your application at https://api.imgur.com/oauth2/addclient
• Type an application name
• Select OAuth 2 authorization with a callback URL
• Set Authorization callback URL to http://domain.tld/app.php/imgur/authorize, use https:// if you have an SSL certificate
• Verify that the previous URL works
• Type your email and a short description
• After clicking Submit you should get a client_id and client_secret

Configuration

• Go to your Administration Control Panel > Extensions > Imgur settings
• Set the Client ID, Client Secret and optionally an Album
• Click on Submit
• Once you have the required API data, click on the authorization link shown above
• A new window will popup to authorize the application
• Login to your Imgur account and grant access
• The window will close itself when it's done, or show an error message

To customize the look and feel:

• Move into {PHPBB_ROOT}/ext/alfredoramos/imgur/
• Copy the styles/prosilver/ directory to styles/{STYLE}/
• Edit the file styles/{STYLE}/theme/css/imgur.css as needed

Note: If your style doesn't inherit from prosilver, you should follow the steps above even if you don't want to change any file.

Uninstallation

• Go to your Administration Control Panel > Customize > Manage extensions
• Click on Disable and confirm
• Go back to Manage extensions > Imgur > Delete data and confirm

Upgrade

• Go to your Administration Control Panel > Customize > Manage extensions
• Click on Disable and confirm
• Delete all the files inside {PHPBB_ROOT}/ext/alfredoramos/imgur/
• Download the new version
• Upload the new files inside {PHPBB_ROOT}/ext/alfredoramos/imgur/
• Enable the extension again

phpbb-ext-imgur's Issues

Upload tab showing when API data (access and refresh token) is empty

It gets the token stored in memory from the Imgur client instead of getting from database.

Session storage could be smaller

Currently it stores a flattened array, which could save some bytes by storing an object instead.

It doesn't check image type before uploading starts

It should add a preliminary check for MIME types before images are uploaded.

It would also avoid wasting time on a file that will be rejected by the API anyways.

Doesn't load pictures after updating extension 1.3.1 to 1.6.0

Doesn't load pictures after updating extension 1.3.1 to 1.6.0

Error 500.
phpBB 3.3.1
Php 7.3.20
In logs:

[31-Aug-2020 16:13:11 Europe/Moscow] PHP Fatal error:  Uncaught Error: Call to undefined function GuzzleHttp\_idn_uri_convert() in /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/guzzlehttp/guzzle/src/Client.php:220
Stack trace:
#0 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/guzzlehttp/guzzle/src/Client.php(155): GuzzleHttp\Client->buildUri(Object(GuzzleHttp\Psr7\Uri), Array)
#1 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/guzzlehttp/guzzle/src/Client.php(183): GuzzleHttp\Client->requestAsync('POST', 'image', Array)
#2 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/j0k3r/php-imgur-api-client/lib/Imgur/HttpClient/HttpClient.php(115): GuzzleHttp\Client->request('POST', 'image', Array)
#3 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/j0k3r/php-imgur-api-client/lib/Imgur/HttpClient/HttpClient.php(85): Imgur\HttpClient\HttpClient->performRequest('image', Array, 'POST')
#4 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/j0k3r/php-imgur-api-client/lib/Imgur/Api/AbstractApi.php(64): Imgur\HttpClient\HttpClient->post('image', Array)
#5 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/j0k3r/php-imgur-api-client/lib/Imgur/Api/Image.php(55): Imgur\Api\AbstractApi->post('image', Array)
#6 /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/controller/imgur.php(282): Imgur\Api\Image->upload(Array)
#7 /home/n/nosipova/magicclover.ru/public_html/vendor/symfony/http-kernel/HttpKernel.php(151): alfredoramos\imgur\controller\imgur->upload('17477383')
#8 /home/n/nosipova/magicclover.ru/public_html/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(phpbb\symfony_request), 1)
#9 /home/n/nosipova/magicclover.ru/public_html/app.php(35): Symfony\Component\HttpKernel\HttpKernel->handle(Object(phpbb\symfony_request))
#10 {main}
  thrown in /home/n/nosipova/magicclover.ru/public_html/ext/alfredoramos/imgur/vendor/guzzlehttp/guzzle/src/Client.php on line 220

Output fields are not being resized correctly

There's a small bug that prevents phpbb.resizeTextArea() being executed the first time.

It was introduced in #60

Output fields are filled without checking if they are allowed

Currently it only checks if the field exists, however it does not verify it the output type is allowed.

Issues with phpBB 3.3.3+

phpBB 3.3.3+ added compatibility with Composer 2, however it also introduced issues with extensions that require external composer packages:

Fatal error: Uncaught OutOfBoundsException: Package "ocramius/proxy-manager" is not installed in [path]\phpbb\phpBB\ext\alfredoramos\imgur\vendor\composer\InstalledVersions.php:191

https://www.phpbb.com/community/viewtopic.php?p=15652146#p15652146

Drag and drop upload

It would be easier for some people to just drag and drop images, just like attachments.

Settings problem with last master

Hi,

I downloaded this morning the last master to test thumbail and to do the french translation.

On my test forum, i have error when i go to the extension settings ? normal as you are currently working on it ?

here the message :

Fatal error: Class 'Imgur\Client' not found in C:\Program Files (x86)\EasyPHP-Devserver-17\eds-www\dowfr\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php on line 435

I have of course clean cache before.

Thanks

Version 1.5.0-dev has some issues on IE11

It throws the following warning:

Object doesn't support property or method 'forEach'

phpbb-ext-imgur/styles/all/theme/js/imgur.js

Line 71 in ddeb4b3

imgurButton.forEach(function(item) {

New release

Hello,

I don't know if this is the right place to ask this kind of question, but here it goes. Do you plan to do a new release? I've seen that you made new changes to include a progress bar for the upload process, but such a change is not included in the latest release.

Thanks.

Fatal error: Uncaught Error: Class 'Imgur\Client' not found

Hi @AlfredoRamos,

on local environment I tried to test my last FRENCH translation on your last snapshot from GitHub (v1.3.1-dev) and I get two errors:

Fatal error: Uncaught Error: Class 'Imgur\Client' not found in C:\UwAmp\www\quickinstall\boards\phpbb328fr\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php:369
Stack trace: #0
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\Container.php(295): phpbb_cache_container->getAlfredoramos_Imgur_J0k3r_Imgur_ClientService() #1
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(446): Symfony\Component\DependencyInjection\Container->get('alfredoramos.im...', 2) #2
C:\UwAmp\www\quickinstall\boards\phpbb328fr\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php(339): Symfony\Component\DependencyInjection\ContainerBuilder->get('alfredoramos.im...') #3 
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\Container.php(295): phpbb_cache_container->getAlfredoramos_Imgur_Acp_ControllerService() #4 
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(446): Symf in C:\UwAmp\www\quickinstall\boards\phpbb328fr\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php on line 369

And this error just after purged the cache:

Fatal error: Uncaught ReflectionException: Class Imgur\Client does not exist in C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php:931 Stack trace: #0
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(931): ReflectionClass->__construct('Imgur\\Client') #1 
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(467): Symfony\Component\DependencyInjection\ContainerBuilder->createService(Object(Symfony\Component\DependencyInjection\Definition), Object(SplObjectStorage), 'alfredoramos.im...') #2 
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(995): Symfony\Component\DependencyInjection\ContainerBuilder->get('alfredoramos.im...', 1) #3 
C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php(992): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices(Object(Symfony\Com in C:\UwAmp\www\quickinstall\boards\phpbb328fr\vendor\symfony\dependency-injection\ContainerBuilder.php on line 931

Could you take a lool, please?

Regards.

It only adds one image in the output fields

When multiple files are uploaded at once, only one of them is added in the output field list, in the full editor.

This bug was introduced in #50

The input file is shown in mChat when guests can see the chat

hello, does anyone know how to desabled this when the members are not connected? with mChat. Please.

here : https://i.imgur.com/ERi8rWf.png

Reported at phpBB.com:

https://www.phpbb.com/customise/db/extension/imgur/support/topic/198266?p=741791#p741791

Upgrading from 1.5.1 to 1.6/1.7

Hello,
Firstly thank you so much for this great ext.
It works fine in my phpBB 3.3.2 system with 1.5.1.
I've try to update to a newer version but found difficulties:
Run composer install --prefer-dist --no-dev inside {PHPBB_ROOT}/ext/alfredoramos/imgur/
After a research, I understand that this step can be apply only by the host.
Is that mean that I cannot upgrade to the new versions without having composer?
(just to make it clear - when I upgraded I got a blank screen while trying to get to the ext settings on both versions 1.6, 1.7 and caches weren't the issue).

Verify album ID

Adding an album ID verification could reduce reported issues about problems when uploading where the album ID is invalid.

The Imgur API exposes the following endpoint that can be used to get all the albums IDs and then check if it contains the one entered by the administrator in the PCA:

GET Album IDs (Un-Authed / Authed)

https://api.imgur.com/3/account/{{username}}/albums/ids/{{page}}

https://apidocs.imgur.com/?version=latest#c13fe966-0f8f-425d-9247-298e302e1bc0

Field filters make album ID required in ACP controller

Reported originally in the phpBB Imgur extension support seccion:

https://www.phpbb.com/customise/db/extension/imgur/support/topic/202596?p=682771#p682771

Error message

I recently used topic locked with Move Topics When Locked.
Now I get this below error message every day
What can I do to solve this?

Een algemene fout is opgetreden: General Error
» SQL ERROR [ mysqli ]

[0]

SQL

No values specified for SQL IN comparison

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 996
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 547
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 441
CALL: phpbb\db\driver\driver->sql_in_set()

FILE: [ROOT]/ext/alfredoramos/autolocktopics/includes/helper.php
LINE: 241
CALL: phpbb\db\driver\factory->sql_in_set()

FILE: [ROOT]/ext/alfredoramos/autolocktopics/includes/helper.php

LINE: 131
CALL: alfredoramos\autolocktopics\includes\helper->lock_topics()

FILE: [ROOT]/ext/alfredoramos/autolocktopics/cron/task/auto_lock_topics.php
LINE: 52
CALL: alfredoramos\autolocktopics\includes\helper->auto_lock()

FILE: (not given by php)
LINE: (not given by php)
CALL: alfredoramos\autolocktopics\cron\task\auto_lock_topics->run()

FILE: [ROOT]/phpbb/cron/task/wrapper.php
LINE: 104
CALL: call_user_func_array()

FILE: [ROOT]/cron.php
LINE: 78
CALL: phpbb\cron\task\wrapper->__call()

ACP settings to show/hide certain output options

Reported vía phpbb-es.com

Fix handling of HTTP status codes from server

I started getting this error when uploading images.

Unexpected token < in JSON at position 0

To be more clear, the server was returning: 413 - Request Entity Too Large.
By default nginx is configured to allow a maximum client request body size of 1 MB, so this error would appear whenever I uploaded a larger image.

Reference:

• https://www.phpbb.com/customise/db/extension/imgur/support/topic/216956

Image size validation shows a lot of numbers after the decimal point

[...] just one small issue, when I try to upload a file larger than 10 mb, the error message shows the file size with a lot of numbers after the decimal point [...]

Reported via email.

Video upload

Imgur allows to upload short videos through the API, so it could be added to this extension.

POST Image Upload

https://apidocs.imgur.com/?version=latest#c85c9dfc-7487-4de2-9ecd-66f727cf3139

Add server-side image validation

It would further improve the security of the extension and also reduce API calls when the image does not met the file size and MIME type requirements.

Image upload from URL

Imgur allows to upload images from URL through the API, so it could be added to this extension.

POST Image Upload

https://apidocs.imgur.com/?version=latest#c85c9dfc-7487-4de2-9ecd-66f727cf3139

FormData polyfill is not always loaded from current CDN

I will need to replace the current CDN as sometimes it throws the following warning in the console:

Loading failed for the <script> with source “https://rawcdn.githack.com/jimmywarting/FormData/3.0.19/formdata.min.js”.

It fires change event more than necessary on output fields

Currently it fires the change event on every item of a flattened array, which could lead to poor performance when uploading multiple images at once, since the array could be big.

Upload controller does not check if user is logged in

Currently the button and file input is only added to the template if the user is logged in, so unless the user modifies the template files, there's no way a guest or bot can upload images, however that's not verified server side.

Can't upload WebP images

Upload webp image get following error:

Request to: /3/image failed with: "File type invalid (1)"

version: 1.7.2
sample image: https://down.sky-and-poem.fun/source/static/Colors%20of%20our%20Spring.webp

French Translation

Hi,

here french translation for last github master download (22/11/2017) for your next release.

Thanks

fr.zip

cURL error 60: SSL certificate problem

Good morning, I have problem, when I want enter my app PIN I have this message :
"Request for access token failed: cURL error 60: SSL certificate problem, verify that the CA cert is OK. Details: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)"

How can I fix this?
Thank you for your support

It generates invalid URLs when routes have additional arguments

The hash parameter is hard-coded to be at the end of the URL, however that URI can have additional parameters, and the hash will be ignored.

app.php/imgur/upload?{arg}={value}/{hash}

Reported via PM.

Images are not being uploaded to the specified album.

Just find out that 1.7.1 does not use the provided and validated album ID. It just uploads to non-album space in imgur.

Reported in the support area:

• https://www.phpbb.com/customise/db/extension/imgur/support/topic/198266?p=821136#p821136

This bug comes from j0k3r/php-imgur-api-client#37

It should load assets only when needed

Currently it loads CSS and JS files when enabled, however they're only used when the user is logged in since the posting buttons are not shown in any other case.