alexforster / sisqo Goto Github PK

@todo try actually running the example

• connect() is now authenticate() in v2.x
• SSH() constructor takes (username, host), not (host, username)

I just encountered a piece of gear that prompts interactively like so–

[alexforster-mbp:~]$ ssh user@switch
#
#Password:

My guess is that the issue is at ssh.py#L288-L294

Need repr(value) here:

When going through multiple jumpboxes (rare, I know), it's possible to be prompted twice for a passphrase or password. Right now, the default promptCallback will never try the same credential twice in succession, instead considering that an indication of failure and bailing out. Since ssh does not distinguish between a successful or unsuccessful response to Password: or Enter passphrase for key: without turning up verbosity, let's relax this and allow the default promptCalback to try the same credential successively, say, three times? Arbitrary, but should cover almost all imaginable out-of-box usecases.

Bump this to 10

In SSH.py the line

  self._proxyCommand = str(proxyCommand)

will result in the string 'None' being stored in the _proxyCommand variable when the default parameter is used. This causes this line

   self._proxySocket = paramiko.ProxyCommand(proxyCommand) if proxyCommand else None

in the __ enter __ method to fail with the error 'OSError: [Errno 2] No such file or directory'. Here proxyCommand is not None, but actually contains the string 'None'.

At ssh.py#L409 the re.match call should be changed to re.findall. This code was duplicated logic from ssh.py#L265, but at L265 we're working specifically with the last line of output, not (potentially) multiple lines of output like we are at L409.

Should be pretty easy to port our code to Python 3.

ptyprocess is PY3 compatible.

If pyte+wcwidth aren't PY3 compatible, then we're gonna' have a bad time – they do a lot of heavy lifting.