alexewerlof / combine-json Goto Github PK

This bug affects all previous versions of combine-json.

If a folder has the following structure:

/parent
  child.json // { "x": "X", "y": "Y" }
  /child/a.json
  /child/b.json
  /child/c.json

Depending on which one gets processed first, the result may be partial. For example if the order is this:

  /child/a.json
  child.json
  /child/b.json
  /child/c.json

Then whatever is set in a.json is ignored. This is due to how lodash.set() works:

const o = {}
_.set(o, ['a', 'b', 'c'], { foo_c: 'bar_c' })
// { a: { b: { c: { foo_c: "bar_c" } } } }
_.set(o, ['a', 'b'], { foo_b: 'bar_b' })
// { a: { b: foo_b: "bar_b" } } } }
// notice that foo_c disappeared!

Parses are invalid and test fails on a Windows device because of the imported sep which return \ when the path returned is /. It seems like the path returned defaulted to / on some time. It will cause error such as numerated json file in a folder (0.json, 1.json...) does not result in an array,

If you are facing this issue change const parts = path.split(sep) from sep to "/". Not sure if it applies to other Windows (10) or Node version (mine is v16.13.2).