alexdavid / create-factory-loader Goto Github PK

Webpack2 already handles es6 module syntax like import React from 'react' properly.
But if we use that loader with new syntax we have:

import Component from 'create-factory-loader!./component'

to (thats actually cases syntax error)

import Component = React.createFactory(require('./component'))

I find it odd that the name of the module and the loader doesn't mention react.

If a library defines there exported object properties using Object.defineProperty (example is react-color) then the create factory loader does not work as properties defined that way cannot be overwritten with simple assignment

react-color uses babel and this is the compiled js:

Object.defineProperty(exports, 'ChromePicker', {
  enumerable: true,
  get: function get() {/* ... */}
});

I think we should add a deprecation warning to this and suggest using react-e instead.

Thoughts? @charlierudolph @kevgo