alexbeltran / gobacnet Goto Github PK

bacnet implementation in go!

License: GNU General Public License v2.0

Go 100.00%

bacnet golang go

gobacnet's Introduction

goBACnet

gobacnet is a client for bacnet written exclusively with go. The goal is to only offer a client and a test server application.

NOTE: This code is very experimental and therefore should not be used in anything you want working. There are many changes being made and I cannot guarantee compatibility between versions. Many features of the protocol are missing and will be added overtime.

Installation

Part of this library is a command line client. To install from source run:

go get -u github.com/alexbeltran/gobacnet/baccli

For usage run:

baccli --help

Features

Below are features that are intended to be completed for the library and for the command line interface ordered in no particular manner. If you would like a feature not in the list below add a discussion on github for it.

Library

Command Line Interface

Contributing

Contributions are more then welcome for this project. Use golint for formatting and be sure to include test coverage on any new additions.

License

This library is heavily based on the BACnet-Stack library originally written by Steve Karg and therefore is released under the same license as his project. This includes the exception which allows for this library to be linked by proprietary code without that code becoming GPL. This exception was taken from the original BACnet stack and is included in every file.

The exception is as follows:

    "As a special exception, if other files instantiate
     templates or use macros or inline functions from
     this file, or you compile this file and link it
     with other works to produce a work based on this file,
     this file does not by itself cause the resulting work
     to be covered by the GNU General Public License.
     However the source code for this file must still be
     made available in accordance with section (3) of the
     GNU General Public License."

gobacnet's People

Contributors

Stargazers

Watchers

Forkers

callsign-core jiachinzhao takeshi-yashiro kgolding ramy-ahmed zhongweibest shaunco sdghchj drdaredevel eds2code i-bms vanti-dev jb0n lucien0229 haerk jordandzh michaelbironneau liggyi sultra

gobacnet's Issues

Change error passing to add context

Currently all errors are simply passed. Adding a little bit of context as we pass it up the chain will help with debugging.

i.e.

_, err := os.Create()
if err != nil{
    return fmt.Errof("unable to create file: %v")
}

instead of

_, err := os.Create()
if err != nil{
    return err
}

This would be useful when passing up the chain since there are multiple stages and packages used for each command called. An example would be an error in the encoding portion could give additional context in the net layer so we know at what point it fails.

Unable to run on Windows

Keep getting the error:
←[31mFATA←[0m[0000] route ip+net: no such network interface

Add Travis CLI

readprop command is not working

@alexbeltran hi, i tried whoIs command in my windows pc , its is working
but when i try to run readprop command im not getting the output
C:\Users\DELL\go\src\github.com\alexbeltran\gobacnet>baccli whoIs -i "Npcap Loopback Adapter" -p 47808
{
"ID": {
"Type": 8,
"Instance": 1294418
},
"MaxApdu": 1464,
"Segmentation": 0,
"Vendor": 260,
"Addr": {
"Net": 0,
"Len": 0,
"MacLen": 6,
"Mac": "qf7CI9KO",
"Adr": null
},
"Objects": {}
}
]
Failed to write to log, write gobacnet.log: file already closed
for the above command im getting the output like this

can you tell me how to run readprop commmand below i mentioned how did i tried

C:\Users\DELL\go\src\github.com\alexbeltran\gobacnet>baccli readprop -d 1294418 -o 0 -j 0 -i Npcap Loopback Adapterr

im getting the errors like
time="2019-08-08T17:18:19+05:45" level=fatal msg="route ip+net: no such network interface"
plz help me with this issue
thank you

Document all public functions/vars

Add graceful error handling

Right now when a read property is not handle correctly it will time out instead of interpreting type 80 messages.

String's decoded append a unicode character at the start

This is due to skipping an enumeration of what the string type is.

[BUG] Attempt to read point when a string name is incorrect

Move networking stuff into its own subpackage

This will help with readability. :)

github.com/alexbeltran/gobacnet/net

Flatten structure

The types subpackage is nice to handle internally but once other projects start to use it, a flatter structure would be nice so all the end user of the library will have to do is import gobacnet instead of import gobacnet and import gobacnet/types.

This flattening is less important for parts that are not exposed such as the tsm and utsm.

Readprop Panics when object is not valid

See title

read mutil error!

read mutil error!
read property is ok. help

time="2022-08-29T12:01:32+08:00" level=debug msg="Broadcast Address: 192.168.32.255"
time="2022-08-29T12:01:32+08:00" level=debug msg="Local Address: 192.168.32.199/24"
time="2022-08-29T12:01:32+08:00" level=debug msg="Port: bac0"
time="2022-08-29T12:01:32+08:00" level=debug msg="Received IAm Message"
time="2022-08-29T12:01:34+08:00" level=debug msg="Received Complex Ack"
time="2022-08-29T12:01:34+08:00" level=debug msg="WEIRD PACKET: Class 2 Code 32: [48 1 14 12 0 0 0 7 30 41 70 94 145 2 145 32 95 41 85 78 68 193 199 32 164 79 31]"
time="2022-08-29T12:01:34+08:00" level=debug msg="Received Complex Ack"
time="2022-08-29T12:01:34+08:00" level=debug msg="WEIRD PACKET: Class 2 Code 32: [48 1 14 12 0 0 0 7 30 41 70 94 145 2 145 32 95 41 85 78 68 193 199 32 164 79 31]"
time="2022-08-29T12:01:34+08:00" level=error msg="read udp [::]:47808: use of closed network connection"