alex-swann / acp-vpn-bash Goto Github PK

Super dooper script thanks. Maybe it was my fault but I copied the script and it would display the following when I tried to run it:

sudo: ./acp_vpn.sh: command not found

so I had to the change the permission of the file

chmod 777 acp_vpn.sh

it then worked a treat :)

I think you could benefit from using elif here (and on the subsequent checks for $1).

Also I note you're using inline ifs, e.g. if [[ condition ]] ; then do-something ; fi - you might like to consider a shorthand version:

[ condition ] && do-something

... you can even do ternaries:

[ condition ] && do-something || something-else