The lcs_unity from alex-mcclelland

lcs_unity's People

Contributors

Stargazers

Watchers

lcs_unity's Issues

Sleeper action "Expand Network" sometimes recruits dogs

When you use the sleeper feature "Expand Network" the sleeper sometimes recruits dogs.

I'm not sure if that is expected behavior.

Fight.cs, doCleanup(), List modified in enumeration

Lines 232-241. There are list modifications in enumerations here:

            foreach(Entity e in liberals)
            {
                if (e != null && !e.getComponent<Body>().Alive)
                    liberals[liberals.IndexOf(e)] = null;
            }
            foreach(Entity e in conservatives)
            {
                if (e != null && !e.getComponent<Body>().Alive)
                    conservatives[conservatives.IndexOf(e)] = null;
            }

It crashes for me when someone dies:

InvalidOperationException: Collection was modified; enumeration operation may not execute.
System.ThrowHelper.ThrowInvalidOperationException (System.ExceptionResource resource) (at :0)
System.Collections.Generic.List1+Enumerator[T].MoveNextRare () (at <c8d0d7b9135640958bff528a1e374758>:0) System.Collections.Generic.List1+Enumerator[T].MoveNext () (at :0)
LCS.Engine.Scenes.Fight.doCleanup (System.Collections.Generic.List1[T] liberals, System.Collections.Generic.List1[T] conservatives) (at Assets/Scripts/Engine/Scenes/Fight.cs:232)

It's more correct to use an enumeration of indexes or to store indices in a list, e.g.:

            foreach(Entity e in liberals)
                if (e != null && !e.getComponent<Body>().Alive)
                    indicesToClear.Add(liberals.IndexOf(e));
            foreach (int index in indicesToClear)
                liberals[index] = null;
            ...

FYI: Unity asset serialization

Not an issue, sorry for spamming here,
but I think for your project it would be worthwhile to enable plain text serialization of the assets:
https://thoughtbot.com/blog/how-to-git-with-unity

Recommend Projects