Coder Social home page Coder Social logo

aldryn-disqus's People

Contributors

evildmp avatar finalangel avatar mkoistinen avatar stefanfoulis avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aldryn-disqus's Issues

Documentation

Please create documentation on how-to:

  • setup
  • usage
  • tutorial

cms plugin magic table naming removal

ProgrammingError at /en/admin/cms/page/clear-placeholder/1/
relation "aldryn_disqus_disqusplugin" does not exist
LINE 1: ...dryn_disqus_disqusplugin"."cmsplugin_ptr_id" FROM "aldryn_di...

Set `disqus_url` explicitly

The disqus_url configuration variable needs the site's domain.

We need aldryn/mirumee-feedback#8 resolved to have the domain available.

Breaks with SSL

(1) I have SSL enabled and running properly
(2) When on the page, the plugin does not work
(3) I fixed the problem by changing this line (inside aldryn_disqus/templates/aldryn_disqus/disqus.html):

dsq.src = 'http{% if request.is_secure %}s{% endif %}://' + disqus_shortname + '.disqus.com/embed.js';

to

dsq.src = 'https://' + disqus_shortname + '.disqus.com/embed.js';

I don't know what's going on but I wanted to see if anyone knows what's going on. Thanks!

Make disqus add-on not a page only add-on

Right now the disus plugin might be pinned only to a page.

I'd like to pin it to a placeholder field as well.

The previous version allowed that by making a disus_identifier a add-on instance pk.

This is not acceptable as a simple add-on remove/create action on the same page overwrites the identifier while it is expected to be always the same for the entity (page, blog post, etc.).

We need to be able to determine the URL of the entity as well (see #1) so we need a way to get it, like instance.placeholder_mounting_point.pk or instance.placeholder_mounting_point.get_absolute_url.

I think it is a common issue.

What is the expected way of handling this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.