alanlowzies / pe Goto Github PK

When I enter Ctrl + Z into the application and press enter, I get an infinite loop of the 'Wrong format' error message. Please see the GIF below for an example.

I can only get out of the indefinite loop by pressing Ctrl + C.

As a new developer, without this section, I am unsure of how to begin developing for this application.

• Missing activation bars, for example, Packages#getPackage() and TravelPackage#saveTravelPackage().

• Missing return arrow back to TARBS to 'close' the Storage#savePackageToFile() method call.

I have the following package (note the vacancy total of 30):

with the following reservation info:

If I were to quit the app, open the data.txt file and modify the vacancy for the second reservation to a number larger than the permissible vacancy limit:

The application launches fine and the new 'pax' value for reservation 2 is displayed without issue:

I created a package with ID 12345, I made two reservations, each with 2 people (total 4), but the information about the packages shows 6 vacancies filled.

Prior to this, I was 'stress testing' adding reservations with the same package ID and contact number, and very high 'pax' values.

I noted that the commands to create and view information about a package are 'add' and 'info'/'all' respectively. However, I feel that this can be potentially confusing for users as these command words (i.e. 'add', 'info', 'all') do not indicate that these commands are specifically meant for handling packages. For example, as an end-user, when I see the word 'add', I thought this command could perhaps be used to add either a package or a reservation.

As a suggestion, perhaps the 'add' command could've been renamed to 'addPackage'? That way the ambiguity is reduced.

Seems like a part of the sequence diagram has been clipped off the page. Perhaps you could have added a page break before the sequence diagram to send the sequence diagram to a new page.

This is the description for the info command:

This is an example of my usage of the info command:

Perhaps the formatting of the date in the info command could be described in the UG? That is, is it yyyy-dd-mm or yyyy-mm-dd?

This can be useful because the add command requires me to format the date in dd-mm-yyyy. Thus, the difference in the way the date is displayed can be potentially confusing for a new user.

In particular, perhaps the {vacancies} parameter could have a description to describe what kind of vacancy.

As a new user, I was a bit confused when I saw that {vacancies} parameter without any description of it.

Had to cycle through 'exit', 'quit', and 'bye'.

I had to cycle through the common exit keywords 'exit', 'quit', before getting the right keyword ('bye').

As a new user, this can be a minor inconvenience for me.

This is the UG on the reserve command:

I noted that you cannot add a new reservation with the same package ID and contact number as an existing reservation. Thus, perhaps this constraint could've been written in the UG?

I have the current reservation information for package ID 12345:

I understand that you cannot add a new reservation with the same package ID and contact number, as shown in the screenshot below:

However, if I were to quit the application and edit the second reservation (Bad Boy123, 111111111111111) in the text file to have the same contact number as my first reservation for package ID 12345:

The file loads just fine and the reservations are displayed fine:

I believe that this is a discrepancy as the application does not allow me to add a new reservation that has the same package ID and contact number as an existing reservation.

The 'Instructions for manual testing' section feels unclear. For example, please refer to the 'Test Case 1':

Some considerations:

• Perhaps the header 'Test Case 1' could be more descriptive of what the test case is about?
• The test case mentions using the package command to view all available packages. However, as a developer who recently just set up the app and just wanted to test it out, it would be helpful to list down the steps to create the packages as shown in the screenshots.

Currently, if I were to use the 'all' command to sort the packages, I would get the following:

However, as an end-user, I find this potentially inconvenient that the values that I'm sorting the packages by are not displayed on the list. WIthout the values, I cannot make proper comparisons between the packages when viewing them in the list.

For example, if I wanted to sort by price, it would be better if I could also see the prices of each package in the list. Likewise, if I were to sort by date, it would be nice to see the dates in the list instead.

Possible use case: A customer wants me to find them a package that is within a certain price range. It would be useful if I can sort the packages by price and see which packages fall within that range by scanning their prices on the list.

Some issues regarding the object creation of Storage object in the sequence diagram:

• For the constructor method call storage(filePath), the 's' in storage should be capitalised.
• Missing activation bar for object creation of Storage
• Missing return arrow after creating a Storage object.

Other issues:

• The parseTravelpackageFile and parseReservationFile methods are missing their parentheses.

This is a dummy bug report

EDIT: fix typo error

In the UG, I noted that the package-related commands are introduced in the following manner: packages > info > all > add > delete.

However, I feel that the 'add' command should be placed before the 'packages', 'info', and 'all' commands.

As a new user of the app, showing me how to view the packages when I do not know how to create them yet doesn't feel right.