alanclasses / tsos Goto Github PK

This would include removing the outdated namespace keyword.

• https://www.typescriptlang.org/docs/handbook/namespaces.html
• https://stackoverflow.com/questions/32805559/typescript-es6-import-module-file-is-not-a-module-error
• https://stackoverflow.com/questions/30357634/how-do-i-use-namespaces-with-typescript-external-modules

@labouseur

• Add a shell command to test this. Remember to include it in the help

This is taken from source/os/canvastext.ts

The total var seems to be the length of the string in terms of width. But... it never gets changed anywhere after initiating. Then at the bottom it just returns 0.

public static draw(ctx, font, size, x, y, str) {

        var total = 0;

        var len = str.length;

        var mag = size / 25.0;

        ctx.save();

        ctx.lineCap = "round";

        ctx.lineWidth = 2.0 * mag;

        ctx.strokeStyle = "black";

        for (var i = 0; i < len; i++) {
            var c = CanvasTextFunctions.letter(str.charAt(i));
            if (!c) {
                continue;
            }
            ctx.beginPath();
            var penUp = true;
            var needStroke = 0;
            for (var j = 0; j < c.points.length; j++) {
                var a = c.points[j];
                if (a[0] === -1 && a[1] === -1) {
                    penUp = true;
                    continue;
                }
                if (penUp) {
                    ctx.moveTo( x + a[0]*mag, y - a[1]*mag);
                    penUp = false;
                } else {
                    ctx.lineTo( x + a[0]*mag, y - a[1]*mag);
                }
            }
            ctx.stroke();
            x += c.width*mag;
        }
        ctx.restore();
        return total;
    }

Mozilla developer network has marked KeyboardEvent.which to be deprecated and nonstandard, even though most browsers have implemented it (albeit in an non-unified fashion).

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which

Considerations:

• keyCode and charCode are also both deprecated, with inconsistent browser support.
• key is current and standard, however it does all the work that we're doing to take into account shift, locale, etc.
• keyIdentifier seems to be a highly unimplemented and nonstandard stunt pulled by Safari (the only one to possibly implement it).
• code might be a correct alternative. It represents which button on a device is pressed, without any consideration for what character that button is supposed to generate. This might be low level enough to keep student struggles aloft, but standard enough to work consistently in many browsers.

• Accept and display punctuation characters and symbols.
• Handle backspace appropriately.
• Implement command completion with the tab key.
• Provide command history recall via the up and down arrow keys.

the current date and time
• status messages as speciDied by the user with a new shell command:
status
example: status i love opera*ng systems

date - displays the current date and time
whereami - displays the users current location (use your imagination)
something else interesting and creative; surprise me