alama / pso2proxy Goto Github PK

Upon receiving messages in Gchat/GIRC with !gmode set to Team Chat; either the user's PSO2 will crash or they will get blank messagse with single kanji as the username, as pictured here (https://cdn.discordapp.com/attachments/308056060759900162/372677289319596033/172550-25-10-2017.png)

The current temporary solution is to change gchat to system chat via !gmode

as far as i know that if proxy send chat packet (system) before damage packet (and few other types) it will make client disconnect from proxy. i haven't seen this issue on cyberkitsune proxy (but can reproduce with plugin) but i still wondering if it exists and randomly disconnect clients with gchat enabled since send_crypto_packet direct call transport without any concern.
https://github.com/alama/PSO2Proxy/blob/public/proxy/ShipProxy.py#L58-L63

pseudo plugin code to reproduce the issue

@plugins.raw_packet_hook
def on_packet_received(context, packet, packet_type, packet_subtype):
     if packet_type == 0x04 and packet_subtype == 0x52:
          context.send_crypto_packet(packetFactory.SystemMessagePacket("danger", 0x3).build())) # client disconnect from proxy after receive this packet

!g outgoing messages from within the game show up fine within the irc, but incoming messages from outside the game do not display when in the PvP ship and !gmode is set to team. If !gmode is set to system, incoming messages display fine and outgoing messages still have no problem. incoming !g messages work fine as team or system for challenge mode.

👀
👌🏿
🤔
👏🏿

http://i.imgur.com/h8c9uv7.jpg unicode causes a global message to appear.