alacritythief / emphasis Goto Github PK

I just wanted to give you some input on your project as it is, currently.

• Remove the /test folder. Since you are using RSpec, all of your test go in the /spec folder. /test was created by default when you called the rails new <project_name> command. In the future, if you would prefer Rails to not create the /test folder, run rails new <project_name> -T
• In the description at the top of your GitHub project, 'webcomics' is misspelled.
• Be sure to add a link to your live app to the README.md file when you deploy.
• It would be nice to see the ER diagram and your 'To Do' list in the README.
• I wouldn't set default urls in the migrations. This makes them difficult to change in the future. Create a method in your comics model that returns the default url if cover_img_url is nil.
• Create factories for your models.
• Create model tests.
• Remove turbolinks. Eric's turtlelinks gem makes it easy: https://github.com/HeroicEric/turtlelinks
• Implement a simple animation. JS, CSS, Canvas; Doesn't matter. Whatever seems the easiest and most intuitive, go for it.
• If you would like me to review a feature branch, push that branch to GitHub, assign me to it, and ping me on Flowdock.

If you want any assistance or have any questions, let me know.