akc42 / akc-route Goto Github PK

in the _outRouteChanged function with are checking that our params match allowed ones. The check is if (changes.base.params[key]) { , but this is false of the value of that parameter is zero.

I removed urlSpaceRegex and its related functionality as it is not so much related to routing, and if you want to use it you can just use <iron-location>. I haven't reflected that in the readme

Can we also have regex in if matched? It will open a world of possibilities for the component

I was wondering if there was any way to secure routes? Some combination of the route plus the roles required to access the route.

There are two errors in the README

1. There are only two parameters to <akc-location> the third was related to capturing clicks, which is not implemented as the user can just use an <iron-location> to achieve the same effect and is therefore out of place in this router

2. We actually interpret a leading "-" as making a negative integer integer in a segment that otherwise consists solely of the characters "0" to "9". This was the result of #6 where the documentation was not updated

I updated a route by setting a new one, which should have propagated to the top. I am beginning to suspect I fell foul of my own rule and dealt with updating the route in a non piecemeal way to support the updates from the api with just parameters or just new query string. ALL these things should be handled via a single observer on the whole route, and the result should be a complete new route when it updated so the changes all remain in sync

I set a new route by setting path, params and query params to a new value that wasn't matched by this if-matches parameter. This was picked up by the _inRouteChanged observer but not processed because the route didn't match. But it was also picked up by _paramsChanged and _queryChanged observers - because the in-route value is also the out-route value higher up the tree, but when it got there the route wasn't complete (missing query params and the combination of path and params wasn't correct.)

I think this may require a major change by replacing this piecemeal observers with a complete out-route observer

The router seems to go into an infinite loop when the outRoute has changed, but it doesn't change the inRoute

We have a chain of routes like so

page -> pidcid -> date

date is not active, but has a path of /20160101 as a result of a previous call some time ago. I adjust the cidpid parameters so that it now become active and we have to create the outRoute.path value.

At the moment it is adding on the date path, but I think it should only do that if date was previously active.