Coder Social home page Coder Social logo

Audio padding issue about mpvacious HOT 17 OPEN

Geniusssmit avatar Geniusssmit commented on July 16, 2024
Audio padding issue

from mpvacious.

Comments (17)

tomtung avatar tomtung commented on July 16, 2024 1

I also found this behavior really confusing: padding is only respected for single-line selection, but somehow not for multiple-line selection. I needed to spend some time debugging to figure out what was going on.

When you override timings set in the subtitles, mpvacious assumes that your subs are incorrectly timed, and disables the padding

I think this behavior is only expected when the user directly sets the timestamps without referencing the exact timing of the current subs. I only use shift+s and shift+e when the subs are already correctly timed, and I need to select a range of them. In this case, this behavior is definitely a surprise for me.

If you want to create a card with padding, you shouldn't use shift+s and shift+e and instead use only c and shift+l,shift+h

This is probably the best option. I didn't try it before because it seemed less intuitive than shift+s and shift+e.

Alternatively, just locally comment out these lines.

mpvacious/subs2srs.lua

Lines 331 to 333 in 178674f

if subs_observer.user_altered() then
return 0.0
end

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

Motokare no Yuigonjou 2022 S01 1080p WEB-DL AAC H.264-MagicStar.zip
comparison, padding set to 1.0 (1 second)

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

difference is exactly 2 seconds

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

Padding is only applied when timings are chosen automatically. When you set them manually, no padding is applied.

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

c - Interactive subtitle selection. is automatic?

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

If you want to create a card with padding, you shouldn't use shift+s and shift+e and instead use only c and shift+l,shift+h

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

I see, difference is not obvious tbh, but ok, also do you know why it cuts audio, even if subtitle is still shown. I ended up with 1.0 padding, but thats quite big

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

When you override timings set in the subtitles, mpvacious assumes that your subs are incorrectly timed, and disables the padding since applying it would mean potentially grabbing extra parts of the dialogue that you don't want on your card.

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

I ended up with 1.0 padding

Could be your subtitle's timings, or the amount of padding you set in subs2srs.conf.

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

When you override timings set in the subtitles, mpvacious assumes that your subs are incorrectly timed, and disables the padding since applying it would mean potentially grabbing extra parts of the dialogue that you don't want on your card.

I understand that. I mean I check, timings are perfect, even without overriding mpvacious cuts before subtitle disappears.

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

that's why I'm using 1.0 padding to compensate it

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

but yeah, anyway "c" key works just fine.

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

Bandicam 2022-11-14 19-57-05-276-1.zip
Please watch, it cuts 4 seconds earlier, even with "c"

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

that's why I'm using 1.0 padding to compensate it

You're better off fixing the timings then.

Please watch, it cuts 4 seconds earlier, even with "c"

On the video you still set the timing manually.

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

that's why I'm using 1.0 padding to compensate it

You're better off fixing the timings then.

Please watch, it cuts 4 seconds earlier, even with "c"

On the video you still set the timing manually.

I mean, as you can see, automatically it sets end timing to 07m30s200ms, but when I fix it manually, I set it when the line ends, it ends around 07m34s186ms

from mpvacious.

Geniusssmit avatar Geniusssmit commented on July 16, 2024

image
I think there is something wrong with the subtitle file, do you know how to deal with cases like this? 2 exact same lines with different timings
[MagicStar] Motokare no Yuigonjou EP04 [WEBDL] [1080p].zip

from mpvacious.

tatsumoto-ren avatar tatsumoto-ren commented on July 16, 2024

This could help. You can also open the file in vim and remove the redundant lines.

from mpvacious.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.