airavata-courses / methkupallivasanth Goto Github PK

Please create a wiki that describes how to install and run your codes.

In your readme file, you have steps to install MongoDB and import tables. But there are no steps to start or run the servers. Please add.

Hey, just had a query regarding the project architecture.

There are 3 micro-services in your system viz.

• JavaScript (Node.js)

• JAVA (Spark Java)

• PYTHON (Flask)

It looks like the UI resides within the Node.js app.
However, the UI is expected to be separate from the micro-services.
i.e. 1 UI component & 3 micro-services.

So just a heads up to refactor the UI out of the node-js micro service if what I observed is true.

All microservices are running fine.

There is a UI and a node.js Orchestrator / API Server,
but the index.html has redirect links to the microservices.

<ul class="nav navbar-nav navbar-right">
            <li >
                 <a href="http://localhost:3000/api/books">Node js Microservice</a>
            </li>
</ul>

Instead, the expected workflow is

1. UI invokes the API Server endpoint either synchronously or async using AJAX.
2. The API Server initiates requests to the microservices.
3. Based on the responses from the microservices, the API Server displays data back to the UI.

The User should not be redirected away from the UI. A REST call is supposed to bring data back to the server. Thus, the API Server is not serving the purpose at the moment.

Please implement an API server which acts as a gateway to the microservices. You could refer the lecture slides for a better understanding.

I see your commit on RabbitMQ 8b5e548. But I dont see RabbitMQ being used in your code.

Also, you have not mentioned anything with respect to docker in your wiki. Are you still working on containerizing this?

I am getting following error while trying python microservice - 'Collection' object is not iterable.
Following is trace back call -

Traceback (most recent call last):
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 2000, in call
return self.wsgi_app(environ, start_response)
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "D:\Ana-conda\lib\site-packages\flask\app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "E:\SGA Review\Assignment1\MethkupalliVasanth-master\MethkupalliVasanth-master\Assignment-1\python-service\app.py", line 22, in get_all_books
for a in book:
File "D:\Ana-conda\lib\site-packages\pymongo\collection.py", line 2640, in next
raise TypeError("'Collection' object is not iterable")
TypeError: 'Collection' object is not iterable

The line
from flask_pymongo import PyMongo is commented in the code. Uncommenting it will make it work.

Could you create a wiki describing the installation, running and testing steps? It would be great if you could list down all the tasks to be done and which you have completed till now.

I get the following error:
... E QUERY [thread1] SyntaxError: missing ; before statement @(shell):1:15

You don't mention where I should be downloading the book.csv & genre.csv files. Maybe the error is because of missing files? I have already cloned your repo and I am running both mongod and the mongo shell inside the cloned directory.

Has not implemented a CI/CD pipeline for building deployment of your application using Jenkins