airavata-courses / envy Goto Github PK

Good things:
The UI design looks very good. You have identified a real problem and you seem to have a good solution for it.
Suggestions:
Encrypt password
The user should be able to search routes without logging in.
There need to be some changes in the routes that are shown below. They need to be more descriptive. It should tell the location of each segment.

Create Login/Signup basic code layout using Node.js, Expressjs and postgreSQL.

Add logging to help debug

1. Since this is the first step in your wiki, you should include git clone and git checkout command.
2. You are asking to run the file using \i command, that is enough, no need to redirect the user to that file.
3. Also add the link to postgres home page.
4. what is 'postgres command line' and how to fire it up?

After updating the wiki, please include the commit id here, then I will mark below checkboxes after verification and close the issue.

• Add git clone and checkout commands.
• Remove redirect to 'DB creation and initialization', ask user to directly run the file.
• Add link to download postgres DB.
• Write steps to navigate user to postgres installation directory/bin folder and find psql binary

Display some kind of loading sign.

• It would be better if you write the exact commands to install. Referencing the installation links is always good but it should also have commands to ease the installation process.
  For develop_cheapest_service you could write "pip install djangorestframework" and "pip install django"

• You can have a requirements file to install all the project dependencies.

• Update the wiki. Some project dependencies are not mentioned in the wiki for windows

  1. corsheaders
  2. psycopg2

Servers are not connecting to database(Not able to login or search locations)

When i try to run the initializer / insert sql files, there are erros like database api already exists.
When i try to manually drop the roles and databases, it fails giving me an error - 10 other sessions are using the database.

EDIT : i had shutdown all other services, still giving me error 10 sessions are using this database, cannot drop it.

• Modify the scripts so that user can reset the databases by running the scripts again.
• Write instructions to close other sessions vefore dropping the databases/roles.

Looks like some multiple services are configured to run on same port, from microservice point of view this is okay as these services would run on different machines, but from dev point of view it would be better if your services have production environment and development environment variables that help then decide the port they want to run in different environments.

This is just a suggestion, as of now, i cannot run multiple services on my machine, so peer review is not complete until this issue is resolved.

Add your commit id here.

• Used different ports
• Services have no port clash while starting them.

i used the database setup wiki to setup the DB, please see below errors.

• Make sure to drop database at the start of the sql script so that there are no conflicts.
• Scripts run successfully from the scratch.

Gives the following exception during 'mvn spring-boot:run - To start the Java Service' step of the wiki.
Note: I already have the DB setup successfully.

Add your commit id here

• spring boot is up and running.

ran the commands in the project wiki, server runs on port 8000.
How do i test that its running as it should ?
you might wanna look into the logs

For some locations, flight request return null or empty.

Git clone to Login-Signup backend service setup not working, I copy pasted the command from Wiki

add your commit id here.

• git clone to this repo is now working.

git cloned and git checkout to the right branch, then ran npm install and npm start, got the following errors

EDIT : looks like you forgot to add cd ./travel in your wiki.
Add your commit id here

• Fixed npm install errors.
• Fixed npm start errors.
• Service is up and running.

While starting python server, getting rest_framework module not found error

Did pip install djangorestframework and got this error

Instead of pip install virtualenv Do pip install psycopg2 to solve that and got this error:

Probably some issue with python version. Please mention which python version to use.

Suggestion:
Create a requirement file in python api folder and mention all the requirements there
So, the user only has to do pip install -r requirements.txt

please add node_modules in .gitignore, it takses a while to clone the project, and user has to do npm install anyway.

• add node_modules to .gitignore.
• add node index.js into package.json inside npm scripts

Please create a release branch and merge all the branches in that branch so that the user does not need to clone the project again for starting each API.

Make it dynamic

UI issues:
Signup doesn't return any errors when signing up using existing details
Login doesn't show errors when logging in using an incorrect password
Login doesn't show errors when logging in using an incorrect password

Explain the steps to get psql shell connected to 'postgres' db.

Attach your commit id here.

• Added steps for psql shell to connect to 'postgres' DB.