Coder Social home page Coder Social logo

abc's People

Contributors

absheth avatar marpierc avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

abc's Issues

Update Wiki

Update Project Wiki for Installation on Windows

Npm Start Failure

screenshot from 2019-02-09 14-00-27

Npm start failing after I clone the User Management Service and I do npm start

Design questions

  1. Are the API's exposed on wiki authenticated before they'r processed?
    Ex: DELETE : http://localhost:8080/tweet/deleteByTweetId/5c59282a2ad5c62ef6fc69e0

  2. Why does the tweet post API return the tweet as response?
    POST : http://localhost:8080/tweet/create/
    also create user, POST : http://localhost:3000/user

Please see first two answers: https://stackoverflow.com/questions/1829875/is-it-ok-by-rest-to-return-content-after-post.

Please, add what is being achieved with the above in the comment.

  1. Is TweetLike model just a relationship entity ? user and tweet? (many to many)
    Can we not save Collection User {
    likes : [list of tweet ids]
    }

SImilarly, User and followers or may be following list in user.

is there anything else achieved with the current design we have?

  1. Is the request authenticated:
    DELETE : http://localhost:3000/user.
    Who will be deleting an user? Is there a admin role?
    Request Body:
    {
    "userId": "c4836160-2914-11e9-8b00-99a430df561b"
    }

Response Body:
{
"deletedCount": 1
}

I don't think we can pass multiple userIds in request, then why we need count as response? . Is there a possibility that the user deleted by an admin doesn't exist in DB?- if not, the response will always have a count 1, else a response body will have an error status in case of any failures.

  1. Does this work? GET method
    GET http://localhost:3000/user/search

Request Body:
{
"userId": "7e4fdd8c-f148-44fc-a187-283c0e142c41",
"searchQuery": "doe"
}

  1. Under /feed, What is the purpose of
    @RequestMapping(value = "/create/{userId}", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE)

creating user? using GET , under /feed ?

  1. User management... Can we move the url handler code out of server JS and have respective mapped modules.

Please help us understand better.

Peer Review - Milestone 2

The architecture diagram is well illustrated and wiki is descriptive and helpful.
CI/CD through Jenkins is working just fine! The idea of the project is clear and test steps were easy to follow.

Some of the improvements (for next milestone) I can suggest are:

  1. A "Forgot password" and Profile image upload functionality.
  2. "Follow" button should change to "Following" post click
  3. Putting in a wrong password does not give any error (form validation is working fine for email though)
  4. Duplicate copies are being created at times (Creates 2 profiles in "Following" list when 1 profile was followed, 2 tweets on the dashboard when 1 post was made, etc.)

Overall, the project documentation, structure and implementation looks good!

Installation issues

Mac user.
1.
At step: java -jar ABC/FeedService/target/feedservice-*.jar
Relative path doesn't match. Neophytes may face issues

  1. At Step: Once you have npm installed, install react as follows:
    npm install -g create-react-app
    What is the need of this?

At DB startup--- Press Config in front of Apache and open httpd.conf
Change Listen 80 to Listen 8080
Here, 8080 is not feasible as Spring application by now would have taken the port.

  1. Could not start the MySql DB server . Failed

Peer review Milestone 1

I raised the following the issues for the team, ABC

  1. Npm start failure - #45

  2. Python flask installation virtualenv - #46

  3. User log in errors - #47

The issues were mostly on the installation. After updating the wiki, and pulling the latest changes, the issues were resolved.

The idea for the project is good. Since they are using standalone ( different ) dbs for the services, project is modulated well.

One feedback - To run every service, I had to clone each branch separately, they could have merged into a separate release branch or kept the name of every folder in the branch name to be different.

Thanks,

Shivani

Messaging: Setup Kafka instance

Used by:

  • Tweet management service: Send a new post to search service
  • User management service: Send user details to search service

Assignment 1 feedback

Hey guys,
Are you maintaining a release branch for Project-1? I am starting with reviewing your project but couldn't find the release branch.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.