Problem with cloning on Windows about phpstormprotocol

[King2500]

Is the Icon file needed at all? It has no content.

[aik099]

It has content, when viewed on Mac. It's not needed for Windows.

[aik099]

Can't download a tarball instead (zipped git clone)?

[King2500]

No. Need to clone to update/rebase my fork.

[aik099]

I have no idea how this can be fixed. Maybe Google knows. Maybe you can search for that error you're getting during clone. I don't think Git doesn't like empty files in general, but maybe it has having problems detecting file type or something else in that file.

[King2500]

>git clone https://github.com/King2500/PhpStormProtocol.git
Cloning into 'PhpStormProtocol'...
remote: Counting objects: 85, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 85 (delta 0), reused 0 (delta 0), pack-reused 80
Unpacking objects: 100% (85/85), done.
 (Invalid argument)eate file PhpStorm Protocol.app/Icon

Git isn't able to save the file on Windows systems, since such a character is not allowed on Windows filesystem.
Internet says delete the Icon file or use a Mac (which I can't).

I went another way, by sending a pull-request to my fork and merge the changes from your repos.

In the end I want to make this pull-request, which now includes an additional "merge" commit:
https://github.com/aik099/PhpStormProtocol/compare/master...King2500:King2500-patch-1?expand=1

Is that a problem for you?

[aik099]

The file was named Icon\r and I've tested that after it was removed Mac app was working too and icon was showing. I've made a commit. Now you shouldn't have any issues with cloning/rebasing/etc. Please send appropriate PR and I'll review it.

This article helped me to remove it: http://stackoverflow.com/questions/22589978/remove-weird-iconr-file-from-staging

[King2500]

Got fixed with commit cc2fd3b