Comments (11)
... However, it seems as though it may be getting over looked quite a bit. ...
@amacsmith , if you recommend changing phrasing in README.md to make it more clear, that unless you fix this it won't work by default
, then PR's are also welcome.
from phpstormprotocol.
O my PC win10 x64 it only worked when I removed the "//E:JScript" part from the .reg file.
What was your error before the removal? The "//E:JScript" part is for forcing the use of standard .js engine in case user has reassigned .js files handler in windows and shouldn't cause errors itself.
from phpstormprotocol.
The //E:
argument of wscript
command specifies scripting engine (the JScript
in this case).
According to https://en.wikipedia.org/wiki/Windows_Script_Host#Available_scripting_engines this is a valid value.
@jsvini , please try running below command (same as in "run_editor.reg" file, but with escaping removed) and post a result:
wscript "C:\Program Files\PhpStorm Protocol (Win)\run_editor.js" "%1" //E:JScript
from phpstormprotocol.
@aik099 that line worked for me. I also had to update the run_editor.js with the current version of phpstorm and everything worked like a charm. Thanks!
from phpstormprotocol.
@amacsmith , could you please send a PR with proposed changes and an explanation of them. I can't commit the picture you've posted.
from phpstormprotocol.
Sorry, let me explain, I had to update the settings.folder_name to my installed version/name of PhpStorm. It may be useful to scan through the Programs folder look for the JetBrains folder and find a folder name that starts with PhpStorm x.y.z. and capture that as the folder name or else I feel people will need to edit this file to get it working if they don't have the same version installed as what is in the repo.
from phpstormprotocol.
@amacsmith , that part of the installing instructions on Windows in the README.md already. Thanks for pointing that out anyway.
from phpstormprotocol.
Yep that is why I mention. However, it seems as though it may be getting over looked quite a bit. Hence, why it might be a good idea to search the directory for the PhpStorm folder by the prefix 'PhpStorm' and update that settings object accordingly. That way users don't have to manually do it and people don't over look the documentation. Only a recommendation.
from phpstormprotocol.
Will do
from phpstormprotocol.
I also think the line
// Set to folder name, where PhpStorm was installed to (e.g. 'PhpStorm')
folder_name: 'PhpStorm 2017.1.4',
should be shipped without a PhpStorm version hardcoded. So the end-user knows they need to update it. An example could be like this:
// Set to folder name, where PhpStorm was installed to (e.g. 'PhpStorm')
folder_name: <PhpStorm folder where the phpstorm.exe is located>,
I can create a PR for that as well.
from phpstormprotocol.
PR #35 was created. I've reviewed it.
from phpstormprotocol.
Related Issues (20)
- Provided Framework configuration doesn't work HOT 7
- How to manage it to work with projects on vagrant HOT 6
- ActiveX object not available for Windows 10 HOT 3
- Regular expression does not match HOT 19
- Windows 10 - No error but file is not open HOT 23
- got an error while opening file HOT 4
- How to uninstall this? HOT 1
- It work but with error HOT 2
- Popup every time I trigger a link with this protocol HOT 3
- Linux support HOT 5
- Cannot find file 'C:\Windows\system32\W' HOT 7
- Please add to urldecode for linux HOT 3
- The system cannot find the file specified HOT 1
- JetBrains toolbox dir HOT 7
- can't find run_editor.js HOT 2
- wsl + docker + win10 problem HOT 9
- Problem with running this on windows HOT 2
- Can open file in PHPStrom8 HOT 6
- Problem with cloning on Windows HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstormprotocol.