aidenbell / jsonhub Goto Github PK

Comments in the source look a bit grim when used to godoc, they need a tidy up

Currently there is a single exchange created on boot and mounted at the root URL of the server. It'd be good to allow any number of named exchanges, creating many independent hubs for exchanging messages over. These could be setup at a "hubs" endpoint:

/hubs/my-exchange/
/hubs/my-other-exchange/

The test client and any future admin interfaces can then also be moved to more sensible URLs.

The logging is pretty basic and doesn't have any log levels currently. There's lots of debugging printf style logging in there too ... this wants a tidy up and a command-line option for turning on various log levels.

As title, currently we always create a new ClientPool for clients joining with the same subscription. In order to allow some more interesting subscription structures, we should assign identical subscriptions the to the same pool.

Later this will allow us to specify the distribution type, and allow load balancing across like-clients for example.

The named exchange map needs replacing with Concurrent Map or some other concurrency safe map implementation.

jsonhubd allocates new named exchanges when they are requested in a map, but when all clients leave an exhange (or its sub tree of subscribers) there is no way to cleanup. This means that you could request billions of unique exchanges and fill memory (albeit slowly)

As title, more docs are required but I want to keep it lean. Ideally, within the readme.

The Exchange and Queue types (and Exchanger) are pretty much the same interface but with different implementations. Making them adhere to the same interface makes things more flexible.