Comments (6)
this is not a problem with any installation method other than straight.el
I would think this would affect people using Git submodules and checkouts; anyone who has cloned this repo and tracked the upstream master branch will be affected. Any GitHub URLs with master
in them will be broken too… the impact of changing branch names is more far reaching than straight.el
and package management inside of Emacs.
I would hesitate to blame anything on this package.
If the owner of an open source project wants to rename a branch that's their choice. I'm only asking if the project owner(s) would be open to mentioning a breaking change somewhere to make things better for everyone.
Given the volatile nature of this topic I want to reiterate that I've not tried apportioning blame here.
I have encountered an issue that is affecting me, and I'm trying to make the migration easier for everyone. I've asked a question of the project owner(s) to gauge interest in a potential contribution.
from emacs-websocket.
To be fair, this is not a problem with any installation method other than straight.el
, and it is clearly a bug in straight.el
. MELPA handles the issue just fine. I would hesitate to blame anything on this package.
from emacs-websocket.
Adding something to README sounds like a good idea. But, in general, is there a best practice here that I didn't follow? I wonder what other packages going through similar renamings are doing (I could perhaps leave the master
branch open, however it seems like a bad idea to have two branches that both seem like the default branch). If anyone knows, advice would be appreciated. In the meantime, I'll add a note to the README.
from emacs-websocket.
Committed be99c46 to warn users about the issue. This will hopefully be temporary until a fix is settled on on either side.
from emacs-websocket.
Unfortunately, as this currently stands this issue prevents me from upgrading doom, as the unexpected error breaks the upgrade process.
While doom/straight.el are resolving this issue, might it be possible to have a temporary master
branch to avoid breaking doom/straight while people work are working on a fix?
from emacs-websocket.
OK, recreated the master
branch. Once the fix is in, I'll remove it again. Thank you for your patience.
from emacs-websocket.
Related Issues (20)
- websocket-frame-text error HOT 1
- Add release tags HOT 3
- Custom headers in handshake HOT 4
- How to handle an error occured in `websocket-outer-filter`? HOT 6
- A single message ws.send(data); comes in as two messages HOT 5
- Speed feedback HOT 10
- Randomly losing connections under emacs-ipython-notebook with version 1.11 HOT 5
- Error (websocket): in callback `on-message': JSON readtable error HOT 4
- Setting case-fold-search to nil results "Incorrect handhake from websocket" error HOT 7
- declares GPL-3+, but provided full-text license is GPL-2+ HOT 3
- Please tag a 1.12 release HOT 1
- Please consider adapting websocket-functional-test.el to use ert-deftest HOT 12
- TLSv1.3 HOT 1
- websocket-test.el: ‘flet’ is an obsolete macro (as of [emacs] 24.3) HOT 3
- websocket-to-bytes signal type error HOT 8
- Support connecting through proxies HOT 7
- infinite failure loop - emacs locked up HOT 18
- error 403 with ein over proxy HOT 14
- Push to ELPA? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emacs-websocket.