How to handle an error occured in `websocket-outer-filter`? about emacs-websocket

[ahyatt]

You can check for errors with condition-case. If the websocket cannot connect, re-opening with websocket-open seems like the safest thing to do.

[cireu]

Can you try this piece of code?

aria2c --enable-rpc --rpc-listen-port=6800

(condition-case _ (setq ws (websocket-open "ws://localhost:6800/unreachable)) (message "Error!"))

The condition-case won't work because you can connect to the server but you will get 404 response because unreachable doesn't exist, You will get

error in process filter: condition-case: Error response received from websocket server
error in process filter: Error response received from websocket server

The error was raised by websocket-outer-filter at https://github.com/ahyatt/emacs-websocket/blob/master/websocket.el#L789 asynchronously.

IMO, it shuold be possible to handle these errors by using callback, force throwing errors is not so user-friendly.

[ahyatt]

I see - yeah that's a problem. After some investigation, I have a potential fix in the new error-fix branch: 0591322. With this, you should be able to handle an error in whatever you set to on-error. I'm not sure this fix is complete good - it probably should throw if on-error is not set. I'll have to think about that case...

In any case, please try this out and let me know if the solution works for you.

[cireu]

Thanks you, this works for me.

It seems that default error-handler is websocket-default-error-handler, why not just throw the error in that function?

[ahyatt]

Cool, this has been merged into the master branch, along with some other error issues I noticed.

[cireu]

thx for your work