Doesn't check properly if AHK is installed about aspdm

[rshipp]

This check is done here: Make_Install.nsi#L68-L75. Can you post the contents of your InstallDir registry key for AHK, and check whether Autohotkey.exe exists in the specified folder?

[joedf]

@george2 Thanks :)

[joedf]

For reference (download): http://aspdm.tk/client/

[nnnik]

The reg Keys don't exist.
Win 8 -.-

[joedf]

Woah what lol I guess there is a little problem then :P

[nnnik]

You should remove the part with the registry Key then and simply check, if Autohotkey.exe exists in A-ProgramFiles/AutoHotkey if not let the user select a Directory.
I mean all people using this Manager have at least enough Knowledge to do that, or?

[rshipp]

I think checking if the registry keys exists and the file exists at that path would be better than checking a hardcoded path.

[fincs]

BTW: Extracting the ZIP files to Program Files\AutoHotkey doesn't count as "installing AHK". The installer creates registry keys that are not created by merely extracting ZIPs.

[rshipp]

So the question seems to be this: if AutoHotkey is not installed, should we...

• fail and refuse to install the ASPDM client?
• ask the user if s/he has a "portable" AutoHotkey setup (a zip extracted to a folder) and wants to use that?

The second option might be useful in some cases, for example running the client and AutoHotkey from a USB or network drive. What do you guys think?

[joedf]

Well for now..

• If AutoHotkey is not "installed", they can still choose to install ASPDM.
• "Portable" is not currently supported, but might be in the future. Seems interesting and shouldn't be too hard to implement.

Now my question is : What does this registry key not exist on nnnik's computer even with AutoHotkey "installed"? : HKLM\SOFTWARE\AutoHotkey\InstallDir

[ttnnkkrr]

it really depends on what user level is logged in
HKLM may only be available if the user installed as admin rights?
sorry I haven't really been paying attention to any of this but isn't this entire thing a script itself?
if it runs doesn’t that mean there is an AutoHotkey application running?
That key does not exist on my laptop either win7 64 bit
what about using this key instead
HKEY_CLASSES_ROOT\AutoHotkeyScript\Shell\Open\Command

From: Joe DF
Sent: Sunday, June 15, 2014 6:12 PM
To: ahkscript/ASPDM
Subject: Re: [ASPDM] Doesn't check properly if AHK is installed (#7)

Well for now..

a.. If AutoHotkey is not "installed", they can still choose to install ASPDM.
b.. "Portable" is not currently supported, but might be in the future. Seems interesting and shouldn't be too hard to implement.
Now my question is : What does this registry key not exist on nnnik's computer even with AutoHotkey "installed"? : HKLM\SOFTWARE\AutoHotkey\InstallDir

—
Reply to this email directly or view it on GitHub.

[joedf]

I update the verification code. It now checks for both:

• HKLM\SOFTWARE\AutoHotkey\InstallDir
• HKCR\AutoHotkeyScript\Shell\Open\Command

The check passes if at least one of them returns true.
Commit: f810fa0
Download: http://aspdm.tk/client/

[perfaram]

Well, FYI that I installed AHK with the installer as super-admin (this name is confusing, as it is not really a super-admin... anyway, see that for more info : http://thundercloud.net/infoave/new/how-to-create-a-super-admin-account-in-windows-7/)
And I don't have either the AHK key in HKLM or in HKCU

EDIT : I do have it, but in HKLM\SOFTWARE\Wow6432Node\AutoHotkey\InstallDir
This may be an issue related to 64bit (Wow64=Windows 32-bit On Windows 64-bit, it's for compatibility with 32-bit applications)

[joedf]

ok.... Then, ill add a third check. => triple check.
Check for the hardcoded path %Program___Files%/AutoHotkey/Autohotkey.exe

[perfaram]

Just understanding that today, I seem to be prone to say shit : Windows automagically redirects a x86 app looking for something like HKLM\SOFTWARE\AutoHotkey\InstallDir to HKLM\SOFTWARE\Wow6432Node\AutoHotkey\InstallDir
However, you must know that Windows is buggy, and sometimes it doesn't work

[joedf]

Possibly, that is why SetRegView 64 is used.

• Make_Install.nsi#L34-L43
• NSIS Docs: SetRegView

---

3rd Check added:
Commit: 6d5855b
Download: http://aspdm.tk/client

[rshipp]

Just going through my issue backlog... should this one be closed now?

[joedf]

Should... but i never got a response, if the last commit actually fixed it... :P

[joedf]

Ok, I have decided to close this issue due to inactivity.