ahaw / ngx-hideable-header Goto Github PK

Hi, thank you for the library!

I'm getting the following warning from Chrome (Version 70.0.3538.77):

commons-153a668ef205beec2e8f.js:56 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Can there be done anything about it?

Thanks

Hi,

we have found an issue for some browsers and we have investigated that scrolling elements is not widely cupported, yet.

https://developer.mozilla.org/en-US/docs/Web/API/Document/scrollingElement

Can you fix it at line https://github.com/ahaw/ngx-hideable-header/blob/master/src/lib/src/lib/hideable-header.directive.ts#L141
to prevent crashing?

Example setup (based on sentry errors):
Chrome 38.0.2125, Win8
Chrome Mobile WebView 30.0.0, Android 4.4.2
Chrome 43.0.2357, Android 5.1.1
MiuiBrowser 2.0.1, Android 4.4.4
Samsung Internet 3.5, Android 5.1.1

Thanx.