Coder Social home page Coder Social logo

automaton-checklist's People

Contributors

agungsetiawan avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

rkmaul

automaton-checklist's Issues

Refactor to before_action

Some code has duplication find_by_id, e.g.

def edit
  #@project=Project.find(params[:id])
  @project=current_user.projects.find_by_id(params[:id])
   redirect_to root_path unless @project
end

def update
   #@project=Project.find(params[:id])
   @project=current_user.projects.find_by_id(params[:id])
   redirect_to root_path unless @project

   if @project.update_attributes(project_params)
      redirect_to @project
   else
      render 'edit'
    end
end

We can use before_action instead. So You can refactor those code to :

before_action :find_project, only: [:edit, :update]

def edit; end

def update
   if @project.update_attributes(project_params)
      redirect_to @project
   else
      render 'edit'
    end
end

private
  def find_project
     @project = current_user.projects.find_by_id(params[:id])
     if  [email protected]?
         redirect_to root_path 
     end
  end

Something like that.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.