automaton-checklist's People
Forkers
rkmaulautomaton-checklist's Issues
Please fix indentation
Refactor tasks controller
Let's try to find out which part we can simplify the code on tasks_controller.rb
Refactor to before_action
Some code has duplication find_by_id
, e.g.
def edit
#@project=Project.find(params[:id])
@project=current_user.projects.find_by_id(params[:id])
redirect_to root_path unless @project
end
def update
#@project=Project.find(params[:id])
@project=current_user.projects.find_by_id(params[:id])
redirect_to root_path unless @project
if @project.update_attributes(project_params)
redirect_to @project
else
render 'edit'
end
end
We can use before_action
instead. So You can refactor those code to :
before_action :find_project, only: [:edit, :update]
def edit; end
def update
if @project.update_attributes(project_params)
redirect_to @project
else
render 'edit'
end
end
private
def find_project
@project = current_user.projects.find_by_id(params[:id])
if [email protected]?
redirect_to root_path
end
end
Something like that.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.