Coder Social home page Coder Social logo

Comments (7)

InfinityRaider avatar InfinityRaider commented on August 29, 2024

I'm not sure I'm following you here, what exactly do you mean?

from agriplants.

TokkenGmr avatar TokkenGmr commented on August 29, 2024

@InfinityRaider There was a reformat that happened 2 months back that changed the "path" and it no longer matches the "id" of the plant on those 4 JSON files.

from agriplants.

Dilnu avatar Dilnu commented on August 29, 2024

The issue is that in every other plant the file name and the plant id match. The mismatch generates confusion when using them in mutations as has already happened with the botania flower mutations.

from agriplants.

TokkenGmr avatar TokkenGmr commented on August 29, 2024

@Dilnu I'm not sure I follow you on the botania flower mutations, none of them use the tulip flowers. Unless you are setting your JSONs custom? In which case yes there would be an issue, because they weren't used in mutations as far as I can remember.

from agriplants.

InfinityRaider avatar InfinityRaider commented on August 29, 2024

Ok from a consistency point of view this makes sense

from agriplants.

RlonRyan avatar RlonRyan commented on August 29, 2024

Yeah the plant ids could/should be updated... The issue is that it would cause the removal of the old plants...

from agriplants.

CodesCubesAndCrashes avatar CodesCubesAndCrashes commented on August 29, 2024

On the one hand, I'm sure some modpack makers would appreciate having a way to change IDs and keep games saves intact.

On the other hand, this is such a rare occurrence that having special loading code for it seems excessive. And in this particular update, it's for a mod that's still in Alpha.

If it helps, I think that making a note on the changelog warning users that tulips will vanish from crops and their AgriSeeds will be useless is more than adequate for an Alpha.

from agriplants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.