agricraft / agricraft

The source code for the Minecraft mod: AgriCraft

AgriCraft

Agricultural farming extended.

Contact

I have a Discord channel where you can contact me for support/suggestions which you don't think fit on this issue tracker. Also if you want to discuss something with me, this is the place to be!

Supported Versions

AgriCraft has releases for Minecraft versions 1.7.10 and onwards, status per Minecraft version is as follows:

Version	Notes
	No more work will be done on 1.7.10 by InfinityRaider or RlonRyan, if you want to maintain 1.7.10, contact us on Discord
	The 1.8.9 branch was highly experimental and the rendering is one big hack. Don't expect anything.
	Skipped 1.9, as it was an incredibly short-lived release.
	Closed.
	Skipped 1.11.
	Closed.
	Closed.
	Ported and supported

Bug Reports

Please report any and all bugs you might encounter while playing with this mod (this only applies to versions of Minecraft this mod is currently being developed for). Suggestions are also welcome. However before reporting a bug please update to the latest version of the mod to see if it still persists. If you want to post bug reports for older versions, make sure to tell me what version you are using and the version of Forge you are using. If you report a bug and I request more feedback, the label 'Awaiting reply' will be added, if I have had no response for 5 days after adding that label, the issue will be closed.

Technical Documentation

AgriCraft is documented in the official GitHub wiki. Note that this kind of information is, most of the time, only needed by pack creators and not the average user.

Compilation Notes

The latest versions of ForgeGradle require some tweaking to get builds working. The two most important things to note are as follows:

1. ForgeGradle does not like JDKs newer than JDK8. To develop install openjdk8, and update gradle.propeties to contain the following:

org.gradle.java.home = C:\\Program Files\\AdoptOpenJDK\\jdk-8.0.275.1-hotspot

2. The default JVM heap size is too small to handle decompilation of MineCraft. Builds fail without increasing the heap size that Gradle allocates for the build. Update gradle.propeties to contain the following:

# Sets default memory used for gradle commands. Can be overridden by user or command line properties.
# This is required to provide enough memory for the Minecraft decompilation process.
org.gradle.jvmargs=-Xmx3G

Note: We do not provide a default gradle.properties file as it is discouraged by the Gradle documentation, given that the file may contain maven login information and the likes.

agricraft's Issues

User "AgriCrafting" crops of other mods

It would be nice if a user (or more probably mod pack author) could easily add support to crops of unsupported other mods. As far as I can see this would require (additionally over custom settings already possible):

• Identifying the seed item
• Full resource path to the respective textures

On Linux server, config folder is created at config\agricraft\ (wrong slashes)

The config folder is using the wrong slashes on Linux, so it's creating a new directory instead.

MineTweaker3 support

What "recipe types" do we need to support via MineTweaker? Some ideas are:

• CustomWood items (Tank, Channel and Valve)
• Mutations of seeds (config file already in place for this)
• Blacklist seeds trough minetweaker
• Whitelist soils trough minetweaker
• Override spread chances trough minetweaker

I guess this depends highly on the requirements of pack developers.

Limit some seeds to only be plantable on crops on certain soils

I'd like to be able to make it so that some plants will only be able to be planted on crop sticks if the crop sticks are placed on specific soils. One example of this would be nether wart - with what I'm proposing, it would only be possible to place netherwart on the crops if they were on soul sand. Another example would be witchery's Water Artichoke. Normally it can only be planted on water, but in Regrowth I have it only obtainable by a mutation, requiring it to be used with crop sticks, potentially leading people to believe that in a normal environment in would be able to be planted on dirt. This system I'm proposing would let me have it only be be able to be mutated if the crops were placed on the surface of water.
This would allow a more faithful method of allowing such plants to be used with crops and having the benefits of such things, but without the weirdness of planting them on a surface other than initially intended.

Crash when breaking Water Tank

http://paste.feed-the-beast.com/view/65a145c4

Add valve irrigation channels

can be toggled with redstone

No texture particles

When you break Sprinklers the "breaking" particles have no texture (they are pink)

Hunger Overhaul growth ticks

AgriCraft crops grow at normal speed, despite presence of Hunger Overhaul

Sprinkler becomes semi-transparent when Extr. Utils. tank is in foreground

Sprinklers appear semi-transparent if there is an extra utilities tank containing a liquid in the foreground on the screen

Tested with:
Extra Utilities: 1.2.1
Agricraft: 1.1.1

[1.2.2] Issue with netherwart?

While bug hunting for my custom crops I found this line in the logs, something seems to be wrong...

 [AgriCraft]: Error when reading mutation: first parent stack is not correct (line: AgriCraft:seedShroomRed=minecraft:nether_wart+AgriCraft:seedPoppy)

The respective line was C&Pd from the default mutations file I generated after the upgrade, but I also don't see anything wrong with the line. Not sure what's going on there.

Breaking Seed Analyzer doesn't drop it's contents

After ~15 hours of play seed mutations have vanished from the right-hand pages in the Agricultural Journal. I've tried adding and removing the few mods that were added afterward, to no affect (going so far as to scan more seeds of different types to see if it would repopulate).

Decouple markDirty and markBlockForUpdate in AgriCraft TileEntities

As we have reduced the amount of calls to markDirty for improved rendering. (Really we decreased the amount of calls to makrBlockForUpdate), Waila wont show correct (actual) fluid levels anymore.

For 1.3 we should decouple re-rendering of Blocks and updating of TileEntities for the Client.

Crops not producing item when mature w/Hunger Overhaul

crops when clicked do not produce an item when Hunger overhaul is installed.

EG: Wheat when full grown will not drop a wheat item or seeds when clicked.

Hunger Overhaul adds a mechanic which allows crops to be right clicked when fully grown to harvest and replant. Hunger Overhaul is often paired with harvest craft.

Add Soil information to NEI Handler or tooltip

Currently it can be quite hit and miss figuring out what soil a crop may require, especially in the case of more ambiguous options such as sugarcane. This could probably be alleviated by adding soil information to the existing NEI handler or to a tooltip (possibly even requiring analysis?)

config directory on linux

Hi,

on linux your mod creates a directory with the name "config\agricraft", it should be "config/agricraft/"

Flower without fruit.

Before this update we were adding flower which was giving no fruit.
It turns out that after config parsing improvements it is not longer possible.

Error when adding custom crop: Invalid fruit (line: vitaTherionis,minecraft:air,minecraft:soul_sand,2,6,It Give Nothing You Filthy Mothercoder!)

Is there any way to create flower giving nothing?

Seed Storage

Elegant way to store seeds of different kinds/stats

Shift clicking crop blocks

If you shift click a crop block it crashes the game

[Feature Request][Compatibility]Have vanilla style farming work with Garden-Stuff's tilled Garden Soil

Basically just what the title says. Currently it is possible to plant seeds on the tilled Garden Soil without crop sticks despite the vanilla farming being disabled.

Wooden Irrigation Channels Recipe Conflict

FYI, the recipe for your wooden irrigation channels conflicts with vanilla wooden bowls.

Console warning when server starts

[01:54:49] [Server thread/INFO]: Starting minecraft server version 1.7.10
[01:57:15] [Server thread/INFO]: Loading properties
[01:57:15] [Server thread/INFO]: Default game type: SURVIVAL
[01:57:15] [Server thread/INFO]: Generating keypair
[01:57:16] [Server thread/INFO]: Starting Minecraft server on *:25565
[01:58:33] [Server thread/INFO]: Preparing level "world"
[01:58:54] [Server thread/INFO]: Preparing start region for level 0
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Failed Piece with id AgriCraft:Greenhouse
[01:58:54] [Server thread/WARN]: Skipping Piece with id AgriCraft:Greenhouse
[01:58:55] [Server thread/INFO]: Preparing spawn area: 1%
[01:58:56] [Server thread/INFO]: Preparing spawn area: 23%
[01:58:57] [Server thread/INFO]: Preparing spawn area: 59%
[01:58:58] [Server thread/INFO]: Preparing spawn area: 95%

This is not critical and nothing seems to be broken, it just seems suspicious and I thought I'd bring it up.

Unable to place crops

Just grabbed the new version, 0.0.10, and unfortunately still have a random problem placing crops on tiled soiled. If I wait awhile and come back, I'm eventually able to place them. Sometimes not. So far I haven't been able to detect any specific reason for this. At first I thought it was happen right after breaking crops but it even happens on freshly tiled soil.

Using Forge 1240 and this is running on a server (not LAN).

Thanks!

Water Tanks refill from rain underground

AgriCraft v0.0.12
Forge v10.13.2.1231

The water tanks seem to fill up while raining regardless of their position or line-of-sight to the sky.

Tanks collect water when raining in the desert.

Kind of weird.

Issues with village pieces

It causes crashes in Mystcraft ages and warnings on server starting (#61)

Seed Duplication bug with Seed Analyzer

Shift-clicking a seed to remove it from the analyzer while it is being processed will result in twice as many seeds being returned to the players inventory. Caps out at returning a stack. Occurs specifically with either a shift-left click or shift-right click. Occurs independent of presence of journal in the analyzer.

Cactus crops dropping Cactus Green instead of Cactus (v1.2.2)

Regrowth modpack v0.6.3.

Let me know if you need any more info.

Gardening Trowel text

It says:
"Use this to move plants from one CORP to another"

Dupe bug in 0.0.9

Duplicate 'crops' stick now drop when collecting mature crops. The original crop sticks remain in place. (I have hunger Overhaul Installed)

Note: Duplication only happens when there is an item in the hand when you click the crops

Whitelist fertile soils

Add a config option to whitelist blocks as fertile farmland which can sustain crops.

Mutations from two identical seeds show up twice in the journal

Irrigation channel bounds

Even when connected their bounds are the same as a single irrigation channel block. So in the middle of two connected channels, you can hit the block behind.

Water Tanks / Irrigation Channel - Extra Utilities Wood

Hey,

there is a render issue with Water Tanks / irrigation Channels based on ExtraUtilities Planks.
See screenshot: http://imgur.com/ZB50WSf

Cant plant analysed seed on farmland

I planted a carrot seedon soil block, but could not plant an analysed carrot seed.

This aplies to other seeds

Crafting valves doesn't transfer the nbt correctly

Botania flower crops not dropping flowers (v1.2.2)

I am playing the Regrowth modpack v0.6.3 which updated to AgriCraft 1.2.2. I made white, yellow, red, blue, and black mystical flowers and none of them drop flowers when right-clicking the crops. Breaking them drops seeds and only seeds. I created the flowers from the parent crops I had made with the previous version so they all had stats of 10/10/10 which gave the botania seeds the same stats. Just mentioning that in case it matters. Let me know if you need any other information.

missing texture

I added own crop:

saxilliaZbendata,minecraft:cobblestone,minecraft:cobblestone,1,6,It give cobblestone! 

In book cobblestone has missing texture:
https://dl.dropboxusercontent.com/u/25172450/bugs/0a6640111ef7bd9261b457423cf2f438.png

Valve Item Rendering

Check configs for errors when reading

Add code to see if user added mutations/crops/whatever is defined correctly to prevent crashes.

[1.2.2] custom soils can be defined, but not used

You can define a custom soil in SoilWhitelist.txt, but trying to use it in CustomCrops.txt leads to an error:

[AgriCraft]: Error when adding custom crop: Invalid soil: soil should be null, minecraft:sand, minecraft:soul_sand or minecraft:mycelium (line: chrysalis,DCsAppleMilk:defeatedcrow.condensedMilk:5,minecraft:glass,null,3,1,A magical flower with fragile crystalline stem and leaves)

(Yes, glass is defined in SoilWhitelist.txt)

Make the custom crops use any specific soil

Irrigation System cause lag.

Irrigation System cause lag because on each tick they cause a re-render of the whole chunk because of changes in the buffer. Rendering of tanks and channels should be split into two renderers. The wooden frames should be rendered as ISBRH and water as TESR.

Refactoring hot spots

This is a running TODO list of all the places which need some refactorings badly. Prefer editing this post compared to additional comments.

• Recipes: CustomWood recipe registration has lots of duplicated code
• CustomWood (MineTweaker3): duplicated code in addShapless and addShaped
• Seed blacklist and soil whitelist are nearly identical
• NBTHelper does manual sorting

More option for produce

I'd like to have more options for the produce of custom crops

• More than one different item
• Probability (eg crop that always gives item A, but has a rare chance to give item B as well, like for example the Witchery Snowbell). Could also allow for cases where you want plentiful produce. I Imagine a syntax similar to Minetweaker, like mincraft:clay * 2;minecraft:clay * 0.5;minecraft:clay * 0.1
• NBT data (maybe through #42 as MineTweaker already has a syntax for that)

Allow mid-file comments for custom crops.

It would allow grouping custom crops in config.

Water block not flowing

Whe you break a full water tank, it spawns a water block that doesnt flow.

Exception with NEI

Hi,

i get the following Exception, and NEI is not working after installing this mod.
(list of my mods: http://pastebin.com/4xmFZGH2)

[B#439] java.lang.ClassCastException: gregtech.common.items.GT_MetaGenerated_Item_01 cannot be cast to net.minecraft.item.ItemBlock
[B#439] at com.InfinityRaider.AgriCraft.utility.NBTHelper.getMaterialTag(NBTHelper.java:14) ~[NBTHelper.class:?]
[B#439] at com.InfinityRaider.AgriCraft.items.ItemBlockCustomWood.addMaterialToList(ItemBlockCustomWood.java:81) ~[ItemBlockCustomWood.class:?]
[B#439] at com.InfinityRaider.AgriCraft.items.ItemBlockCustomWood.func_150895_a(ItemBlockCustomWood.java:60) ~[ItemBlockCustomWood.class:?]
[B#439] at codechicken.nei.api.ItemInfo.searchItems(ItemInfo.java:364) ~[ItemInfo.class:?]
[B#439] at codechicken.nei.api.ItemInfo.load(ItemInfo.java:97) ~[ItemInfo.class:?]
[B#439] at codechicken.nei.NEIClientConfig.bootNEI(NEIClientConfig.java:258) ~[NEIClientConfig.class:?]
[B#439] at codechicken.nei.NEIClientConfig.loadWorld(NEIClientConfig.java:208) ~[NEIClientConfig.class:?]
[B#439] at codechicken.nei.NEICPH.handleSMPCheck(NEICPH.java:109) [NEICPH.class:?]
[B#439] at codechicken.nei.NEICPH.handlePacket(NEICPH.java:23) [NEICPH.class:?]
[B#439] at codechicken.lib.packet.PacketCustom$ClientInboundHandler.handle(PacketCustom.java:98) [PacketCustom$ClientInboundHandler.class:?]
[B#439] at codechicken.lib.packet.PacketCustom$CustomInboundHandler.channelRead0(PacketCustom.java:75) [PacketCustom$CustomInboundHandler.class:?]
[B#439] at codechicken.lib.packet.PacketCustom$CustomInboundHandler.channelRead0(PacketCustom.java:62) [PacketCustom$CustomInboundHandler.class:?]
[B#439] at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) [SimpleChannelInboundHandler.class:?]
[B#439] at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [DefaultChannelHandlerContext.class:?]
[B#439] at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [DefaultChannelHandlerContext.class:?]
[B#439] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:?]
[B#439] at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:?]
[B#439] at cpw.mods.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:77) [FMLProxyPacket.class:?]
[B#439] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212) [ej.class:?]
[B#439] at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(SourceFile:78) [bcx.class:?]
[B#439] at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1650) [bao.class:?]
[B#439] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:962) [bao.class:?]
[B#439] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:887) [bao.class:?]
[B#439] at net.minecraft.client.main.Main.main(SourceFile:148) [Main.class:?]
[B#439] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_71]
[B#439] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_71]
[B#439] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_71]
[B#439] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_71]
[B#439] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.11.jar:?]
[B#439] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.11.jar:?]

Water dissappears from irrigation systems

Under certain conditions water drains perpetually from a closed off irrigation system.

Add nearby block requirements in NEI handler

Bounding box on crops is full block

Bug/Enhancement request: When I plant a seed from Agricraft on tilled soil the bounding box is a full block when most plants are shorter to allow planting multiple seeds. The seeds should have the same size box as vanilla seeds to facilitate planting.