The frodo from agnivade

frodo's People

Contributors

Stargazers

Watchers

frodo's Issues

incorrect passing of Go pointers to C code

The golang doc says

C code may store Go pointers in C memory, subject to the rule above: it must stop storing the Go pointer when the C function returns.

however in this line

frodo/frodo.c

Line 105 in 55a39bb

fi->iovecs[0].iov_base = data;

you store the pointer from the golang buffer in a struct that is passed to io_uring systerm calls which will access the data buffer long after the push_write_request function returns.

int push_write_request(int file_fd, void *data, off_t file_sz) {
    struct file_info *fi = malloc(sizeof(*fi) + (sizeof(struct iovec) * 1));
...
    fi->iovecs[0].iov_base = data;
...
    io_uring_sqe_set_data(sqe, fi);
    return 0;
}

while this may work in some cases where the gc doesnt run till the file is written to, it is very possible that the gc runs after this call to push_write_request and relocates the data buffer to a whole different address. in fact for the zeroBytes buffer case

frodo/frodo.go

Line 173 in 55a39bb

zeroBytes := []byte("")

the gc may completely destroy slice since there are no references to it past the push_write_request call

Recommend Projects

agnivade / frodo Goto Github PK

frodo's People

Contributors

Stargazers

Watchers

Forkers

frodo's Issues

incorrect passing of Go pointers to C code

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent