afup / haphpy-birthday Goto Github PK

Tried sending a highres logo to the mentioned email and its being rejected.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Since constraints have been added to image uploaded (not on videos), user is noticed about what is wrong with his picture but one error at a time. This could be annoying.

It should be better to display all errors at once so user can edit his picture straight to good specs.

Currently Gauge level is calculated on users contributions.

It needs to be changed to include PUGs as well.

Now the demo environment is set up on afup server, the link http://haphpy-birthday.net can be added to the documentation and replace the deprecated http://haphpy-birthday.woecifaun.net .

If someone is authenticated and has submitted a contribution already, replace the form by a button to delete the contribution.

⚠️ Starting to work on this issue? please indicate it in a comment below.

When logging in the VM, one is located in /home/vagrant. It should be cool to cd /vagrant automatically, avoiding to do it manually each time.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

On the contribution preview page (http://haphpy-birthday.net/en/contribution/t/Woecifaun), add a simple system to report issue with the contribution.

It could be

• a simple link Report an issue with this contribution
• displaying a simple textarea and a submit button.
• a Captcha preventing spam
• an explanation about moderation and what will (or not) be done

Ideas on the fly:

• No email address required. People wanting to be contacted back can add it in the message.
• Better inform user that the request will be handled but the decision is remains HaPHPy Birthday's team.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Following the use of Sass, there was probably some CSS breaks:

• The page for confirmation of submission is broken
• PHP User group list broken when a group name spans on multilines
• The Gauge is not animated anymore on Firefox
• Anonymous/public choice radio button aligment is broken

• Add translated description and keyword meta elements.
• Handle robots.txt.

Like the authentication through GitHub, it should be possible to authenticate with a Facebook account.

Even if PHP 7 is still in beta, I think it's on projects like this one we should try it.

What do you think?

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Find a way to improve the Twitter account visibility in order to have more people following it.

Add the Haphpy Logo to README.md

⚠️ Starting to work on this issue? please indicate it in a comment below.

Set up Sass

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

A custom 404 page needs to be created.

⚠️ Starting to work on this issue? please indicate it in a comment below.

To make people understand they are on a temporary/demo app, a demo label or sign should be displayed in the header.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

When user contributes, s·he redirected to the /en/thanks page. The background video is not positionned top/left in order to cover the whole real estate in iOS safari (at least).

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

The radio buttons layout on Google Chrome and Safari is lame.

Chrome : the second button is smaller.

Safari : radio label is underneath. It should be aside.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Currently, if someone knows the auth provider (e.g. GitHub, Facebook or Twitter) and the unique identifier of a contributor, s·he can rebuild the route to see the contribution.

When the contribution is anonymous page to contribution {locale}/contribution/{authoProviderId}/{identifier} must return a 404 HTTP code to every user but the contributor and admins.

⚠️ Starting to work on this issue? please indicate it in a comment below.

Uploaded pictures should be:

• of PNG or JPG format
• 1920 × 1080 pixels size

When a user (is authenticated and) has already uploaded a contribution, display its contribution instead of the form.

This issue is complementary of #40 and can create conflict with it.

• Contributions are located out of the web zone. So a special route to retrieve them should be created.
• Uploaded pictures should be ok.
• Uploaded pictures can be problematic depending on the video codec (that could not be playable by browser).

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment.

The form is currently available whatever the date is.

It should not be accessible anymore after the limit date set in the parameters.yml is over (Neither the submission process in the controller).

Add a switch for example in the menu allowing user to switch to a preferred language.

On the contributions page, the user groups list appears before the contributors list. Scroll (that can be long) is annoying to reach the second list.

• Add tabs or menu to switch easily from one list to another.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

When user already contributed, the delete button appears. It points to the / of the website with no locale.

It should go to the localized home page.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Uploaded video from Apple devices are not readable on Google Chrome and buggy on Apple Safari. Not tested on Internet Explorer or Opera.

Hint: The mimetype of an uploaded video had to be forced to video/mp4 when extension is .qt.
See here: https://github.com/afup/haphpy-birthday/blob/master/src/AFUP/HaphpyBirthdayBundle/HttpFoundation/File/File.php#L19

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Since Sass has been set up, the https://github.com/afup/haphpy-birthday/blob/master/docs/install.md is outdated.

Sass instruction on how to dump assets & build CSS can be found in @agallou Pull Request: #102

At the end of composer install, I have an error:

Script ./bin/robo install handling the post-install-cmd event returned with an error

  [RuntimeException]                                                                                                                                                           
  Error Output:                                                                                                                                                                

    [Exception]                                                                                                                                                                
    Undefined mixin transform: failed at `@include transform(translate(-50%, -50%));` src/AFUP/HaphpyBirthdayBundle/Resources/assets/sass/modules/_exemples.scss on line 40

Like the authentication through GitHub, it should be possible to authenticate with a Twitter account.

Currently, the project uses a version of coke, php code sniffer and symfony coding standard below version 2.

I tried to updated it and bumped into a conflict.

😞 I didn't save the thrown error in the terminal.

Launch coke/phpcs on travis.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

In order to improve communication via Twitter by adding photos, it should be great to add Twitter card to:

• home page
• contribution page

https://dev.twitter.com/cards/overview

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

When contribution amount is over the top marker, the gauge should adapt to show overloaded contribution amount too, shifting proportionally marker to the left.

⚠️ Starting to work on this issue? please indicate it in a comment below.

Change favicon to replace symfony one.

⚠️ Starting to work on this issue? please indicate it in a comment below.

The first contribution on the demo website seemed to be a hoax.

It should be good to have a kind of a moderation admin for specific users.

As well, a message saying to the user its contribution will be moderated or has been rejected/accepted.

Add footer to page with:

• GitHub link
• Anything relevant

Get footer style from http://jeremyfagis.github.io/ElaoStrap/docs/index.html

Add a simple system to have statistics.

from http://haphpy-birthday.dev/app_dev.php/en/ (local install) when clic to github authentication I am redirected to http://haphpy-birthday.woecifaun.net/login/

⚠️ Starting to work on this issue? please indicate it in a comment below.

On the contributions page, there is a list of non anonymous contributors.

It should be great to have each contributor clickable to the related account: GitHub repo, Twitter account…

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks

Biggest files could be around 25MB.

For dev & prod, the max upload file size needs to be increase to 25MB.

Check for:

• HTTP server limitation
• PHP limit
• App limit

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

Currently contribution is private and can be seen uniquely by its author.

A new page should be created to display the contribution of a user. The route should be something like /<locale>/contribution/g/<identifier>.

When connecting via Facebook, the user encounters the following error:

The app needs to be registered as active in the Facebook account.

⚠️ Starting to work on this issue? Please indicate it in a comment below to prevent many people working on same stuff at the same moment. Thanks.

When user wants to authenticate, s·he is redirected to the home page. s·he will need to scroll down to the form again. The success redirection should go straight to the #contribute section.

When first connected to the website, it's not clear what the purpose of the project is. Moreover, the user is asked to authenticate to GitHub without knowing exactly why.

• Make the page more self explanatory
• Improve form to smooth the submission process