afs / fuseki-mods Goto Github PK

We are using a jar bundle of jena-fmod-ui and with a recent upgrade the UI fails to start and we see the following log message during fuseki-main startup:

fuseki-1  | [2024-03-08 01:45:41] Config     WARN  Can't locate the UI static resources

The following commit broke lookup of the webapp folder in the jar's classpath.

72deab5#diff-b48a62870a93095fe962ba06dc3469fabe84e78ace1858017f39f2bdc19c73feL74

The fix is to use:

uiApp = ResourceFactory.root().newClassLoaderResource(resourceNameUI);

Perhaps a better fix is to perform the lookup for the webapp resource on the file system first and then fall back to the classpath.

As a note:
newClassLoaderResource(resource) calls newClassLoaderResource(resource, true) which calls newClassLoaderResource(String resource, boolean searchSystemClassLoader)

I am not sure whether its necessary to also search in the system class loader.
But resource lookups in different setups are somewhat arcane, so I'd think searching in one place too many is more useful than searching in one too few.