afnetworking / afoauth1client

AFNetworking Extension for OAuth 1.0a Authentication

AFOAuth1Client

AFOAuth1Client is an extension for AFNetworking that simplifies the process of authenticating against an OAuth 1.0a provider.

Usage

NSURL *baseURL = [NSURL URLWithString:@"https://twitter.com/oauth/"];
AFOAuth1Client *OAuth1Client = [[AFOAuth1Client alloc] initWithBaseURL:baseURL
                                                                   key:@"..."
                                                                secret:@"..."];

Register your application to launch from a custom URL scheme, and use that with the path /success as your callback URL. The callback for the custom URL scheme should send a notification, which will complete the OAuth transaction.

NSURL *callbackURL = [NSURL URLWithString:@"x-com-YOUR-APP-SCHEME://success"];
[OAuth1Client authorizeUsingOAuthWithRequestTokenPath:@"/request_token"
                                userAuthorizationPath:@"/authorize"
                                          callbackURL:callbackURL
                                      accessTokenPath:@"/access_token"
                                              success:^(AFOAuth1Token *accessToken) {
                                                  NSLog(@"Success: %@", accessToken);
                                              }
                                              failure:^(NSError *error) {
                                                  NSLog(@"Error: %@", error);
                                              }];

Responding to the custom URL scheme on iOS:

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)URL
  sourceApplication:(NSString *)sourceApplication
         annotation:(id)annotation
{
    NSNotification *notification =
        [NSNotification notificationWithName:kAFApplicationLaunchedWithURLNotification
                                      object:nil
                                    userInfo:@{kAFApplicationLaunchOptionsURLKey: URL}];
    [[NSNotificationCenter defaultCenter] postNotification:notification];

    return YES;
}

Contact

Mattt Thompson

• http://github.com/mattt
• http://twitter.com/mattt
• [email protected]

License

AFOAuth1Client is available under the MIT license. See the LICENSE file for more info.

afoauth1client's Issues

acquireOAuthRequestTokenWithPath: method should check for oauth_error_message string in response

An OAuth client I am using sends errors back within the success block of acquireOAuthRequestTokenWithPath:.... Should we just check for an occurrence of the oauth_error_message string then return an error if it is found?

Warnings when using 0.3.3 with Xcode 5.0.2 and iOS SDK 7

AFOAuth1Client.m:680:70: Undeclared selector 'renewable'

Both iOS and Mac OS X Twitter example fail in the OAuth process!

Twitter returns : " Failure: Failed to validate oauth signature and token"

I'm trying to use OAuth on another webservice that Twitter and get the same error....

So basically, the OAuth mechanism of AFNetworking does not work as expected :(

Error trying to get Home Timeline

I am using AFOAuth1Client in order to Authenticate and then retrieve the Home Timeline of a given Twitter User. However when I run my code I get this error:

Error Domain=AFNetworkingErrorDomain Code=-1011 "Expected status code in (200-299), got 403" UserInfo=0x7fe160ca0070 {NSLocalizedRecoverySuggestion={"errors":[{"message":"Your credentials do not allow access to this resource","code":220}]}, NSErrorFailingURLKey=https://api.twitter.com/1.1/statuses/home_timeline.json, AFNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest: 0x7fe160ca88c0> { URL: https://api.twitter.com/1.1/statuses/home_timeline.json }, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x7fe160dad9b0> { URL: https://api.twitter.com/1.1/statuses/home_timeline.json } { status code: 403, headers {
    "Content-Encoding" = deflate;
    "Content-Length" = 94;
    "Content-Type" = "application/json;charset=utf-8";
    Date = "Wed, 31 Dec 2014 20:19:49 UTC";
    Server = "tsa_b";
    "Set-Cookie" = "guest_id=v1%3A142005718900451202; Domain=.twitter.com; Path=/; Expires=Fri, 30-Dec-2016 20:19:49 UTC";
    "Strict-Transport-Security" = "max-age=631138519";
    "x-connection-hash" = 2a42433adec68c7f4e4410d0df3e6713;
    "x-response-time" = 5;
    "x-spdy-version" = "3.1-NPN";
} }, NSLocalizedDescription=Expected status code in (200-299), got 403}

Here is how I am attempting to Authenticate:

SettingsViewController.m

- (void)authenticateWithTwitter  {
    self.twitterClient = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:@"https://api.twitter.com/"]
                                                             key:@"XXXXXXXXXXXX"
                                                          secret:@"XXXXXXXXXXXX"];

    [self.twitterClient authorizeUsingOAuthWithRequestTokenPath:@"oauth/request_token"
                                          userAuthorizationPath:@"oauth/authorize"
                                                    callbackURL:[NSURL URLWithString:@"floadt://success"]
                                                accessTokenPath:@"oauth/access_token"
                                                   accessMethod:@"GET"
                                                          scope:nil
                                                        success:^(AFOAuth1Token *accessToken, id response) {
                                                            [AFOAuth1Token storeCredential:accessToken withIdentifier:@"TwitterToken"];
                                                            [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@"twitterActive"];
                                                            [[NSUserDefaults standardUserDefaults] synchronize];
                                                        } failure:^(NSError *error) {
                                                            NSLog(@"Error: %@", error);
                                                        }];
}

StreamViewController.m

-(void)fetchTweets {
    AFOAuth1Token *twitterToken = [AFOAuth1Token retrieveCredentialWithIdentifier:@"TwitterToken"];
    [self.twitterClient setAccessToken:twitterToken];

    self.twitterClient = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:@"https://api.twitter.com/1.1/"] key:@"XXXXXXXXX" secret:@"XXXXXXXXXX"];

    [self.twitterClient registerHTTPOperationClass:[AFJSONRequestOperation class]];
    [self.twitterClient getPath:@"statuses/home_timeline.json" parameters:nil success:^(AFHTTPRequestOperation *operation, id responseObject) {
        NSArray *responseArray = (NSArray *)responseObject;
        NSLog(@"Response: %@", responseObject);
        [responseArray enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop) {
            tweets = responseArray;
        }];
        [self.tableView reloadData];
    } failure:^(AFHTTPRequestOperation *operation, NSError *error) {
        NSLog(@"Error: %@", error);
    }];
}

oauth_signature in authorizationHeaderForMethod: parameters error when add body

I'm using AFOAuth1Client fore read and create products in Magento.

Well, i have a NSDictionary of product properties; This is the body of the request.

I'm calling the method:

- (void)postPath:(NSString *)path
      parameters:(NSDictionary *)parameters
         success:(void (^)(AFHTTPRequestOperation *operation, id responseObject))success
         failure:(void (^)(AFHTTPRequestOperation *operation, NSError *error))failure

where the parameters argument is the dictionary above.

When AFOAuth1Client execute the method

- (NSString *)authorizationHeaderForMethod:(NSString*)method
                                      path:(NSString*)path
                                parameters:(NSDictionary *)parameters

it sets the oauth_signature calling the method OAuthSignatureForMethod... like below.

    [mutableAuthorizationParameters setValue:[self OAuthSignatureForMethod:method path:path parameters:mutableParameters token:self.accessToken] forKey:@"oauth_signature"];

The issue is that the mutableParameters object, passed like "parameters", is not correct (it contains the oauth_ and the products key/value properties).

If you replace mutableParameters with mutableAuthorizationParameters (mutableAuthorizationParameters contains only the oauth_ key/value properties) it will works perfectly.

issue with XING api

Hi Mattt, I can't call XING api with AFOauth1 (ex: https://api.xing.com/v1/users/user_id.json), for some reason oauth_signature generated by AFOAuth1Client doesn't match value expected by XING.

Goodreads API failure and some workaround findings

I'm having troubles using AFOAuth1Client, specifically the access_token piece. Goodreads is Oauth 1, not 1a if that makes a difference.

They suggest using the OAuthConsumer code which does work - I was able to look at that to determine what some of the differences were between requests generated between the two libraries.

I only have a hacked and working version of this but not a clean code implementation. (It certainly doesn't take into account how compatible this might be with other OAuth1 access_token requests either.)

But this what I've found so far - I'll comment on this further as I find out more.

1. Their access_token request is a GET not a POST
2. The access_token request construction code should only have the oauth_token query param.

 - (void)acquireOAuthAccessTokenWithPath...
{
    // GOODREADS HACK CHANGE
    //NSMutableDictionary *parameters = [[self OAuthParameters] mutableCopy];
    NSMutableDictionary *parameters = [[NSMutableDictionary alloc] init];

3. Then I add the [OAuthParameters] to the mutableParams dict once we're creating the URLRequest

// GOODREADS HACK CHANGE
// new method adapted from AFOAuth1Client.requestWithMethod
- (NSMutableURLRequest *)requestForAccessTokenWithMethod:(NSString *)method
                                          path:(NSString *)path
                                    parameters:(NSDictionary *)parameters
                                    requestToken:(AFOAuth1Token *) requestToken
{
    NSMutableDictionary *mutableParameters = parameters ? [parameters mutableCopy] :          [NSMutableDictionary dictionary];
    // GOODREADS HACK CHANGE
    [mutableParameters addEntriesFromDictionary:[self OAuthParameters]];

4. The OAuth signature creation code has 2 differences:

1. The request token secret is used in conjunction with the application secret.
2. The query param in this case oauth_token is included with the authorization params. In this instance, the request string used in the OAuth sig contains "oauth_token" twice -

GET&http%3A%2F%2Fwww.goodreads.com%2Foauth%2Faccess_token&oauth_consumer_key%3D[consumerKeyValue]%26oauth_nonce%3D9383CF2A-D611-4C93-9B6E-F3B0D6E77A3E%26oauth_signature_method%3DHMAC-SHA1%26oauth_timestamp%3D1359649280%26oauth_token%3DEzn4noEYUA3aCWrQL99Q%26oauth_token%3DEzn4noEYUA3aCWrQL99Q%26oauth_version%3D1.0

I did create an alternate signature method that does this - I can post my hacked version of AFOAuth1Client if you'd like...but I can't say it's pretty ;)

To support multiple server endpoints fo steps of authorizing

For example, Dropbox use api.dropbox.com for request_token and access_token, but www.dropbox.com for authorize.

isExpired check

Right now token expiration is checked this way:

 [self.expiration compare:[NSDate date]] == NSOrderedDescending;

Which, if I'm not mistaken, means (expiration > now), while it should be (expiration < now) because we want to test if token expires at a date in the future?

Updating to newest version of AFNetworking

I tried updating AFNetworking in the folder but it gives me a compiling error. to v.1.3

Make expiration a public property?

I'm wondering if expiration should be a public property. This is coming up as I'm serializing the parameters so I can recreate my auth'd sessions when leaving and returning to the app, using this to reinstate my AFOAuth1Client:

- (id)initWithKey:(NSString *)key
           secret:(NSString *)secret
          session:(NSString *)session
       expiration:(NSDate *)expiration
        renewable:(BOOL)canBeRenewed;

It's minor, but maybe there's a good reason it's not already.

Token request call uses "GET" even if accessMethod is set to "POST"

Hi, I am working with an oauth provider that uses POST for request token API. Here is how I am using AFOAuth1Client to make a request:

    self.client = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:SERVER_URL] key:kOAuthKey secret:kOAuthSecret];
    self.client.oauthAccessMethod = @"POST";

[self.client authorizeUsingOAuthWithRequestTokenPath:@"api/auth/v1/oauth/token/request" userAuthorizationPath:@"/services/api/auth" callbackURL:[NSURL URLWithString:@"MYURL://success"] accessTokenPath:@"/api/auth/v1/oauth/token/access" accessMethod:@"POST" scope:@"" success:^(AFOAuth1Token *accessToken, id responseObject) {

        [SVProgressHUD dismiss];

    } failure:^(NSError *error) {

        [SVProgressHUD dismiss];
        [UIAlertView showErrorWithMessage:error.localizedDescription handler:nil];

    }];

The problem is, I see that the initial request to request token is triggered as a GET request, instead of POST. Any ideas what's going on?

How can you tell if AFOAuth1Client has already been previously authenticated?

getSatisfaction API fails to authenticate

The authorization process fails in "authorizeUsingOAuthWithRequestTokenPath" although I can see an access token in the "kAFApplicationLaunchOptionsURLKey" value.

Here's a sample project:
http://cl.ly/2Y340z390u2a

Thoughts on what's wrong?

-requestWithMethod:path:parameters: with 'GET' method fails in version 0.3.0

I updated AFOAuth1Client to 0.3.0 and find my program failed with signature error from server. I tried to diagnose the problem today and found the cause is reversion 6bda44463131755f4a7d88e86d718a67c622dc5f.

The method checks if Content-Type header is application/x-www-form-urlencoded to decide whether the parameter argument is used for signature. And since it is not set for GET method, authorizationParameters is always nil, hence the signature is always wrong.

I've read RFC 5849, Section 3.4.1.3.1, and I believe the author missed the first item:

The query component of the HTTP request URI as defined by
[RFC3986], Section 3.4. The query component is parsed into a list
of name/value pairs by treating it as an
"application/x-www-form-urlencoded" string, separating the names
and values and decoding them as defined by
[W3C.REC-html40-19980424], Section 17.13.4.

I'm not sure what's the correct way to fix, hence I'll let the author to worry about it.

No visibile interface error.

/AFOAuth1Client/Twitter iOS Example Client/Twitter iOS Example Client/AppDelegate.m:41:6: No visible @interface for 'AFOAuth1Client' declares the selector 'authorizeUsingOAuthWithRequestTokenPath:userAuthorizationPath:callbackURL:accessTokenPath:accessMethod:success:failure:'

The name of the methods was changed in
'authorizeUsingOAuthWithRequestTokenPath:userAuthorizationPath:callbackURL:accessTokenPath:accessMethod:_scope:_success:failure:

Last request is executed when switching from WIFI to 3g or vice versa

I've nearly finishing my application which is Rails API interfacing,I've noticed that the last network request is executed again when switching from 3G to WiFi or vice versa.
Here is an example of HTTP request and JSON response parsing

-(void)getServerData{
    __block NSError *error = nil;
    __block NSMutableDictionary *JSON;
    MBProgressHUD* progressHUD = [MBProgressHUD showHUDAddedTo:self.view animated:MBProgressHUDAnimationZoom];
    AFHTTPRequestOperationManager *manager = [AFHTTPRequestOperationManager manager];
    [[AFNetworkReachabilityManager sharedManager] setReachabilityStatusChangeBlock:^(AFNetworkReachabilityStatus status){
        progressHUD.labelText = @"Fetching Data";

        NSDictionary *parameters = @{@"id": [share auth_token]};
        [manager POST:[NSString stringWithFormat:@"%@%@", SERVERURI , DATAURL] parameters:parameters
              success:^(AFHTTPRequestOperation *operation, id responseObject) {
                  JSON = [NSJSONSerialization JSONObjectWithData: [operation.responseString dataUsingEncoding:NSUTF8StringEncoding] options:NSJSONReadingMutableContainers error: &error];
                  //Door Names array filling
                  doorsData = [JSON objectForKey:@"data"];
                  [self.tableView reloadData];
                  [MBProgressHUD hideHUDForView:self.view animated:YES];
              }
              failure:^(AFHTTPRequestOperation *operation, NSError *error) {
                  JSON = [NSJSONSerialization JSONObjectWithData: [operation.responseString dataUsingEncoding:NSUTF8StringEncoding] options: NSJSONReadingMutableContainers error: &error];
                  UIAlertView *notPermitted = [[UIAlertView alloc]
                                               initWithTitle:@"Error"
                                               message: [JSON valueForKey:@"message"]
                                               delegate:nil
                                               cancelButtonTitle:@"Back !"
                                               otherButtonTitles:nil];
                  // shows alert to user
                  [notPermitted show];
                  [MBProgressHUD hideHUDForView:self.view animated:YES];
              }];
      }];
    [manager.reachabilityManager startMonitoring];
}

I cannot find similar issue after searching , so can anyone help with that?!

Wrong sort order for AFHMACSHA1Signature

The OAuth RFC standard states in 3.4.1.3.2:

1. The parameters are sorted by name, using ascending byte value ordering. If two or more parameters share the same name, they are sorted by their value.

AFHMACSHA1Signature sorts the parameters case insensitive which is not ascending byte value ordering. You should use case sensitve ordering instead:

NSString *queryString = AFPercentEscapedQueryStringPairMemberFromStringWithEncoding([[[[[request URL] query] componentsSeparatedByString:@"&"] sortedArrayUsingSelector:@selector(compare:)] componentsJoinedByString:@"&"], stringEncoding);

If you for example use OAuth with the SmugMug photo service, most API functions work fine, but the smugmug.albums.create function is not working correctly with AFOAuth1Client because SmugMug uses a Title parameter for this API function. With the current release Title is sorted after all the oauth_... parameters but it must be prior to this parameters because the uppercase 'T' is prior to the lowercase 'o' in byte value ordering.
This leads to an invalid signature error in the SmugMug API request.

Doesn't work with DotNetOpenAuth

I have a service that uses DotNetOpenAuth, but AFOAuth1Client won't work with it.

"Nonce check failed" when trying update object in api.

Hi, when I try update object in api I receive "Nonce check failed", but when I use getObjectsAtPath I get correct data.

NSString *name = @"john";
    C_Manager *m = [C_Manager new];
    RKResponseDescriptor *responseDescriptor = [RKResponseDescriptor responseDescriptorWithMapping:[m getObjectMapping] method:RKRequestMethodGET pathPattern:nil keyPath:nil statusCodes:RKStatusCodeIndexSetForClass(RKStatusCodeClassSuccessful)];
    RKObjectManager *manager = [RKObjectManager sharedManager];
    [manager addResponseDescriptor:responseDescriptor];
    [manager getObjectsAtPath:[NSString stringWithFormat:@"%@managers/%@/", url_path, name] parameters:nil success:^(RKObjectRequestOperation *operation, RKMappingResult *mappingResult) {

        C_Manager *mm = mappingResult.array.firstObject;
        DDLogInfo(@"---------------- response  result -----------------");
        DDLogInfo(@"response: %@", mm.username);
        mm.password = @"new_password";

        AFOAuth1Client *oauthClient = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:oauth_url_access] key:oauth_consumer_key secret:oauth_consumer_secret];
        [oauthClient authorizeUsingOAuthWithRequestTokenPath:@"/oauth/request_token"
                                       userAuthorizationPath:@"/oauth/authorize"
                                                 callbackURL:[NSURL URLWithString:@"mycallback-ios://success"]
                                             accessTokenPath:@"/oauth/access_token"
                                                accessMethod:@"PATCH"
                                                       scope:nil
                                                     success:^(AFOAuth1Token *accessToken, id responseObject) {
                                                         DDLogInfo(@"%@  Success: %@", NSStringFromSelector(_cmd), accessToken);

                                                         //                                                         [oauthClient setAccessToken: accessToken];
                                                         [[RKObjectManager sharedManager] setHTTPClient:oauthClient];

                                                         // PATCH object
                                                         RKObjectMapping *requestMapping = [RKObjectMapping requestMapping];
                                                         [requestMapping addAttributeMappingsFromArray:@[@"password"]];
                                                         RKRequestDescriptor *requestDescriptor = [RKRequestDescriptor requestDescriptorWithMapping:requestMapping objectClass:[C_Manager class] rootKeyPath:nil method:RKRequestMethodPATCH];
                                                         [[RKObjectManager sharedManager] addRequestDescriptor:requestDescriptor];
                                                         [[RKObjectManager sharedManager] patchObject:mm path:@"/api/v1/managers/john/" parameters:nil success:^(RKObjectRequestOperation *operation, RKMappingResult *mappingResult) {
                                                             DDLogWarn(@"!+!+!+!+!+------ %@", [mappingResult.array.firstObject valueForKey:@"email"]);
                                                         } failure:^(RKObjectRequestOperation *operation, NSError *error) {
                                                             DDLogError(@"%@ |::| Error: %@", NSStringFromSelector(_cmd), error);
                                                         }];
                                                     } failure:^(NSError *error) {
                                                         DDLogError(@"%@ Errror: %@", NSStringFromSelector(_cmd), error);
                                                     }];
    } failure:^(RKObjectRequestOperation *operation, NSError *error) {
        DDLogError(@"%@ |::| Error: %@", NSStringFromSelector(_cmd), error);
    }];

Output:

request.headers={
    "Accept-Language" = en;q=0.9, fr;q=0.8, de;q=0.7, ja;q=0.6, nl;q=0.5";
    Authorization = "..."
    "Content-Type" = "application/x-www-form-urlencoded; charset=utf-8";
    "User-Agent" = "(iPhone; iOS 7.1.2; Scale/2.00)";
}
request.body=password=new_password
2014-08-07 12:27:44.054 [17280:470b] E restkit.network:RKObjectRequestOperation.m:576 Object request failed: Underlying HTTP request operation failed with error: Error Domain=org.restkit.RestKit.ErrorDomain Code=-1011 "Expected status code in (200-299), got 401" UserInfo=0x157c2820 {NSLocalizedRecoverySuggestion={"detail": "Nonce check failed"}, AFNetworkingOperatnFailingURLRequestErrorKey=<NSMutableURLRequest: 0x1579bf60> { URL: https://api.url.be/api/v1/managers/john/ }, NSErrorFailingURLKey=https://api.url.be/api/v1/managers/john/, NSLocalizedDescription=Expected status code in (200-299), got 401, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x157d3820> { URL: https://api.url.be/api/v1/managers/john/ } { status code: 401, headers {
    Allow = "GET, PUT, PATCH, DELETE, HEAD, OPTIONS";
    Connection = "keep-alive";
    "Content-Language" = pl;
    "Content-Type" = "application/json";
    Date = "Thu, 07 Aug 2014 10:27:44 GMT";
    "Keep-Alive" = "timeout=20";
    "Transfer-Encoding" = Identity;
    Vary = "Accept, Accept-Language, Cookie";
    "Www-Authenticate" = "OAuth realm=\"api\"";
} }}
2014-08-07 12:27:44.061 [17280:470b] E restkit.network:RKObjectRequestOperation.m:238 PATCH 'https://api.url.be/api/v1/managers/john/' (401 Unauthorized / 0 objects) [request=0.4761s mapping=0.0000s total=0.4939s]:
error=Error Domain=org.restkit.RestKit.ErrorDomain Code=-1011 "Expected status code in (200-299), got 401" UserInfo=0x157c2820 {NSLocalizedRecoverySuggestion={"detail": "Nonce check failed"}, AFNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest: 0x1579bf60> { URL: https://api.url.be/api/v1/managers/john/ }, NSErrorFailingURLKey=https://api.url.be/api/v1/managers/john/, NSLocalizedDescription=Expected status code in (200-299), got 401, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x157d3820> { URL: https://api.url.be/api/v1/managers/john/ } { status code: 401, headers {
    Allow = "GET, PUT, PATCH, DELETE, HEAD, OPTIONS";
    Connection = "keep-alive";
    "Content-Language" = pl;
    "Content-Type" = "application/json";
    Date = "Thu, 07 Aug 2014 10:27:44 GMT";
    "Keep-Alive" = "timeout=20";
    "Transfer-Encoding" = Identity;
    Vary = "Accept, Accept-Language, Cookie";
    "Www-Authenticate" = "OAuth realm=\"api\"";
} }}
response.body={"detail": "Nonce check failed"}
 12:27:38:374 [17280:60b] patchTest  Success: <AFOAuth1Token: 0x157a0c80>

Tumblr OAuth 1.0a

Hi Mattt, I can't make it work with Tumblr OAuth 1.0a (http://www.tumblr.com/docs/en/api/v2#auth), for some reason oauth_signature generated by AFOAuth1Client doesn't match value expected by Tumblr. Could you please advise, what can be possibly wrong?

Error Domain=AFNetworkingErrorDomain Code=-1011 "Expected status code in (200-299), got 401" UserInfo=0x9c6ad40 {NSLocalizedRecoverySuggestion=oauth_signature [9ExDk1efS/c3j3GNua/9FUu/jhI=] does not match expected value [8M3R+nuZ9FTBgqI1jb1eNJe7EQI=], AFNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest http://www.tumblr.com/oauth/access_token?oauth_consumer_key=ISY7GdYtCDXfzo4hSfWTlaAVmkRreLBttE15Igedfr4sfaAYxW&oauth_nonce=EEA112B3-B7F5-4119-B7BE-03A1B5FEDD2C&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1359338368&oauth_token=qDuc2OAcIyonkNP2tZlrj1IDWskGziDQRwlgx5nhlHgTYUygFo&oauth_verifier=XgpmG5hKTvIhXe1CEo9nn9TS8olfc0CWQXHk6fRebEeVN0WXyy&oauth_version=1.0&realm=http%3A%2F%2Fwww.tumblr.com%2F>, NSErrorFailingURLKey=http://www.tumblr.com/oauth/access_token?oauth_consumer_key=ISY7GdYtCDXfzo4hSfWTlaAVmkRreLBttE15Igedfr4sfaAYxW&oauth_nonce=EEA112B3-B7F5-4119-B7BE-03A1B5FEDD2C&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1359338368&oauth_token=qDuc2OAcIyonkNP2tZlrj1IDWskGziDQRwlgx5nhlHgTYUygFo&oauth_verifier=XgpmG5hKTvIhXe1CEo9nn9TS8olfc0CWQXHk6fRebEeVN0WXyy&oauth_version=1.0&realm=http%3A%2F%2Fwww.tumblr.com%2F, NSLocalizedDescription=Expected status code in (200-299), got 401, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0xac4a2b0>}

My code:

AFOAuth1Client *client = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:@"http://www.tumblr.com"]
                                                             key:@"ISY7GdYtCDXfzo4hSfWTlaAVmkRreLBttE15Igedfr4sfaAYxW"
                                                          secret:@"JX994q7T9va9Rm6VNgrMw6hiLgllEQzhsB2T7TtXWhN5yYj2IZ"];

[client authorizeUsingOAuthWithRequestTokenPath:@"/oauth/request_token"
                          userAuthorizationPath:@"/oauth/authorize"
                                    callbackURL:[NSURL URLWithString:@"testapp://success"]
                                accessTokenPath:@"/oauth/access_token"
                                   accessMethod:@"GET"
                                        success:^(AFOAuth1Token *accessToken) {
                                            NSLog(@"Success: %@", accessToken);
                                        } failure:^(NSError *error) {
                                            NSLog(@"Error: %@", error);
                                        }];

Problem with ~ symbol

Hi,

First of all, great library, been working like a charm for me!

The only issue I get is with the ~ char, every other special character I've tried work just fine. For some reason if I have ~ in the content I'm posting, I get:Error Domain=AFNetworkingErrorDomain Code=-1011 , status code 400 - 40104:incorrect signature". I have tried to encode the '~' char with urlEncoding format, but still get the same error. I also noticed you have ~ removed from the encoding list on your code - but either by adding it back or not, it still gives the same.

Any help?

Thanks,

Quick Question about Login requiring Oauth

Just had an app rejected for kicking out to perform OAuth...
mainly(authorizeUsingOAuthWithRequestTokenPath )

Is it possible to for it to use a WebView, Would that be best practice for this...
Or would i need to fork and add the webView code myself?

Just wondered what other people might have done who are using this Library.

Cheers,
Michael.

LinkedIn OAuth1.0a fails

Two problems:

• Content-Type needs to be text/xml. Probably nothing to be done here, since this seems very LinkedIn-only-ish.
• "Properly handling oauth_token_secret" - Apparently 'Twitter is particularly lenient with the use of oauth_token_secret' (http://developer.linkedin.com/documents/common-issues-oauth-authentication). Maybe this deserves a pull-request update in AFOAuth1Client?

I made a subclass that works here: https://github.com/pj4533/AFLinkedInOAuth1Client

Interested to hear your thoughts. I'll make a pull request, if you think necessary.

0.2.1 Podspec needs to be updated to not pull AFNetworking 2.0.0+

AFNetworking 2.0 causes conflicts with projects with platform targets < iOS 7 and with other CocoaPods that use earlier versions of AFNetworking.

If the dependency on AFNetworking was more restrictive than "> 1.0", like "~> 1.0", that could fix the problem.

Question regarding Twitter reverse auth

Can reverse auth to twitter be achieved with this library?
https://dev.twitter.com/docs/ios/using-reverse-auth

LinkedIn wants different characters escaped

I was having trouble in my AFLinkedInOAuth1Client class, and tracked down the issue to the escaping function in AFOAuth1Client. I changed it to this to get it working:

static NSString * AFPercentEscapedQueryStringPairMemberFromStringWithEncoding(NSString *string, NSStringEncoding encoding) {
    static NSString * const kAFCharactersToBeEscaped = @":/?&=;+!@#$(),";
    static NSString * const kAFCharactersToLeaveUnescaped = @"[].~";
//    static NSString * const kAFCharactersToBeEscaped = @":/?&=;+!@#$()~";
//    static NSString * const kAFCharactersToLeaveUnescaped = @"[].";

    return (__bridge_transfer  NSString *)CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (__bridge CFStringRef)string, (__bridge CFStringRef)kAFCharactersToLeaveUnescaped, (__bridge CFStringRef)kAFCharactersToBeEscaped, CFStringConvertNSStringEncodingToEncoding(encoding));
}

Ideally, I'd like to be able to override the escapable characters in my subclass. Does it make sense to move this static function to something that could be easily overridden? Or maybe make the kAFCharactersToBeEscape/LeaveUnescaped as properties on the client?

Failed to validate oauth signature and token

I've run your example, and this is what I've got.

Error: Error Domain=AFNetworkingErrorDomain Code=-1011 "Expected status code in (200-299), got 401" UserInfo=0x8945ef0 {NSLocalizedRecoverySuggestion=Failed to validate oauth signature and token, AFNetworkingOperationFailingURLRequestErrorKey=<NSMutableURLRequest https://api.twitter.com/oauth/request_token>, NSErrorFailingURLKey=https://api.twitter.com/oauth/request_token, NSLocalizedDescription=Expected status code in (200-299), got 401, AFNetworkingOperationFailingURLResponseErrorKey=<NSHTTPURLResponse: 0x71603d0>}

0.3.2 Breaks and CocoaPods Issue

So I just noticed that upgrading from 0.3.2 from 0.3.1 breaks for me. Not sure exactly why yet but reverting back to 0.3.1 fixed the issue (I am using AFOAuth1Client to connect to the Yelp API but without any user authentication). BTW great library.

Anyway for now I was planning to fix this by staying on 0.3.1, but what is odd is that CocoaPods will still install the latest version. I updated my Podfile like this:

pod 'AFOAuth1Client', '~> 0.3.1'

But when I run pod update it still does this:

Installing AFOAuth1Client (0.3.2)

It seems like the Podspec for 0.3.1 is there in the repo and everything (https://github.com/CocoaPods/Specs/tree/master/AFOAuth1Client) so I'm not sure what the issue is. Is this a CocoaPods issue you think? I tried running pod repo update too and it still installs 0.3.2.

Duplicate oauth_timestamp values are send

A rounding error cause the oauth_timestamp to be the same in different requests causing 401 responses.

receiving oauth_tken and oauth_verifier but how to create new access token for method acquireAccess

when i connect to tumblr i receive something like this back in my app:

oauth_token=rYLleqRDZiJiG2jZUWt3AMwtjAVZZobn5nZuyhtArDfaMkcT7R&oauth_verifier=DyWKUoxPwziMZfjwFg92mjJziU2F8LHawpE8c0LcMDh1Ta6Jjg

i am able to parse the params, but how do i create a new request to get access token? the init with query string method throws and error because there is no secret in this string

Cannot acquire access_token, while trying to use with Fitbit OAuth 1.0 API

AFOAuth1Client *oAuthClient = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:@"http://api.fitbit.com/"] key:@"key-removed" secret:@"secret-removed"];

[oAuthClient authorizeUsingOAuthWithRequestTokenPath:@"/oauth/request_token" userAuthorizationPath:@"http://www.fitbit.com/oauth/authorize?display=touch" callbackURL:[NSURL URLWithString:@"bitrockr://fitbit/success"] accessTokenPath:@"/oauth/access_token" accessMethod:@"POST" scope:nil success:^(AFOAuth1Token *accessToken, id responseObject) {
    NSLog(@"AUTH COMPLETE :: %@", accessToken);
} failure:^(NSError *error) {
    NSLog(@"AUTH FAILED");
}];

I am using this for an iphone application. On running the code, the request_token is fetched, and the user is redirected to fitbit website for auth, once the user allows the app, he is returned to app with oauth_token and oauth_verifier, but it throws an error while requesting access_token. While sending the request, the only thing I could find was the oauth_verifier was not being sent.

Request sent for access_token

POST /oauth/access_token HTTP/1.1
Host: api.fitbit.com
Authorization: OAuth oauth_consumer_key="key-removed", oauth_nonce="271686CA-A50B-4D55-BD6E-AF84C9F5A28F", oauth_signature="aLpVwPCGTCWbeio4VXFj3YxI%2Fvo%3D", oauth_signature_method="HMAC-SHA1", oauth_timestamp="1377836692", oauth_token="a4bd32439b8c07831071b5385e1b15c0", oauth_version="1.0"
Accept: */*
Accept-Encoding: gzip, deflate
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Accept-Language: en;q=1, fr;q=0.9, de;q=0.8, ja;q=0.7, nl;q=0.6, it;q=0.5
Content-Length: 0
Connection: keep-alive
User-Agent: Bitrockr/1.0 (iPhone Simulator; iOS 6.1; Scale/1.00)

Response

HTTP/1.1 401 Unauthorized
Server: Apache-Coyote/1.1
X-UA-Compatible: IE=edge,chrome=1
WWW-Authenticate: OAuth realm="http%3A%2F%2Fapi01.fitbit.com", oauth_problem="permission_denied"
Set-Cookie: fhttps=""; Expires=Thu, 01-Jan-1970 00:00:10 GMT; Path=/
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Cache-control: no-store, no-cache, must-revalidate
Pragma: no-cache
Content-Type: application/x-www-form-urlencoded;charset=UTF-8
Content-Language: en-US
Content-Length: 31
Date: Fri, 30 Aug 2013 04:24:52 GMT

oauth_problem=permission_denied

Link: Fitbit OAuth API

Tutorial / Example help

Hi all
I'm new to AFOAuth1Client so please bear with me.

I am able to make requests using

AFHTTPRequestOperation *NewOperation = [oAuth HTTPRequestOperationWithRequest:NewRequest success: failure: ];
and
[oAuth enqueueHTTPRequestOperation:NewOperation];

However I'm needing to make multiple requests. So within the first success I need to make more Requests and enqueueHTTP...

1. How can you request oAuth connections synchronously ?

2. If I where to use a [oAuth postPath]; Where does one set the HTTP Body ?
   Currently I use:

NSMutableURLRequest    *NewRequest   = [oAuth requestWithMethod:@"POST" path:@"customer"  parameters:nil];
[NewRequest setValue:@"application/xml"  forHTTPHeaderField:@"Content-Type"];
[NewRequest setHTTPBody:[customer dataUsingEncoding:NSUTF8StringEncoding]];
AFHTTPRequestOperation *NewOperation = [oAuth HTTPRequestOperationWithRequest:NewRequest success:   failure:  ];

How can I achieve this with a postPath ?

Thanks In Advance

AFOAuth1Client won't build against 2.0.0-rc1

This client doesn't build against AFNetworking 2.0.0-rc1, and doesn't specify 1.3 in the podfile, so new projects using it don't build out of the box without manually specifiying AFNetworking ~> 1.3. Should we just stick with manually specifying both pods in our workspace Podfiles for now, or get a patch in?

AFOAuth1Client to authenticate received 404

On my wordpress site, I have two plugins installed WP REST API (version 2.0-beta15) and WP REST API - OAuth 1.0a Server (version 0.3.0).

On my iOS app, I'm using AFNetworking and AFOAuth1Client to authenticate the app but I'm receiving the 404 error.

Here is the code I was testing:

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {

    self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
    self.window.backgroundColor = [UIColor whiteColor];
    self.window.rootViewController = [[UITableViewController alloc] initWithStyle:UITableViewStylePlain];
    [self.window makeKeyAndVisible];

    self.twitterClient = [[AFOAuth1Client alloc] initWithBaseURL:[NSURL URLWithString:@"http://example.com/wp-json/"] key:@"WP Key" secret:@"WP secret"];

    [self.twitterClient authorizeUsingOAuthWithRequestTokenPath:@"/oauth1/request_token" userAuthorizationPath:@"/oauth1/authorize" callbackURL:[NSURL URLWithString:@"af-twitter://success"] accessTokenPath:@"/oauth1/access_token" accessMethod:@"POST" scope:nil success:^(AFOAuth1Token *accessToken, id responseObject) {

        [self.twitterClient registerHTTPOperationClass:[AFJSONRequestOperation class]];
        [self.twitterClient getPath:@"statuses/user_timeline.json" parameters:nil success:^(AFHTTPRequestOperation *operation, id responseObject) {
            NSArray *responseArray = (NSArray *)responseObject;
            [responseArray enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop) {
                NSLog(@"Success: %@", obj);
            }];
        } failure:^(AFHTTPRequestOperation *operation, NSError *error) {
            NSLog(@"Error: %@", error);
        }];
    } failure:^(NSError *error) {
        NSLog(@"Error: %@", error);
    }];

    return YES;
}

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
  sourceApplication:(NSString *)sourceApplication
         annotation:(id)annotation
{
    NSNotification *notification = [NSNotification notificationWithName:kAFApplicationLaunchedWithURLNotification object:nil userInfo:[NSDictionary dictionaryWithObject:url forKey:kAFApplicationLaunchOptionsURLKey]];
    [[NSNotificationCenter defaultCenter] postNotification:notification];

    return YES;
}

"Nonce has already been used"

I get this every time. Am I doing something wrong?

Error Error Domain=AFNetworkingErrorDomain Code=-1011 "Expected status code in (200-299), got 400" UserInfo=0x6080000f4500 {NSLocalizedRecoverySuggestion={
  "status": 400,
  "message": "Nonce has already been used. Make sure your nonces are reasonablely random and large",
  "additional": "",
  "reference": ""
}, NSErrorFailingURLKey=https://api.appfigures.com/v2/reports/sales?group_by=dates&start_date=2014-10-26

ForegroundObserver isn't removed

I remember this PR from @eriksundin aa789ce

that would take care of it.
It seems slightly altered now in 2.0, but from what I can tell, observers aren't being removed at all.

Here's a sample app
https://github.com/seivan/SHOmniAuthLinkedIn

Steps to reproduce

1. Clone master https://github.com/seivan/SHOmniAuthLinkedIn

2. Run sample

3. Tap Add account on UIActionSheet button

4. Tap Cancel on Linkedin auth

5. Repeat 3) and 4)

You'd see three "null" messages in the console, you should only see two.

baseURL that has a few path levels get truncated

When using a baseURL such as https://staging.geocaching.com/oAuth/mobileoauth.ashx/ it gets cut down to https://staging.geocaching.com/ which makes requests not work since https://staging.geocaching.com/request_token is not a valid page.

Why is this happening?

Getting 401 - Failed to validate oauth signature and token

For the life of me, I can't figure out why Twitter is rejecting my OAuth request token. As of ff783b2, I've left a lot of logging statements around to give an idea of what is going on. Excuse the mess—so it goes in desperate times.

Why not support AFNetworking2?

Compatibility with AFNetworking 2.0.0

It would be quite useful if this library would get upgraded to be comptaible with AFNetworking 2.0.0

about cocoapods and AFNetworking

Hi~
I add AFOAuth1Client and AFNetworking to my podfile, the cocoapods shows that AFOAuth1Client requires AFNetworking 1.3.4, so it installs AFNetworking 1.3.4 not the 2.0, many new methods cannot use, hope you can fix this problem : ]

Nonce always the same?

Im not sure why, maybe I dont fully understand oauth but, the oauth_nonce is always the same for me. Shouldnt this just be a randomly generated string of characters usually something to do with the timestamp etc?

Attempting to authenticate against another oauth api besides twitter and I still generate the same nonce every time.

oauth_nonce="cmVxdWVzdF90bw",

Im using the simulator, should I be using a device instead?

Does not work with current versions of AFNetworking

It doesn't seem AFOAuth1Client will work with the current version of AFNetworking - AFHTTPClient.m is duplicated between the two, but with different functionality.