aerwyn81 / aparkour Goto Github PK

THE ISSUE

In the "flattering" MC update numerical block IDs were fully removed.

This represents an unhandled issue in AParkor when using the "walkable blocks" functionality because the plugin uses numerical block IDs to store the data in the parkour save file.

The main source file in question is the WalkableBlock.java.

REPLICATE IT

1. Create an 1.17.1 server
2. install AParkour
3. Create a new parkour
   3.1. Try to add BARREL block to "walkable blocks" list of items via the GUI /aparkour setup PARKOUR.
   3.2. Nothing will happen (compared to other "old" blocks which can still be accessed via a numeric ID)
4. Stop the server
   4.1. Edit the newly created parkour savefile
   4.2. add the BARREL block ID to the "walkableBlocks" array
5. start the server
6. watch the plugin throw the exception on load because it doesn't have a clue what that block is

SOLUTION

Replace the use of numerical IDs with newer block/item naming system.

As title says; add a config option to enable/disable the confirmation menu.

• if disabled, reset/restart item will directly restart the attempt
• if enable, open the confirmation menu (current behaviour)

I have no clue what AutoRestart does. A quick glance at the codebase suggests that it's related to restarting the "parkouring attempt" (session if you will) but an average user might assume that it's related to restarting the server.

So yeah... More info in the config comment, please ?

just updated to this version from the original.
Seems to be stopping players from doing anything(place blocks, open chest, ect) even if they aren't in a parkour.

[08:01:50 ERROR]: Could not pass event PlayerChangedWorldEvent to AParkour v3.5.5
org.bukkit.event.EventException: null
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[server.jar:git-PaperSpigot-2894af04d]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.PlayerList.moveToWorld(PlayerList.java:644) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.craftbukkit.v1_8_R3.entity.CraftPlayer.teleport(CraftPlayer.java:568) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.craftbukkit.v1_8_R3.entity.CraftEntity.teleport(CraftEntity.java:236) [server.jar:git-PaperSpigot-2894af04d]
at com.fun.spawntp.Main.onJoin(Main.java:85) [SonezSpawn.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) [server.jar:git-PaperSpigot-2894af04d]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [server.jar:git-PaperSpigot-2894af04d]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.PlayerList.onPlayerJoin(PlayerList.java:314) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.PlayerList.a(PlayerList.java:173) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.LoginListener.b(LoginListener.java:144) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.LoginListener.c(LoginListener.java:54) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:231) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:148) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:875) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [server.jar:git-PaperSpigot-2894af04d]
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [server.jar:git-PaperSpigot-2894af04d]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
Caused by: java.lang.NullPointerException
at me.davidml16.aparkour.managers.StatsHologramManager.haveParkourData(StatsHologramManager.java:92) ~[?:?]
at me.davidml16.aparkour.managers.StatsHologramManager.reloadStatsHologram(StatsHologramManager.java:72) ~[?:?]
at me.davidml16.aparkour.managers.StatsHologramManager.reloadStatsHolograms(StatsHologramManager.java:63) ~[?:?]
at me.davidml16.aparkour.events.Event_Others.onWorld(Event_Others.java:146) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300) ~[server.jar:git-PaperSpigot-2894af04d]
... 28 more

As title says, player flying is not detected while parkouring.

• Using the Simple Fly Plugin.
• Option in AParkour config is enabled.
• No exceptions are thrown on startup or when I start flying.
• I do not know why it's not detecting flying.

Log: https://pastebin.com/nQ8qPW77
Parkour: https://pastebin.com/9bDd2brK

Multiverse:

21.07 15:56:49 [Server] INFO ====[ Multiverse World List ]====
21.07 15:56:49 [Server] INFO world - NORMAL
21.07 15:56:49 [Server] INFO world_the_end - THE_END
21.07 15:56:49 [Server] INFO world_nether - NETHER
21.07 15:56:49 [Server] INFO PVP - NORMAL
21.07 15:56:49 [Server] INFO spawnv2 - NORMAL

Maybe an incompatibility with last Multiverse-Core version?

Getting the following error when enabling the MYSQL external database.

• The service (mariadb) is reachable as it's used by other plugins, hosted on the same VM.
• The database is clean and just created.
• Plugin working just fine if I disable the database.

[21:53:38 ERROR]: Error occurred while enabling AParkour v3.6.0 (Is it up to date?)
java.lang.NoClassDefFoundError: com/zaxxer/hikari/pool/HikariPool$PoolInitializationException
        at me.davidml16.aparkour.database.DatabaseHandler.<init>(DatabaseHandler.java:19) ~[original-aparkour-3.6.0.jar:?]
        at me.davidml16.aparkour.Main.onEnable(Main.java:142) ~[original-aparkour-3.6.0.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[patched_1.17.1.jar:git-Airplane-87]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:370) ~[patched_1.17.1.jar:git-Airplane-87]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:500) ~[patched_1.17.1.jar:git-Airplane-87]
        at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugin(CraftServer.java:535) ~[patched_1.17.1.jar:git-Airplane-87]
        at org.bukkit.craftbukkit.v1_17_R1.CraftServer.enablePlugins(CraftServer.java:449) ~[patched_1.17.1.jar:git-Airplane-87]
        at net.minecraft.server.MinecraftServer.loadWorld(MinecraftServer.java:725) ~[patched_1.17.1.jar:git-Airplane-87]
        at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:308) ~[patched_1.17.1.jar:git-Airplane-87]
        at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1212) ~[patched_1.17.1.jar:git-Airplane-87]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Airplane-87]
        at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.ClassNotFoundException: com.zaxxer.hikari.pool.HikariPool$PoolInitializationException
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:148) ~[patched_1.17.1.jar:git-Airplane-87]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:105) ~[patched_1.17.1.jar:git-Airplane-87]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:519) ~[?:?]

Opening the issue here as this repo is more active than the original one

Getting the following error:

[02:38:52 WARN]: [LeaderHeadsRevamped] Could not fetch placeholder %aparkour_bt_lobby% from plugin PlaceholderAPI. Is the plugin properly installed?
[02:38:52 WARN]: java.lang.NoSuchMethodError: 'java.util.HashMap me.davidml16.aparkour.api.ParkourAPI.getParkours()'
[02:38:52 WARN]:        at me.davidml16.aparkourexpansion.Placeholders.onRequest(Placeholders.java:54)
[02:38:52 WARN]:        at PlaceholderAPI-2.10.10.jar//me.clip.placeholderapi.replacer.CharsReplacer.apply(CharsReplacer.java:160)
[02:38:52 WARN]:        at PlaceholderAPI-2.10.10.jar//me.clip.placeholderapi.PlaceholderAPI.setPlaceholders(PlaceholderAPI.java:70)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.c.a.e.a(e.java:3)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.d.e.a(e.java:13)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.e.e.a(e.java:185)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.f.b.a(b.java:29)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.e.e.a(e.java:113)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.e.e.c(e.java:224)
[02:38:52 WARN]:        at LeaderHeads-4.0.6.jar//tech.panoply.leaderheads.e.f.run(f.java:1)
[02:38:52 WARN]:        at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101)
[02:38:52 WARN]:        at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57)
[02:38:52 WARN]:        at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22)
[02:38:52 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
[02:38:52 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
[02:38:52 WARN]:        at java.base/java.lang.Thread.run(Thread.java:831)

This is when I try to use the placeholders. Leaderheads is just trying to get the placeholder value.
The root cause is the PAPI expansion. It does not even have the repository available anymore.

I'd like to ask you if you would be so kind to develop a new expansion jar that actually works.

Seems Potion Effects are being stored to the player's Profile but isn't being cleared allowing them to keep effects like speed, ect.