aeaghannam / got_trivia

Game of Thrones Trivia

GOT_Trivia

Game of Thrones Trivia

Abe’s Developer Notes

A standard multiple choice trivia quiz was created using JS multiple-variable arrays for questions operations and some CSS “bells and whistles” that were pulled from the site.

got_trivia's Issues

Peer Review

https://github.com/aeaghannam/GOT_Trivia/blob/master/index.js#L15-L31
Pro-I really liked how you set up the game!The questions were set up properly. Great job :)

con-I really would have liked to see more with the overall design. But it was great!

GOT_Trivia

Very good!
Pro-The game has good structure. The game is functioning properly and detailed.

To improve-Play around with the project. It would be nice to see more design. Great job!

Feedback

Project Feedback + Evaluation

Score	Expectations
0	Incomplete
1	Progressing
2	Performing
3	Excelling

Deployment: 2

Did you successfully deploy your project to github pages? Is the app's functionality the same deployed as it is locally?

Nice job!

Technical Requirements: 2

Did you deliver a project that met all the technical requirements? Given what the class has covered so far, did you build something that was reasonably complex?

Good work! You did a great job breaking the functionality into pieces. A few things that could use some more work are:

• Attaching behavior with event listeners rather than using the onlick attribute.
• Make sure that your HTML validates. You have some mismatched tags as well as some invalid tags (p0, etc).
• Indentation would make the JS much more navigable.
• Make sure that master is up to date with github-pages branch
• I haven't seen document.getElementsByName used much and using a class and document.querySelectorAll might be better.
• Might be easier keeping the questions in objects:

var questions = [ 
  { question: 'The show ‘Game of Thrones’ is based on what fantasy novel series?',
    answers: [ 'Dune', 'A Song of Ice and Fire', 'The Chronicles of Narnia' ],
    answer: 'B' },
  { question: 'The ‘Song of Ice and Fire’ was written by?',
    answers: [ 'George R. R. Martin', 'C. S. Lewis', 'R.L. Stine' ],
    answer: 'A' },
  { question: 'The events on the show take place on the fictional continents of _____ and ______?',
    answers:
     [ 'Oceania and Eurasia',
       'Westeros and Essos',
       'Coruscant and Endor' ],
    answer: 'B' }
    ...
]

Code Quality: 2

Did you follow code style guidance and best practices covered in class, such as spacing, modularity, and semantic naming? Did you comment your code?

Good job with semantic variable names and using vanilla JS.
Functions are well named.
Variables are declared ahead of time (though some could be local to their functions)

Make sure HTML and CSS validates
Want to get rid of commented out code
Make sure indentation is clear

Creativity/Interface: 2

Is your user interface easy to use and understand? Does it make sense for the problem you're solving? Does your interface demonstrate creative design?

The game looks really good and is easy to navigate. Nice job on the title and with the background