Comments (10)
Hi, its actually fixed in 4.1.3 :) I tested it in our shop and it works. Just do the update and the workaround is not needed anymore.
Edit: Our support case at adyen for which we got the message that it is fixed for reference: 03125743 with subject [Test Env] JavaScript Error causing other JS to not be executed
from adyen-shopware6.
from adyen-shopware6.
I tried to use Shopware 6 default theme, and this error still shows.
from adyen-shopware6.
I already wrote an email to adyen reporting that problem, but never got an answer. Problem is that the dist.js in shopware/vendor/adyen/adyen-shopware6/src/Resources/app/storefront/dist/storefront/js
get also loaded when installing the plugin.
A really dirty workaround:
Copy shopware/vendor/adyen/adyen-shopware6/src/AdyenPaymentShopware6.php somewhere and change the following method so it looks like this:
public function installJsAssets($shopwareVersion)
{
$storefrontAssetPath = __DIR__ . '/Resources/app/storefront/dist/storefront/js/adyen-payment-shopware6.js';
$adminAssetPath = __DIR__ . '/Resources/public/administration/js/adyen-payment-shopware6.js';
if (\version_compare($shopwareVersion, '6.5.0.0', '<')) {
$resultAdmin = copy(
__DIR__ . '/Resources/public/administration/js/adyen-payment-shopware64.js.dist',
$adminAssetPath
);
} else {
$resultStorefront = copy(
__DIR__ . '/Resources/app/storefront/dist/storefront/js/adyen-payment-shopware65.js.dist',
$storefrontAssetPath
);
$resultAdmin = copy(
__DIR__ . '/Resources/public/administration/js/adyen-payment-shopware64.js.dist',
$adminAssetPath
);
}
}
In the composer.json and the post-install and post-update cmd add these lines:
"cp **<pathtomodified>**/AdyenPaymentShopware6.php vendor/adyen/adyen-shopware6/src/AdyenPaymentShopware6.php",
"cp vendor/adyen/adyen-shopware6/src/Resources/app/storefront/dist/storefront/js/adyen-payment-shopware64.js.dist vendor/adyen/adyen-shopware6/src/Resources/app/storefront/dist/storefront/js/adyen-payment-shopware6.js || true",
"rm vendor/adyen/adyen-shopware6/src/Resources/app/storefront/dist/storefront/js/*.js.dist || true ",
from adyen-shopware6.
Hi @danijelpetkovic @PeterMarteau, thanks for opening the issue and giving more context, we have included the issue in our internal backlog and we will keep you posted of the updates
from adyen-shopware6.
@hossam-adyen @PeterMarteau Hey guys. What do you mean it is resolved in 4.1.3? That version is not existing. The latest adyen version is 3.14.3. I have that version installed and the error still occurs.
from adyen-shopware6.
Hi @danijelpetkovic thanks for your comment, I will reopen this and included in our backlog to investigate this further
from adyen-shopware6.
@danijelpetkovic I'm sorry, i of course meant 3.14.3 as the latest version, not 4.1.3. For us it fixed it. I cant test it any further for shopware version 6.4.20.2 because in the meantime we updated to shopware v6.5. But I'm pretty sure it worked with 6.4.20.2 as well. You sure you did run bin/build-storefront.sh after updating? Also i think the problematic stuff happens in the install routine of the plugin. I dont know if Adyen also included some fix in the update routine. So maybe try bin/console plugin:uninstall and then install it again.
And if it still doesnt work then just use the dirty workaround i posted earlier. This definitely worked.
from adyen-shopware6.
@PeterMarteau Thanks for the suggestions. I tried deinstalling and installing the plugin again, but the error still persists and the shop is still broken. I guess I will have to wait for Adyen fix.
@hossam-adyen Hello. Is there maybe any news on the issue? Thanks
from adyen-shopware6.
Hello @danijelpetkovic,
Thank you sincerely for your patience and collaboration throughout the process. We truly appreciate your dedication to resolving this issue.
I would like to inform you that we have opened an issue in our internal backlog to further investigate and address the reported problem. We are actively working on this, and you can expect to hear from us soon regarding a proposed solution.
Your continued cooperation and valuable insights are crucial to our efforts, and we are committed to ensuring a swift and effective resolution.
If you have any additional thoughts, questions, or updates in the meantime, please don't hesitate to share them with us.
Once again, thank you for your understanding and support.
Regards!
Khushboo
from adyen-shopware6.
Related Issues (20)
- [ECP-8562] Payment not processed, no container set HOT 5
- Adyens monolog version crashes with standard vendors monolog version HOT 4
- Various properties in FrontendProxyController do not use the Abstract* version but the constructor does HOT 4
- Headless sales channel - webhooks cannot be used HOT 1
- [ECP-8841] AbstractPaymentMethodHandler breaks the payment flow in Shopware checkout HOT 4
- Shopware 6.5.2.1 - Installation and activation are failing HOT 2
- [ECP-8840] "origin" is used from "additionalData" instead of the root property. HOT 2
- [ECP-8842] AbstractPaymentMethodHandler - Might result in TypeError upon adding the product URL $isOpenInvoice=true HOT 1
- [ECP-8628] From version 3.12.1 the plugin is no longer compatible with Shopware 6.4.*, although composer.json says "shopware/core": "^6.4.0.0" HOT 1
- [ECP-8839] CheckoutStateDataValidator is deprecated and should not be used anymore HOT 1
- Critical error when configuration is empty HOT 1
- [ECP-8904] Reinstallation flow not working HOT 1
- [ECP-8713] Building assets of Administration and Storefront without a Database HOT 8
- Implement log rotate HOT 1
- [ECP-8838] NS_BINDING_ABORTED on cancel paypal payment. HOT 1
- [ECP-8886] Improvement - Card component reset's after selecting shipping method HOT 1
- [ECP-9094] Easy way to change API settings depending on order data, e.g. depending on the products HOT 3
- [ECP-8915] AbstractPaymentMethodHandler NullPointer Exception for Products without Category/Categories HOT 1
- [ECP-9027]Incorrect Composer Version Constraints: Plugin is Not Compatible With SW Versions Older Than 6.4.15.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adyen-shopware6.