Comments (8)
Hi all!
Adding a fix in #439 to fail safely if the copy process is not possible.
Note that the plugin already ships with the generated files for Shopware 6.5, so that running the build-*.sh command should not be necessary for the plugin assets to work.
from adyen-shopware6.
Hi @wannevancamp!
Thanks for bringing this to our attention! We'll investigate this option and decide on the best way to make it easier for the majority of the plugin users.
from adyen-shopware6.
@peterojo, meanwhile we did some more research. The issue is actually not related to the build process without database. We can reproduce this in all our environments. It is actually a bigger issue than first thought because the plugin can't be used anyway.
Steps to reproduce
- Install plugin via composer
- run
composer install
(at this point the following files exists)
src/Resources/public/administration/js/adyen-payment-shopware64.js.dist
src/Resources/public/administration/js/adyen-payment-shopware645.js.dist
- build the administration
bin/build-administration.sh
(at this point the following files exists do NOT exists anymore)
src/Resources/public/administration/js/adyen-payment-shopware64.js.dist
src/Resources/public/administration/js/adyen-payment-shopware645.js.dist
- remove the cache
rm -rf var/cache/*
- visit a page (at the point the Symfony container will build by
src/AdyenPaymentShopware6.php:installJsAssets
and an error is thrown)
Warning: copy(/.../.../.../vendor/store.shopware.com/adyenpaymentshopware6/src/Resources/public/administration/js/adyen-payment-shopware64.js.dist): Failed to open stream: No such file or directory
Solution
You could maybe switch to esbuild and https://www.npmjs.com/package/@friendsofshopware/storefront-sdk so you can release the same version for both Shopware versions.
from adyen-shopware6.
This means the plugin is simply NOT working on SW 6.5
Can we bump the priority on this?
from adyen-shopware6.
We don't have this problem in our SW6.5 installation but we don't require it from store.shopware.com/adyenpaymentshopware6
, but use adyen/adyen-shopware6
from adyen-shopware6.
@MelvinAchterhuis , I've just verified. The issue occurs with both versions.
Did you run bin/build-administration.sh
and cleared the cache (rm -rf var/cache/
) afterwards?
from adyen-shopware6.
@peterojo, meanwhile I found why some merchants experience this issue and others do not.
This issue only occurs between the following Shopware versions 6.5.1.0 - 6.5.4.0.
Besides that, this can be fixed for those versions. The compatibility should be updated so that merchants know that the extension is not compatible with some versions: https://store.shopware.com/en/adyen70424242359f/adyen-payments-for-shopware-6.html
If there are no plans to fix this issue for those versions, this issue can be closed.
Some references:
- https://issues.shopware.com/issues/NEXT-28477
- shopware/shopware@92ed875 (bug introduced)
- shopware/shopware@af348ca (bug fixed)
from adyen-shopware6.
@wannevancamp thanks for your insights! we will consider whether we can fix this in a way that works either way, if not we will update the supported versions in the marketplace
from adyen-shopware6.
Related Issues (20)
- [ECP-8562] Payment not processed, no container set HOT 5
- Adyens monolog version crashes with standard vendors monolog version HOT 4
- Various properties in FrontendProxyController do not use the Abstract* version but the constructor does HOT 4
- Headless sales channel - webhooks cannot be used HOT 1
- [ECP-8841] AbstractPaymentMethodHandler breaks the payment flow in Shopware checkout HOT 4
- Shopware 6.5.2.1 - Installation and activation are failing HOT 2
- [ECP-8840] "origin" is used from "additionalData" instead of the root property. HOT 2
- [ECP-8842] AbstractPaymentMethodHandler - Might result in TypeError upon adding the product URL $isOpenInvoice=true HOT 1
- [ECP-8628] From version 3.12.1 the plugin is no longer compatible with Shopware 6.4.*, although composer.json says "shopware/core": "^6.4.0.0" HOT 1
- [ECP-8839] CheckoutStateDataValidator is deprecated and should not be used anymore HOT 1
- Critical error when configuration is empty HOT 1
- [ECP-8904] Reinstallation flow not working HOT 1
- Implement log rotate HOT 1
- [ECP-8838] NS_BINDING_ABORTED on cancel paypal payment. HOT 1
- [ECP-8832] CartPlugin already registered HOT 10
- [ECP-8886] Improvement - Card component reset's after selecting shipping method HOT 1
- [ECP-9094] Easy way to change API settings depending on order data, e.g. depending on the products HOT 3
- [ECP-8915] AbstractPaymentMethodHandler NullPointer Exception for Products without Category/Categories HOT 1
- [ECP-9027]Incorrect Composer Version Constraints: Plugin is Not Compatible With SW Versions Older Than 6.4.15.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adyen-shopware6.