Coder Social home page Coder Social logo

adyen / adyen-magento2 Goto Github PK

View Code? Open in Web Editor NEW
150.0 150.0 198.0 18.38 MB

Adyen Payment plugin for Magento2

License: MIT License

PHP 83.92% HTML 9.10% JavaScript 6.75% CSS 0.22%
adyen adyen-plugin ecommerce hacktoberfest magento magento2 magento2-extension magento2-module payments

adyen-magento2's People

Contributors

acampos1916 avatar adyen-gc avatar aleffio avatar alexandrosmor avatar candemiralp avatar carlosperales95 avatar cenkiravul avatar cyattilakiss avatar ebaschiera avatar frankstappers avatar hossam-adyen avatar imrankln avatar khushboo-singhvi avatar lancergr avatar maassenbas avatar maikel-koek avatar michaelpaul avatar morerice avatar msilvagarcia avatar nuranto avatar peterojo avatar pmzandbergen avatar raoulritter avatar renovate[bot] avatar rikterbeek avatar rokpopov avatar stkams avatar sushmitathakur avatar tnaber avatar tuyennn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

adyen-magento2's Issues

Order email can be sent twice

Within cron.php no check is done if the order email already has been sent.
If _authorizePayment is called twice or case Notification::PENDING: hits twice (or a combination of the two) the customer will receive multiple order confirmation emails.

Label not clickable due to duplicate ID:s "billing-save-in-address-book"

How to reproduce:

  1. Log in and make sure you have an address saved in you address book.
  2. Go to the payment step, choose Adyen (issue reproduced using Adyen HPP)
  3. Uncheck "My billing and shipping address are the same"
  4. Choose "new address" in the dropdown.
  5. The label for the checkbox "Save in Address book" below the address form is not clickable.

The reason for this is that multiple checkboxes with the same ID (billing-save-in-address-book) exists.

Attached screenshot of affected checkbox
screen shot 2016-04-25 at 11 34 02

Payment methods not showing after upgrade from 1.3 to 1.4.3

Hi,

I just upgraded the extension to 1.4.3 via composer. But now my payment menthods are not showing anymore. Before the upgrade at version 1.3 they were showing just fine. I am using the Adyen test setup. Is there a setting changed that I cant find or is this a known issue maybe?

Thanks!

Not able to see the HPP iDEAL option in admin panel

Hi Team,

First of all thanks for fantastic plugin. I have installed the extension on my Magento2 EE and I can able to see the all payment option except HPP iDEAL and that's the option I have to work on. Could you please advise what I have missing so I can fix it.

Groet,
Yogi

Shipping undefined when cancelling POS payment

When it returns to the website after a cancelled or failed POS payment, the summary shows "Shipping (undefined - undefined)". It's on the first page where it's redirected to, along with the error message of the failed payment.

Non-declared and unused property

I'm talking about $this->_debugData.

a) Because it's not declared, it's going to become public by default (leaking info);
b) It's not used. The information it gathers is not logged (as I'm assuming that was the intention);
c) There's a possibility of key overwriting (error for example), and debug info could be lost. Can't the logger be used directly (with context for Step 1 etc.), instead of that array?

Module not installable through packagist.org

Problem

We are trying to install Adyen through https://packagist.org/packages/adyen/module-payment but it's currently failing because it can't find the latest 1.1.0 tagged version.

$ composer require adyen/module-payment:1.1.0
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package adyen/module-payment could not be found in any version, there may be a typo in the package name.
  Problem 2
    - justinrainbow/json-schema 1.6.1 requires php >=5.3.29 -> no matching package found.
    - justinrainbow/json-schema 1.6.1 requires php >=5.3.29 -> no matching package found.
    - Installation request for justinrainbow/json-schema == 1.6.1.0 -> satisfiable by justinrainbow/json-schema[1.6.1].

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

Expected Result

Could you update https://packagist.org/packages/adyen/module-payment with the latest release, similar to https://packagist.org/packages/magestore/module-bannerslider where they have 0.1.5?

Guest checkout - Remember these details

My QA team has picked up on this issue and I am wondering if this intended behaviour or if this is a bug.

I have tried to use one click checkout after placing an order as a guest but it doesn't store the credit card details for future reuse both as a guest and a registered user with the same email, this is the behaviour I would expect for security reasons.

Can you please confirm, thanks.

Issue

Guest able to see and select remember card details in card payment section, doesn't seem to have any functional use.

Steps to replicate

1 Launch site on browser
2 Add an item to the cart from PLP/PDP/SRP
3 Click on basket icon
4 Click edit cart link in the Utility menu
5 Click checkout option from the Shopping Cart page
6 Add Shipping address
7 Select shipping method & click Next
8 Select My billing and shipping address are the same and continue to payment section
9 Check card payment option is available
10 Select the Card option & select a card
11 Verify the option to save the payment card

Expected Behaviour

1 User should able to launch site on browser
2 User should able to add an item to cart form any PLP/PDP/SRP
3 User should able to view utility menu
4 Shopping Cart page should be displayed with all the items that is added by the user
5 User should navigate to Checkout page
6 User should be able to add shipping address
7 Shipping method should be selected & user should navigate to Billing Information section
8 Billing address saved same as shipping address .
9 Card payment option is available in the Payment page
10 Card payment section expands
11 Option to save payment card should not be available

Image

remember

Error on checkout page.

I have successfully installed the module and I can configure it from backend for test.
But when I go to checkout page it gives me error like:

Fatal error: Class 'Adyen\Client' not found in C:\xampp\htdocs\magento2\app\code\Adyen\Payment\Model\Api\PaymentRequest.php on line 96

Please help.
Thanks

refunds not implemented

Refunds initiated from Adyen are not implemented. Code is quoted.
Also when buildign this function emailing the credit email to the customer should NOT be depending on orderupdate email setting but on a seperate setting (allow sent refund emails)

Create dependencies for the module

If you install the module on a clean installation it will fail because it is loaded as one of the first modules because of alphabetical order.

Duplicated admin settings naming

Problem

If you see in http://www.vaimo.com/snaps/pablo.ivulic/adyen-duplicate-admin-settings.png, you will see that there are two "Webservice username" and two "Webservice Password" passwords.

It's not a big problem, since each setting has an excellent tool tip explanation, but might be slightly confusing for new eyes.

Expected Result

Maybe name each setting differently, something like:

  • Webservice username (test)
  • Webservice Password (test)
  • Webservice username (live)
  • Webservice Password (live)

EDIT: Or name them so that they correspond to https://docs.adyen.com/manuals/magento/magento2-integration/configuring-the-adyen-plugin/required-settings :)

Empty cart when clicking 'back' on Adyen Payment page

Not sure if this is a bug, a new feature or something that's not possible:
When you get to the Adyen Payment page from the checkout and click 'cancel', you go back to your cart with the products still inside. However, when clicking the 'back' button of your browser, you get an empty cart.

You would expect the same result (a cart with your selected products) when clicking the 'back' button in your browser.

Support for Magento 2.1

With the release of Magento 2.1 I'd really like to upgrade, however the Adyen-Magento-2 module does not support it yet. When may I (we) expect support for 2.1 (or internal/composer version 100.1.*)? The change could possibly be small (only in composer.json) but the code needs to be tested with the new version.

Thanks in advance!

Confirmation emails sent out too early

Using Magento 2.0.5 and adyen-magento-2 1.2.1 in test mode for HPP, I get my confirmation emails when I go to the HPP provider already. I haven't paid anything at that time yet - my order is coming in ad pending, but of course it isn't. Anyone experiencing this?

Checkout agreements don't work with Adyen payment method

When you enable checkout agreements (Terms and Conditions) and want to submit your order by clicking the button Continue to Adyen. Magento does a request to rest/default/V1/carts/mine/payment-information. And this gives an error.

<b>Fatal error</b>:  Call to a member function getAgreementIds() on null in <b>/vendor/magento/module-checkout-agreements/Model/Checkout/Plugin/Validation.php</b> on line <b>62</b><br />
{"messages":{"error":[{"code":500,"message":"Fatal Error: 'Call to a member function getAgreementIds() on null' in '\/vendor\/magento\/module-checkout-agreements\/Model\/Checkout\/Plugin\/Validation.php' on line 62","trace":"Trace is not available."}]}}

There's a plugin written beforeSavePaymentInformation.

    public function beforeSavePaymentInformation(
        \Magento\Checkout\Api\PaymentInformationManagementInterface $subject,
        $cartId,
        \Magento\Quote\Api\Data\PaymentInterface $paymentMethod,
        \Magento\Quote\Api\Data\AddressInterface $billingAddress
    ) {
        if ($this->isAgreementEnabled()) {
            $this->validateAgreements($paymentMethod->getExtensionAttributes()->getAgreementIds());
        }
    }

The function $paymentMethod->getExtensionAttributes() returns null. I don't know what Magento is expecting here, but my guess is there's something missing in the Adyen extension.

New order after pos payment has the wrong status

I'm trying to implements the POS payment on my magento website, so I created a new order status (pending payment) on which the order should be set when it is created. After the payment is finished it should be processing or canceled. But it still gets the status 'Pending', before the payment is even finished. Also the mail is send before the payment is finished..

I'm using version 1.2.1 of the adyen extension and one of the latest clones of the magento develop branche.

Looks like a bug?

Payment method selection based on shipping country

Payment selection should use the shipping country to show the selected payment methods.
Now a new customer will not get country specific payment methods because billing address country is not selected in the checkout.

Expired orders don't get canceled

The Magento Cron does not clear any orders where Adyen HPP was used as a payment method.
If the customer leaves the checkout process on the Adyen HPP page, the order status stays on "pending" and is not set to "cancelled" by the Magento expired orders cron (module-sales/Model/CronJob/CleanExpiredOrders.php).

We believe the reason is, that CleanExpiredOrders.php is looking for orders with the status STATE_PENDING_PAYMENT (line 55), but the Adyen extension is setting the order status to what is configured in the Adyen configuration options (line 221 in adyen-magento2/Model/Method/Hpp.php). The "pending" option in the dropdown in the Adyen config is really "pending" though and there is no option to choose "pending_payment".

Thanks,
Julian

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.