adsva / python-wapiti Goto Github PK

hi @adsva

I work with tools in the open source community through the Anaconda package manager under the conda-forge channel and I recently run into libwapiti, which I'm suspecting that the way it was added has no direct link to the work you have here on github. It seems that another person packaged and distributed the repo on pypi.org but there is no information about the license under which it was released.

If you're interested in sharing your work to the Anaconda community, I would like to correct the errors others made by linking the package directly to your github account as well as with your permission and licensing. On your end, this w'd require adding a license type of your choice and creating a release version of your work on github.

Thank you for contributing the wrapper and, hopefully, people will at least start to show some level appreciation when they depend on your work.

Regards,
-Eddie

Hi,
I've tried to build this package in Windows, and there is some errors which you may want to fix:

C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -Icwapiti/src -Ilibwapiti -IC:\Python34\include -IC:\Python34\include /Tccwapiti/src/bcd.c /Fobuild\temp.win32-3.4\Release\cwapiti/src/bcd.obj -std=c99
cl : Command line warning D9002 : ignoring unknown option '-std=c99' 
bcd.c
cwapiti/src/bcd.c(30) : fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory

Here is complete build log for common python versions and windows architectures.

It seems there is some shared state that is not encapsulated in Model class: I recall model.train continues training where it left for previous model; sometimes it exits with "error: invalid feature: " error on second training (while working on first).

Sorry, no reproducable example to check that :)

It seems that here: https://github.com/adsva/python-wapiti/blob/master/wapiti/api.py#L46 we should assign return type to ctypes.pythonapi.PyFile_AsFile - our own PyFile_AsFile is unused here : https://github.com/adsva/python-wapiti/blob/master/wapiti/api.py#L313