adobe / aem-cif-project-archetype Goto Github PK

Expected Behaviour

• A new project shall be ready to use when it is created by the provided archetype 0.7.0

Actual Behaviour

• Created archetype contains errors

Reproduce Scenario (including but not limited to)

Steps to Reproduce

• Start a fresh AEM instance
• Create a new project using the latest archetype:
  mvn archetype:generate \ -DarchetypeGroupId=com.adobe.commerce.cif \ -DarchetypeArtifactId=cif-project-archetype \ -DarchetypeVersion=0.7.0
• Build and install project:
  mvn clean install -PautoInstallAll,adobe-public
• Open package manager
• Find "core-cif-components-apps-0.7.0.zip" package
• Check its dependencies
• "day/cq60/product:cif-connector-content:0.8.0" is missing and highlighted in red
• Open AEM Commerce Products console (http://localhost:4502/aem/products.html/var/commerce/products)
• Click Create - there no Bind Products item

I tried to add missed library dependency and after that I found that "core-cif-components-apps-0.7.0" requires additional dependency "cif-virtual-catalog-content". After including all missed dependencies all packages were installed correctly and I found the Bind Products item in the AEM Commerce Products console. But now I have another error when I click the "Bind Products" which shows "Unable to compile class for JSP: An error occurred at line: 15 in the generated java file Only a type can be imported."

Exception:

org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile class for JSP:

An error occurred at line: 15 in the generated java file
Only a type can be imported. com.adobe.cq.commerce.virtual.catalog.data.CatalogDataResourceProviderFactory resolves to a package

An error occurred at line: 16 in the generated java file
Only a type can be imported. com.adobe.cq.commerce.virtual.catalog.data.CatalogDataResourceProviderManager resolves to a package

An error occurred at line: 29 in the jsp file: /libs/commerce/gui/components/admin/products/bindproducttreewizard/commerceproviderdatasource/commerceproviderdatasource.jsp
CatalogDataResourceProviderFactory cannot be resolved to a type
26: <%@include file="/libs/foundation/global.jsp" %>
27: <%
28: // Get data for datasource
29: Map<String, CatalogDataResourceProviderFactory<?>> dataResourceProviderFactories =
30: sling.getService(CatalogDataResourceProviderManager.class).getProviderFactories();
31:
32: // Build datasource

An error occurred at line: 30 in the jsp file: /libs/commerce/gui/components/admin/products/bindproducttreewizard/commerceproviderdatasource/commerceproviderdatasource.jsp
CatalogDataResourceProviderManager cannot be resolved to a type
27: <%
28: // Get data for datasource
29: Map<String, CatalogDataResourceProviderFactory<?>> dataResourceProviderFactories =
30: sling.getService(CatalogDataResourceProviderManager.class).getProviderFactories();
31:
32: // Build datasource
33: ArrayList resourceList = new ArrayList();

at org.apache.sling.scripting.jsp.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:93)
at org.apache.sling.scripting.jsp.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:330)
at org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:136)
at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:304)
at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:282)
at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:269)
at org.apache.sling.scripting.jsp.jasper.JspCompilationContext.compile(JspCompilationContext.java:501)

Platform and Version

• AEM 6.5
• Archetype 0.7.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

After reading a bit through issues and the READMEs of both projects it is still unclear to me what the difference between the two archetypes is.

The aem-project-archetype supports CIF since May 28th PR and includes newer versions of the CIF Core Components, etc.

Why does it need the aem-cif-project-archetype? Is it only for people who don't need the whole library of WCM core components?

Thanks.

### Expected Behaviour
When you change layout perspectives (desktop, tablet, iphone) that the page still has content

### Actual Behaviour
When you change the layout perspective, the query for content to Magento is lost and page goes blank.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

view a category page which has products in preview mode, switch to layout mode and then change perspective. Poof, products are disappear.

View of category page in desktop mode after arriving in preview mode

Click on tablet or mobile to change perspective and products disappear

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Expected Behaviour

Template editor should continue working after building with the 'autoInstallPackage' and 'autoInstallBundle' profiles selected.

Actual Behaviour

The template editor is NOT working, console errors are thrown

Video showing the issue: https://www.youtube.com/watch?v=XmB_xNg3dVo&feature=youtu.be

Reproduce Scenario (including but not limited to)

• Spin up a clean AEM 6.4 instance
• Upgrade to 6.4.5.0
• Build the archetype project using the 'autoInstallPackage' and 'autoInstallBundle' profiles
• Template editor shouldn't be working anymore

Platform and Version

• AEM: 6.4.5.0
• Archetype: 0.6.0

User Story

As a user I'd like to be able to have some basic styling in places for searching and filtering functionality.

Description & Motivation

Working towards allowing for filtering of search and product listing (e.g. category) pages it (see this issue here) would be convenient to have some simple styles in demo-projects that provide a reasonable looking left bar for attribute filters.

Deliverables

Some very simple styling for new components introduced in any PRs related to (aem-core-cif-components issue #198)

Acceptance Criteria

Building the archetype and deploying the demo store should include basic styles for the search related enhancements (primarily filters and some slightly different modified structure for search and category / product list templates)

Verification Steps

1. Deploy code changes required for search filtering functionality
2. build and deploy this archtype
3. verify CSS styles are available to provide basic styling for any filtering or search related features that have been added

I am unable to see the mini cart on top right corner after creating a new project using demo-store.all-0.9.0.zip from latest release here https://github.com/adobe/aem-cif-project-archetype/releases and installing it through package manager in my AEM 6.5. Do I need to install it separately? I am following this integration through https://www.adobe.io/apis/experiencecloud/commerce-integration-framework/getting-started.html

Expected Behaviour

Actual Behaviour

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Use version 0.6.2 & 0.6.0 to create a new cif project and enable DoptionEmbedConnector
mvn archetype:generate ^
-DarchetypeGroupId=com.adobe.commerce.cif ^
-DarchetypeArtifactId=cif-project-archetype ^
-DoptionEmbedConnector=y ^
-DarchetypeVersion=0.6.2

Platform and Version

CIF archetype: 0.6.0 & 0.6.2

Sample Code that illustrates the problem

How to fix.
Please release a new archetype and change cif connect version to 0.7.1.
https://github.com/adobe/aem-cif-project-archetype/blob/master/src/main/archetype/pom.xml

User Story

Description & Motivation

Deliverables

Acceptance Criteria

Verification Steps

Hello,

I am using Adobe Cloud Manager as part of my CI/CD process to push changes to my STAGE and PROD environment.

I tried pushing latest release of the Venia Demo Store Project, 578dcdc, via Cloud Manager.

The code passed all code quality checked except "code coverage", which means the project must have unit tests to cover at least 50% of the core code/functions.

Can unit tests be added to the next release?

Thanks,

Expected Behaviour

When generating a new project using the archetype all maven variables are replaced.

Actual Behaviour

${cssId}.grid is leftover in the clientlib-base clientlib definition:

https://github.com/adobe/aem-cif-project-archetype/blob/master/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appsFolderName__/clientlibs/clientlib-base/.content.xml#L6

Reproduce Scenario (including but not limited to)

Generate a new project using the archetype

User Story

(This is a minor enhancement, and might be covered already as part of future work but wanted to note it, so as it does not get forgotten)

As a developer, I would like the responsive grid to be a client library as part of the generated project, so project-specific breakpoints can be implemented.

Currently the wcm.foundation.components.page.responsive category is included as part of the Page policy templates, which enables the responsive layout features of AEM. However, because this client library lives under /libs developers cannot modify the breakpoints of the generated file.

Description & Motivation

Most implementations have custom breakpoints for device widths they want to support.
The AEM project archetype does this by creating a clientlib-grid as part of the ui.apps module.

Aside from not being able to define custom breakpoints, projects can't use the /libs/wcm/foundation/components/page/responsive library because it does not have the allowProxy property set and serves the CSS directly from /libs:

<link rel="stylesheet" href="/libs/wcm/foundation/components/page/responsive.css" type="text/css">

Orders Placed through AEM should Reflect correctly in Magento but the orders are being placed as unknown/logged out user at magento side , due to which it creates problem in creating and fetching graphql response for order history, order detail or reorder functionalities.

Below Query returns null

{ customerOrders { items { order_number id created_at grand_total status } } }