adobe-webplatform / snap.svg Goto Github PK

According to the API docs Element.removeData should remove all the data from the element, but in this test it leaves part of the data.

https://github.com/adobe-webplatform/savage/blob/db9eb2e8a2eefdceb1b8f727c4f1aa8f73979b6e/test/element.js#L175

API docs refer to Savage.pathBBox, this should probably be changed to Savage.path.getBBox or added as an alias.

Once all issues have been addressed, create a v0.1.0 tag and get Yohie the link to the zip file.

People won't always know to "twist" (drag) the knob. Please make the labels clickable, as well.

See test:
https://github.com/adobe-webplatform/savage/blob/fd8db10bd352f804917fe7de0715a39551addd69/test/element.js#L578

And add to your .gitignore file.

Test:
https://github.com/adobe-webplatform/savage/blob/b04c154dfeb32f6c4534ba2136115455c56933e4/test/set.js#L80

The docs claim the returned output is an object with a certain format, instead it returns a BBox object that does not match that format. I assume the docs here are incorrect, rather than the behavior.

Not sure if this is a problem with the way I'm testing the method, but I would expect it to work.

Test:
https://github.com/adobe-webplatform/savage/blob/440f4cef941b76518d3de384c70959c6d959ef8c/test/element.js#L600

The docs mention a Savage.findDotsAtSegment but this should probably be Savage.path.findDotsAtSegment

According to the API docs under Savage.getRGB(colour) it should be possible to parse colors with percentages set, like rgb(•••%, •••%, •••%) for rgb, hsl and hsb. However, all tests with strings like this appear to fail.

The docs for Snap skip over the constructor options.

Change the project description to:

A JavaScript library for modern SVG graphics.

The map is positioned differently and moves off the bottom of the screen. (Low priority.)

Unlike the docs claim, the "string" property in the object returned by Element.transform() is an array of strings, rather than a string.

Test:
https://github.com/adobe-webplatform/savage/blob/630b66058d99e183192643fd16e6df03d66a1af0/test/element.js#L370

See here:
https://github.com/adobe-webplatform/savage/blob/master/src/path.js#L552

Looks like it's expected to be String.prototype.toLowerCase

Looks like the code should be:
return animations[id] || null;

instead of:
return animations[anim.id] || null;

Test:
https://github.com/adobe-webplatform/savage/blob/b04c154dfeb32f6c4534ba2136115455c56933e4/test/mina.js#L43

Test throws error: ReferenceError: unit2px is not defined

Test:
https://github.com/adobe-webplatform/savage/blob/eea4f89d29c5df1fa53f721022a878bb2ca3d9bb/test/element.js#L178

Looking the API docs and existing tests, the following methods still need testing and will be tracked here:

Savage

• Savage.Matrix()
• Savage.ajax()
• Savage.animate()
• Savage.animation()
• Savage.color()
• Savage.deg()
• Savage.format()
• Savage.fragment()
• Savage.getRGB()
• Savage.hsb()
• Savage.hsb2rgb()
• Savage.hsl()
• Savage.hsl2rgb()
• Savage.is()
• Savage.load()
• Savage.parse()
• Savage.parsePathString()
• Savage.parseTransformString()
• Savage.pathBBox()
• Savage.rad()
• Savage.rgb()
• Savage.rgb2hsb()
• Savage.rgb2hsl()
• Savage.select()
• Savage.selectAll()
• Savage.snapTo()

Savage.filter

• Savage.filter.blur()
• Savage.filter.brightness()
• Savage.filter.contrast()
• Savage.filter.grayscale()
• Savage.filter.hueRotate()
• Savage.filter.invert()
• Savage.filter.saturate()
• Savage.filter.sepia()
• Savage.filter.shadow()

Savage.path

• Savage.path.findDotsAtSegment()
• Savage.path.toAbsolute()
• Savage.path.toCubic()
• Savage.path.toRelative()
• Savage.path.map()
• Savage.path.isPointInside()
• Savage.path.intersection()

Matrix

• Matrix.add()
• Matrix.clone()
• Matrix.invert()
• Matrix.rotate()
• Matrix.scale()
• Matrix.split()
• Matrix.toTransformString()
• Matrix.translate()
• Matrix.x()
• Matrix.y()

Set

• Set.clear()
• Set.exclude()
• Set.forEach()
• Set.pop()
• Set.push()
• Set.splice()

Mina

• mina.backin()
• mina.backout()
• mina.bounce()
• mina.easein()
• mina.easeinout()
• mina.easeout()
• mina.elastic()
• mina.getById()
• mina.linear()
• mina.time()

Uncaught TypeError: Property '-72' of object # is not a function

Very high priority.

The snap-mascot demo isn't working. Mousing over the mascot throws this error:

Uncaught TypeError: string is not a function: snap.svg-min.js 18

Check the screenshot. Please do one of the following:

• Use a font from Typekit/Edge Web Fonts.
• Use a font that more people have installed.

Please do not:

• Check in the AdobeClean-Light font into this repo. (We can't do that.)

Let me know if you have questions. If you need another font, ask Yohei.

The API docs say Element.clone creates and returns a element, but the implementation uses cloneNode to copy the element, without a element being created.

following code does not animate line as it should:

var s = new Snap('100%', '100%');
myPath = s.path('M0,0c0,0,0-28.008,0-46.707S0-89,0-89');
myPath.attr({
'fill': 'none',
'stroke': 'red',
'stroke-width': 25,
'stroke-miterlimit': 10,
'stroke-linecap': 'round',
'opacity': 1,
'stroke-dasharray': "120 200",
'stroke-dashoffset': 0
});
myPath.transform('translate(100, 300)');
myPath.animate({'stroke-dashoffset': 120});

Probably the same issue as in issue #5

Tests:
https://github.com/adobe-webplatform/savage/blob/master/test/savage-tests.js#L89
https://github.com/adobe-webplatform/savage/blob/master/test/savage-tests.js#L156

works fine on chrome though

Test returns 'eldata is not defined' error when attempting to set data.

Test:
https://github.com/adobe-webplatform/savage/blob/eea4f89d29c5df1fa53f721022a878bb2ca3d9bb/test/element.js#L145

I know, this one's kind of nitpicky, but since the docs say it returns a boolean, it's technically failing. :)

Test:
https://github.com/adobe-webplatform/savage/blob/b04c154dfeb32f6c4534ba2136115455c56933e4/test/set.js#L28

npm / component / bower or something so that the little chunks are useful to people (and to keep yourself sane), then produce a snap build from those. Otherwise looks good! :D

See attached screenshot

Add a link to the Snap.svg site in the README. The link is (or will be) snapsvg.io.

The README should mention that you might need to use sudo with npm, depending on your configuration.

Should be easily fixed by replacing this.node.parentNode with this.node

Test: https://github.com/adobe-webplatform/savage/blob/eea4f89d29c5df1fa53f721022a878bb2ca3d9bb/test/element.js#L56

Write a getting started guide for the site, and link to it from the README. It should include:

• Getting the repo (or downloading the zip file).
• Building it with grunt.
• Including the library.
• Initializing Snap.
• Drawing a couple of shapes.
• Animating them.

Write it up, and send it to Yohei for inclusion on the site.

IE10, Getting Started - clicking forward button often gets stuck at step 2 and 3. Works fine with Chrome

Came across a case where Element.animate() is not triggered from within another Element.animate()'s callback. I was able to resolve the issue by wrapping the second animate function in a setTimeout of 50ms. Appears to be a timing issue.

road_bottom.animate({x2:691.5}, 2000, function(){
    tunnel_mask_bottom_right.animate({
        y: 394,
        height:150
    }, 200);
    });

See attached screenshot. Works fine with Chrome

This is also causing my innerSVG test to fail, after finding that I split it up into a new test.

See test:
https://github.com/adobe-webplatform/savage/blob/440f4cef941b76518d3de384c70959c6d959ef8c/test/element.js#L151

Investigate why the test is not passing while the same code on the page is working perfectly.

The broken test code:

    it("Element.asPX - from em", function() {
        var rect = s.rect(0, 0, 10, '10em');
        var heightAsPx = rect.asPX("height");
        expect(heightAsPx).to.be(160); // assumes 1em = 16px, is this safe?
    });

Test here:
https://github.com/adobe-webplatform/savage/blob/531fca593769a696502be3ede2d5dbe424fc3dee/test/filter.js#L68

It returns {from: 0, to: 0}, which doesn’t make sense.

Create a "demos" directory for the samples. Create directories for each demo so the HTML and SVG assets are together. Name the demo directories something descriptive (i.e. "map", "barista", etc.).

Currently it appears as:
Matrix.add(a, b, c, d, e, f, matrix)

which based on the code should be split to accepting either a-f params or just the matrix.

This test used to pass, so appears to have broken with a fairly recent change.

Test:
https://github.com/adobe-webplatform/savage/blob/2a8f553eaf66b5036c4442556333cd6701f5c963/test/element.js#L182

We decided to get rid of the code callouts on the coffee maker demo, so please remove them.

Seems like the callback never gets called. Works fine with only easing/callback or neither, but problem occurs when supplying both.

Test:
https://github.com/adobe-webplatform/savage/blob/630b66058d99e183192643fd16e6df03d66a1af0/test/element.js#L314

Let's debug. If it's a bug in Snap, please assign to Dmitry.

Let's make the docs browsable (a GitHub page?) and put a link in the README.